From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934144AbcKPPOU (ORCPT ); Wed, 16 Nov 2016 10:14:20 -0500 Received: from mail-qk0-f177.google.com ([209.85.220.177]:34112 "EHLO mail-qk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932255AbcKPPOR (ORCPT ); Wed, 16 Nov 2016 10:14:17 -0500 Date: Wed, 16 Nov 2016 15:17:11 +0000 From: Lee Jones To: Johan Hovold Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: core: fix device reference leak in mfd_clone_cell Message-ID: <20161116151711.GA18935@dell> References: <1477996698-28870-1-git-send-email-johan@kernel.org> <20161114182501.GC4094@dell> <20161116091740.GA4864@localhost> <20161116095944.GF4094@dell> <20161116100622.GB4864@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161116100622.GB4864@localhost> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Nov 2016, Johan Hovold wrote: > On Wed, Nov 16, 2016 at 09:59:44AM +0000, Lee Jones wrote: > > On Wed, 16 Nov 2016, Johan Hovold wrote: > > > > > On Mon, Nov 14, 2016 at 06:25:01PM +0000, Lee Jones wrote: > > > > On Tue, 01 Nov 2016, Johan Hovold wrote: > > > > > > > > > Make sure to drop the reference taken by bus_find_device_by_name() > > > > > before returning from mfd_clone_cell(). > > > > > > > > > > Fixes: a9bbba996302 ("mfd: add platform_device sharing support for mfd") > > > > > Signed-off-by: Johan Hovold > > > > > --- > > > > > drivers/mfd/mfd-core.c | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > Applied, thanks. > > > > > > I do not see this one in linux-next (or your tree). Did you forget to > > > push? > > > > Since I tend to flit between maintaining and real-work, I tend to bulk > > push once I have a bunch of fixes/updates. Your fix should appear in > > -next tomorrow. The plan is to have it in upstream by next week. > > Sounds good, thanks for the explanation. FYI, I submitted your patch to Linus today. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog