From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941304AbcKQGuA (ORCPT ); Thu, 17 Nov 2016 01:50:00 -0500 Received: from mail-pg0-f49.google.com ([74.125.83.49]:36238 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941111AbcKQGt6 (ORCPT ); Thu, 17 Nov 2016 01:49:58 -0500 Date: Thu, 17 Nov 2016 12:19:54 +0530 From: Viresh Kumar To: Srinivas Pandruvada Cc: rjw@rjwysocki.net, morten.rasmussen@arm.com, Juri.Lelli@arm.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH] cpufreq: intel_pstate: Support of energy performance hint using HWP Message-ID: <20161117064954.GD4894@vireshk-i7> References: <1479250783-74336-1-git-send-email-srinivas.pandruvada@linux.intel.com> <1479250783-74336-2-git-send-email-srinivas.pandruvada@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479250783-74336-2-git-send-email-srinivas.pandruvada@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Srinivas, I don't think other platforms need it for now and so it is fine to add these to the driver itself. On 15-11-16, 14:59, Srinivas Pandruvada wrote: > +static ssize_t show_energy_performance_available_preferences( Maybe a personal preference, but I would have broken the line after ssize_t instead of where you have done it. > + struct cpufreq_policy *policy, char *buf) > +{ > +static struct freq_attr *hwp_cpufreq_attrs[] = { > + &energy_performance_preference, > + &energy_performance_available_preferences, > + NULL, > +}; What about adding these to intel_pstate_attr_group instead ? -- viresh