From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753528AbcKQHv2 (ORCPT ); Thu, 17 Nov 2016 02:51:28 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:34130 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746AbcKQHv0 (ORCPT ); Thu, 17 Nov 2016 02:51:26 -0500 Date: Thu, 17 Nov 2016 08:51:23 +0100 From: Boris Brezillon To: Peter Pan Cc: Richard Weinberger , linux-mtd@lists.infradead.org, David Woodhouse , Brian Norris , Ezequiel Garcia , linux-kernel@vger.kernel.org, "peterpandong@micron.com" Subject: Re: [PATCH v2 6/7] mtd: nand: raw: make BBT code more generic Message-ID: <20161117085123.3d850e81@bbrezillon> In-Reply-To: References: <1476628518-20450-1-git-send-email-boris.brezillon@free-electrons.com> <1476628518-20450-7-git-send-email-boris.brezillon@free-electrons.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Nov 2016 14:19:29 +0800 Peter Pan wrote: > Hi Boris, > > On Sun, Oct 16, 2016 at 10:35 PM, Boris Brezillon > wrote: > > BBT support is currently tightly tied to raw NAND, though this is the kind > > of code we could share across all NAND based devices, no matter what > > physical interface is to communicate with the NAND chip. > > > > Make BBT code interface agnostic by replacing all occurrence of > > struct nand_chip by struct nand_device, and move functions that are > > specific to raw NANDs to drivers/mtd/nand/rawnand/nand_base.c. > > > > Signed-off-by: Boris Brezillon > > --- > > drivers/mtd/nand/raw/nand_base.c | 78 ++++- > > drivers/mtd/nand/raw/nand_bbt.c | 609 ++++++++++++++++++--------------------- > > include/linux/mtd/nand.h | 8 + > > include/linux/mtd/rawnand.h | 4 - > > 4 files changed, 361 insertions(+), 338 deletions(-) > > > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > > index b86f4a1bfbe1..4930b3569de9 100644 > > --- a/drivers/mtd/nand/raw/nand_base.c > > +++ b/drivers/mtd/nand/raw/nand_base.c > > @@ -471,7 +471,7 @@ static int nand_block_markbad_lowlevel(struct mtd_info *mtd, loff_t ofs) > > > > /* Mark block bad in BBT */ > > if (chip->bbt) { > > Should be "if (!nand->bbt.bbt)". Indeed. And this makes me realize this chip->bbt field should be gone (which is not the case since I had no compilation error). > > > - res = nand_markbad_bbt(mtd, ofs); > > + res = nand_markbad_bbt(mtd_to_nand(mtd), ofs); > > if (!ret) > > ret = res; > > }