linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, gabriele.mzt@gmail.com
Subject: Re: "Setting old previous keyboard state failed" error on Dell E7270
Date: Thu, 17 Nov 2016 13:19:16 +0100	[thread overview]
Message-ID: <201611171319.22434@pali> (raw)
In-Reply-To: <s5htwb6wdlm.wl-tiwai@suse.de>

[-- Attachment #1: Type: Text/Plain, Size: 1705 bytes --]

On Thursday 17 November 2016 12:27:33 Takashi Iwai wrote:
> Hi,
> 
> I noticed that a new machine I got yesterday, Dell Latitude E7270,
> always shows the error at boot time:
> 	dell_laptop: Setting old previous keyboard state failed
> 
>  From what I read from the code, it seems non-fatal.  But is it a way
> to "fix" it?
> 
> Or shouldn't we simply lower the printk level?
> 
> 
> thanks,
> 
> Takashi

Hi! Month ago I got private email about same problem reported by user. 
Looks like that Dell changed SMBIOS interface for keyboards and have not 
notified about it... User wrote that will do some research and write 
info to mailing list.

So in this case it is not non-fatal warning, but warning which telling 
us: "you are doing some operation which we do not know what is doing 
now...".

Masking this warning is not a good idea. There are only two good 
options:

1) Fix the code so it will work with that changed SMBIOS interface

2) Disable that code on problematic machines.

Anyway, keyboard backlight control in kernel is implemented from program 
smbios-keyboard-ctl provided and supported by Dell. I do not see any 
update to that program in upstream git repository.

http://github.com/dell/libsmbios/blob/master/src/bin/smbios-keyboard-ctl

So there are two options what could happen:

1) smbios-keyboard-ctl is working and kernel code not -- in this case 
bug in kernel, please provide debug logs from both smbios-keyboard-ctl 
and kernel and I could try to look at it

2) smbios-keyboard-ctl is not working too -- in this case please report 
bug to that libsmbios project and Dell needs to fix it

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2016-11-17 18:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17 11:27 "Setting old previous keyboard state failed" error on Dell E7270 Takashi Iwai
2016-11-17 12:19 ` Pali Rohár [this message]
2016-11-17 13:21   ` Takashi Iwai
2016-11-17 14:13     ` Takashi Iwai
2016-11-17 14:20       ` Pali Rohár
2016-11-17 14:41         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201611171319.22434@pali \
    --to=pali.rohar@gmail.com \
    --cc=gabriele.mzt@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).