linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* "Setting old previous keyboard state failed" error on Dell E7270
@ 2016-11-17 11:27 Takashi Iwai
  2016-11-17 12:19 ` Pali Rohár
  0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2016-11-17 11:27 UTC (permalink / raw)
  To: Pali Rohár; +Cc: Matthew Garrett, platform-driver-x86, linux-kernel

Hi,

I noticed that a new machine I got yesterday, Dell Latitude E7270,
always shows the error at boot time:
	dell_laptop: Setting old previous keyboard state failed

 From what I read from the code, it seems non-fatal.  But is it a way
to "fix" it?

Or shouldn't we simply lower the printk level?


thanks,

Takashi

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: "Setting old previous keyboard state failed" error on Dell E7270
  2016-11-17 11:27 "Setting old previous keyboard state failed" error on Dell E7270 Takashi Iwai
@ 2016-11-17 12:19 ` Pali Rohár
  2016-11-17 13:21   ` Takashi Iwai
  0 siblings, 1 reply; 6+ messages in thread
From: Pali Rohár @ 2016-11-17 12:19 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Matthew Garrett, platform-driver-x86, linux-kernel, gabriele.mzt

[-- Attachment #1: Type: Text/Plain, Size: 1705 bytes --]

On Thursday 17 November 2016 12:27:33 Takashi Iwai wrote:
> Hi,
> 
> I noticed that a new machine I got yesterday, Dell Latitude E7270,
> always shows the error at boot time:
> 	dell_laptop: Setting old previous keyboard state failed
> 
>  From what I read from the code, it seems non-fatal.  But is it a way
> to "fix" it?
> 
> Or shouldn't we simply lower the printk level?
> 
> 
> thanks,
> 
> Takashi

Hi! Month ago I got private email about same problem reported by user. 
Looks like that Dell changed SMBIOS interface for keyboards and have not 
notified about it... User wrote that will do some research and write 
info to mailing list.

So in this case it is not non-fatal warning, but warning which telling 
us: "you are doing some operation which we do not know what is doing 
now...".

Masking this warning is not a good idea. There are only two good 
options:

1) Fix the code so it will work with that changed SMBIOS interface

2) Disable that code on problematic machines.

Anyway, keyboard backlight control in kernel is implemented from program 
smbios-keyboard-ctl provided and supported by Dell. I do not see any 
update to that program in upstream git repository.

http://github.com/dell/libsmbios/blob/master/src/bin/smbios-keyboard-ctl

So there are two options what could happen:

1) smbios-keyboard-ctl is working and kernel code not -- in this case 
bug in kernel, please provide debug logs from both smbios-keyboard-ctl 
and kernel and I could try to look at it

2) smbios-keyboard-ctl is not working too -- in this case please report 
bug to that libsmbios project and Dell needs to fix it

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: "Setting old previous keyboard state failed" error on Dell E7270
  2016-11-17 12:19 ` Pali Rohár
@ 2016-11-17 13:21   ` Takashi Iwai
  2016-11-17 14:13     ` Takashi Iwai
  0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2016-11-17 13:21 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Matthew Garrett, platform-driver-x86, linux-kernel, gabriele.mzt

On Thu, 17 Nov 2016 13:19:16 +0100,
Pali Rohár wrote:
> 
> On Thursday 17 November 2016 12:27:33 Takashi Iwai wrote:
> > Hi,
> > 
> > I noticed that a new machine I got yesterday, Dell Latitude E7270,
> > always shows the error at boot time:
> > 	dell_laptop: Setting old previous keyboard state failed
> > 
> >  From what I read from the code, it seems non-fatal.  But is it a way
> > to "fix" it?
> > 
> > Or shouldn't we simply lower the printk level?
> > 
> > 
> > thanks,
> > 
> > Takashi
> 
> Hi! Month ago I got private email about same problem reported by user. 
> Looks like that Dell changed SMBIOS interface for keyboards and have not 
> notified about it... User wrote that will do some research and write 
> info to mailing list.
> 
> So in this case it is not non-fatal warning, but warning which telling 
> us: "you are doing some operation which we do not know what is doing 
> now...".
> 
> Masking this warning is not a good idea. There are only two good 
> options:
> 
> 1) Fix the code so it will work with that changed SMBIOS interface
> 
> 2) Disable that code on problematic machines.
> 
> Anyway, keyboard backlight control in kernel is implemented from program 
> smbios-keyboard-ctl provided and supported by Dell. I do not see any 
> update to that program in upstream git repository.
> 
> http://github.com/dell/libsmbios/blob/master/src/bin/smbios-keyboard-ctl

I'll give it a try shortly later.

> So there are two options what could happen:
> 
> 1) smbios-keyboard-ctl is working and kernel code not -- in this case 
> bug in kernel, please provide debug logs from both smbios-keyboard-ctl 
> and kernel and I could try to look at it
> 
> 2) smbios-keyboard-ctl is not working too -- in this case please report 
> bug to that libsmbios project and Dell needs to fix it

OK.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: "Setting old previous keyboard state failed" error on Dell E7270
  2016-11-17 13:21   ` Takashi Iwai
@ 2016-11-17 14:13     ` Takashi Iwai
  2016-11-17 14:20       ` Pali Rohár
  0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2016-11-17 14:13 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Matthew Garrett, platform-driver-x86, linux-kernel, gabriele.mzt

On Thu, 17 Nov 2016 14:21:23 +0100,
Takashi Iwai wrote:
> 
> On Thu, 17 Nov 2016 13:19:16 +0100,
> Pali Rohár wrote:
> > 
> > On Thursday 17 November 2016 12:27:33 Takashi Iwai wrote:
> > > Hi,
> > > 
> > > I noticed that a new machine I got yesterday, Dell Latitude E7270,
> > > always shows the error at boot time:
> > > 	dell_laptop: Setting old previous keyboard state failed
> > > 
> > >  From what I read from the code, it seems non-fatal.  But is it a way
> > > to "fix" it?
> > > 
> > > Or shouldn't we simply lower the printk level?
> > > 
> > > 
> > > thanks,
> > > 
> > > Takashi
> > 
> > Hi! Month ago I got private email about same problem reported by user. 
> > Looks like that Dell changed SMBIOS interface for keyboards and have not 
> > notified about it... User wrote that will do some research and write 
> > info to mailing list.
> > 
> > So in this case it is not non-fatal warning, but warning which telling 
> > us: "you are doing some operation which we do not know what is doing 
> > now...".
> > 
> > Masking this warning is not a good idea. There are only two good 
> > options:
> > 
> > 1) Fix the code so it will work with that changed SMBIOS interface
> > 
> > 2) Disable that code on problematic machines.
> > 
> > Anyway, keyboard backlight control in kernel is implemented from program 
> > smbios-keyboard-ctl provided and supported by Dell. I do not see any 
> > update to that program in upstream git repository.
> > 
> > http://github.com/dell/libsmbios/blob/master/src/bin/smbios-keyboard-ctl
> 
> I'll give it a try shortly later.

Tried the latest git version now, and it didn't work.
At setting the mode via smbios-keyboard-ctl --set-mode, it always
return an error like:

  Set Trigger Failed. Failed to write config
	 Error Return Code : cbRES1: 0x-2 cbRES2: 0xA000000 cbRES3: 0x0 

The error code is same no matter which mode is to set.

> > So there are two options what could happen:
> > 
> > 1) smbios-keyboard-ctl is working and kernel code not -- in this case 
> > bug in kernel, please provide debug logs from both smbios-keyboard-ctl 
> > and kernel and I could try to look at it
> > 
> > 2) smbios-keyboard-ctl is not working too -- in this case please report 
> > bug to that libsmbios project and Dell needs to fix it

So the latter case.
I'm going to ping smbios maintainer.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: "Setting old previous keyboard state failed" error on Dell E7270
  2016-11-17 14:13     ` Takashi Iwai
@ 2016-11-17 14:20       ` Pali Rohár
  2016-11-17 14:41         ` Takashi Iwai
  0 siblings, 1 reply; 6+ messages in thread
From: Pali Rohár @ 2016-11-17 14:20 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Matthew Garrett, platform-driver-x86, linux-kernel, gabriele.mzt

[-- Attachment #1: Type: Text/Plain, Size: 1260 bytes --]

On Thursday 17 November 2016 15:13:59 Takashi Iwai wrote:
> On Thu, 17 Nov 2016 14:21:23 +0100,
> 
> Takashi Iwai wrote:
> > On Thu, 17 Nov 2016 13:19:16 +0100,
> > 
> > Pali Rohár wrote:
> > > Anyway, keyboard backlight control in kernel is implemented from
> > > program smbios-keyboard-ctl provided and supported by Dell. I do
> > > not see any update to that program in upstream git repository.
> > > 
> > > http://github.com/dell/libsmbios/blob/master/src/bin/smbios-keybo
> > > ard-ctl
> > 
> > I'll give it a try shortly later.
> 
> Tried the latest git version now, and it didn't work.
> At setting the mode via smbios-keyboard-ctl --set-mode, it always
> return an error like:
> 
>   Set Trigger Failed. Failed to write config
> 	 Error Return Code : cbRES1: 0x-2 cbRES2: 0xA000000 cbRES3: 0x0
> 
> The error code is same no matter which mode is to set.
...
> > > 2) smbios-keyboard-ctl is not working too -- in this case please
> > > report bug to that libsmbios project and Dell needs to fix it
> 
> So the latter case.
> I'm going to ping smbios maintainer.

Ok. Ideally also open public bug report on github tracker so other 
people can find some information about it...

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: "Setting old previous keyboard state failed" error on Dell E7270
  2016-11-17 14:20       ` Pali Rohár
@ 2016-11-17 14:41         ` Takashi Iwai
  0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2016-11-17 14:41 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Matthew Garrett, platform-driver-x86, linux-kernel, gabriele.mzt

On Thu, 17 Nov 2016 15:20:25 +0100,
Pali Rohár wrote:
> 
> On Thursday 17 November 2016 15:13:59 Takashi Iwai wrote:
> > On Thu, 17 Nov 2016 14:21:23 +0100,
> > 
> > Takashi Iwai wrote:
> > > On Thu, 17 Nov 2016 13:19:16 +0100,
> > > 
> > > Pali Rohár wrote:
> > > > Anyway, keyboard backlight control in kernel is implemented from
> > > > program smbios-keyboard-ctl provided and supported by Dell. I do
> > > > not see any update to that program in upstream git repository.
> > > > 
> > > > http://github.com/dell/libsmbios/blob/master/src/bin/smbios-keybo
> > > > ard-ctl
> > > 
> > > I'll give it a try shortly later.
> > 
> > Tried the latest git version now, and it didn't work.
> > At setting the mode via smbios-keyboard-ctl --set-mode, it always
> > return an error like:
> > 
> >   Set Trigger Failed. Failed to write config
> > 	 Error Return Code : cbRES1: 0x-2 cbRES2: 0xA000000 cbRES3: 0x0
> > 
> > The error code is same no matter which mode is to set.
> ...
> > > > 2) smbios-keyboard-ctl is not working too -- in this case please
> > > > report bug to that libsmbios project and Dell needs to fix it
> > 
> > So the latter case.
> > I'm going to ping smbios maintainer.
> 
> Ok. Ideally also open public bug report on github tracker so other 
> people can find some information about it...

FYI, I found one there and now put my comment:
   https://github.com/dell/libsmbios/issues/3


Takashi

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-11-17 18:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-17 11:27 "Setting old previous keyboard state failed" error on Dell E7270 Takashi Iwai
2016-11-17 12:19 ` Pali Rohár
2016-11-17 13:21   ` Takashi Iwai
2016-11-17 14:13     ` Takashi Iwai
2016-11-17 14:20       ` Pali Rohár
2016-11-17 14:41         ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).