linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	David Sterba <dsterba@suse.cz>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>
Subject: Re: linux-next: manual merge of the block tree with the btrfs-kdave tree
Date: Thu, 17 Nov 2016 14:23:01 +0100	[thread overview]
Message-ID: <20161117132301.GA26525@lst.de> (raw)
In-Reply-To: <5d5a631b-e18e-aa2b-67bb-e2df6d8bef15@kernel.dk>

On Wed, Nov 16, 2016 at 07:49:29PM -0700, Jens Axboe wrote:
> doesn't look correct, if bio_readpage_error() is called from the 
> ->bi_end_io() handler. bi_size is generally zeroed at that time.

At least some of these bios are magic btrfs-internal ones that never
reach the block layer.  But I don't think all are, and both the new
code and one of the old cases are broken.  David, can you drop
this one patch for now, and I'll restart the discussion on the
failfast behavior on the btrfs list?

  reply	other threads:[~2016-11-17 17:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17  2:01 linux-next: manual merge of the block tree with the btrfs-kdave tree Stephen Rothwell
2016-11-17  2:49 ` Jens Axboe
2016-11-17 13:23   ` Christoph Hellwig [this message]
2016-11-18 17:47     ` David Sterba
  -- strict thread matches above, loose matches on Subject: below --
2019-02-18  1:07 Stephen Rothwell
2017-06-21  3:13 Stephen Rothwell
2017-06-20  1:37 Stephen Rothwell
2017-06-13  3:50 Stephen Rothwell
2017-06-13  3:34 Stephen Rothwell
2017-06-13  3:27 Stephen Rothwell
2017-06-13  3:15 Stephen Rothwell
2016-07-08  4:03 Stephen Rothwell
2016-07-08  4:00 Stephen Rothwell
2016-07-08  3:49 Stephen Rothwell
2016-07-08  3:31 Stephen Rothwell
2016-07-08  3:27 Stephen Rothwell
2016-07-08  3:26 Stephen Rothwell
2016-06-24  2:34 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161117132301.GA26525@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=dsterba@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).