From: Johan Hovold <johan@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH] pwm: fix device reference leak
Date: Thu, 17 Nov 2016 15:31:22 +0100 [thread overview]
Message-ID: <20161117143122.GA10490@localhost> (raw)
In-Reply-To: <1477997199-29305-1-git-send-email-johan@kernel.org>
On Tue, Nov 01, 2016 at 11:46:39AM +0100, Johan Hovold wrote:
> Make sure to drop the reference to the parent device taken by
> class_find_device() after "unexporting" any children when deregistering
> a pwm chip.
>
> Fixes: 0733424c9ba9 ("pwm: Unexport children before chip removal")
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/pwm/sysfs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c
> index 0296d8178ae2..a813239300c3 100644
> --- a/drivers/pwm/sysfs.c
> +++ b/drivers/pwm/sysfs.c
> @@ -425,6 +425,8 @@ void pwmchip_sysfs_unexport_children(struct pwm_chip *chip)
> if (test_bit(PWMF_EXPORTED, &pwm->flags))
> pwm_unexport_child(parent, pwm);
> }
> +
> + put_device(parent);
> }
>
> static int __init pwm_sysfs_init(void)
Thought I'd send a gentle reminder about this one. Is it still in your
queue, Thierry?
Thanks,
Johan
next prev parent reply other threads:[~2016-11-17 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 10:46 [PATCH] pwm: fix device reference leak Johan Hovold
2016-11-17 14:31 ` Johan Hovold [this message]
2016-11-29 15:47 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117143122.GA10490@localhost \
--to=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).