From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932724AbcKQObi (ORCPT ); Thu, 17 Nov 2016 09:31:38 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34121 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754194AbcKQOb0 (ORCPT ); Thu, 17 Nov 2016 09:31:26 -0500 Date: Thu, 17 Nov 2016 15:31:22 +0100 From: Johan Hovold To: Thierry Reding Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: Re: [PATCH] pwm: fix device reference leak Message-ID: <20161117143122.GA10490@localhost> References: <1477997199-29305-1-git-send-email-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477997199-29305-1-git-send-email-johan@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 01, 2016 at 11:46:39AM +0100, Johan Hovold wrote: > Make sure to drop the reference to the parent device taken by > class_find_device() after "unexporting" any children when deregistering > a pwm chip. > > Fixes: 0733424c9ba9 ("pwm: Unexport children before chip removal") > Signed-off-by: Johan Hovold > --- > drivers/pwm/sysfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c > index 0296d8178ae2..a813239300c3 100644 > --- a/drivers/pwm/sysfs.c > +++ b/drivers/pwm/sysfs.c > @@ -425,6 +425,8 @@ void pwmchip_sysfs_unexport_children(struct pwm_chip *chip) > if (test_bit(PWMF_EXPORTED, &pwm->flags)) > pwm_unexport_child(parent, pwm); > } > + > + put_device(parent); > } > > static int __init pwm_sysfs_init(void) Thought I'd send a gentle reminder about this one. Is it still in your queue, Thierry? Thanks, Johan