* [PATCH] pwm: fix device reference leak
@ 2016-11-01 10:46 Johan Hovold
2016-11-17 14:31 ` Johan Hovold
2016-11-29 15:47 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Johan Hovold @ 2016-11-01 10:46 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-pwm, linux-kernel, Johan Hovold
Make sure to drop the reference to the parent device taken by
class_find_device() after "unexporting" any children when deregistering
a pwm chip.
Fixes: 0733424c9ba9 ("pwm: Unexport children before chip removal")
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/pwm/sysfs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c
index 0296d8178ae2..a813239300c3 100644
--- a/drivers/pwm/sysfs.c
+++ b/drivers/pwm/sysfs.c
@@ -425,6 +425,8 @@ void pwmchip_sysfs_unexport_children(struct pwm_chip *chip)
if (test_bit(PWMF_EXPORTED, &pwm->flags))
pwm_unexport_child(parent, pwm);
}
+
+ put_device(parent);
}
static int __init pwm_sysfs_init(void)
--
2.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pwm: fix device reference leak
2016-11-01 10:46 [PATCH] pwm: fix device reference leak Johan Hovold
@ 2016-11-17 14:31 ` Johan Hovold
2016-11-29 15:47 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2016-11-17 14:31 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-pwm, linux-kernel, Johan Hovold
On Tue, Nov 01, 2016 at 11:46:39AM +0100, Johan Hovold wrote:
> Make sure to drop the reference to the parent device taken by
> class_find_device() after "unexporting" any children when deregistering
> a pwm chip.
>
> Fixes: 0733424c9ba9 ("pwm: Unexport children before chip removal")
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/pwm/sysfs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c
> index 0296d8178ae2..a813239300c3 100644
> --- a/drivers/pwm/sysfs.c
> +++ b/drivers/pwm/sysfs.c
> @@ -425,6 +425,8 @@ void pwmchip_sysfs_unexport_children(struct pwm_chip *chip)
> if (test_bit(PWMF_EXPORTED, &pwm->flags))
> pwm_unexport_child(parent, pwm);
> }
> +
> + put_device(parent);
> }
>
> static int __init pwm_sysfs_init(void)
Thought I'd send a gentle reminder about this one. Is it still in your
queue, Thierry?
Thanks,
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pwm: fix device reference leak
2016-11-01 10:46 [PATCH] pwm: fix device reference leak Johan Hovold
2016-11-17 14:31 ` Johan Hovold
@ 2016-11-29 15:47 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2016-11-29 15:47 UTC (permalink / raw)
To: Johan Hovold; +Cc: linux-pwm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
On Tue, Nov 01, 2016 at 11:46:39AM +0100, Johan Hovold wrote:
> Make sure to drop the reference to the parent device taken by
> class_find_device() after "unexporting" any children when deregistering
> a pwm chip.
>
> Fixes: 0733424c9ba9 ("pwm: Unexport children before chip removal")
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/pwm/sysfs.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-29 15:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-01 10:46 [PATCH] pwm: fix device reference leak Johan Hovold
2016-11-17 14:31 ` Johan Hovold
2016-11-29 15:47 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).