From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "T.Zhou" <t1zhou@163.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/rt: Change rt_nr_running to rt_queued in the comment
Date: Fri, 18 Nov 2016 09:53:07 -0500 [thread overview]
Message-ID: <20161118095307.799fbac8@gandalf.local.home> (raw)
In-Reply-To: <20161118063904.GA5376@geo>
Peter,
Can you pull this patch into your queue?
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
On Fri, 18 Nov 2016 14:39:04 +0800
"T.Zhou" <t1zhou@163.com> wrote:
> The code actually checks rt_queued not rt_nr_running
> in pick_next_task_rt(), so change the corresponding
> comment.
>
> Signed-off-by: T.Zhou <t1zhou@163.com>
> ---
> kernel/sched/rt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 2516b8d..9b4a5c5 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -1550,7 +1550,7 @@ pick_next_task_rt(struct rq *rq, struct task_struct *prev, struct pin_cookie coo
>
> /*
> * We may dequeue prev's rt_rq in put_prev_task().
> - * So, we update time before rt_nr_running check.
> + * So, we update time before rt_queued check.
> */
> if (prev->sched_class == &rt_sched_class)
> update_curr_rt(rq);
next prev parent reply other threads:[~2016-11-18 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 6:39 [PATCH] sched/rt: Change rt_nr_running to rt_queued in the comment T.Zhou
2016-11-18 14:53 ` Steven Rostedt [this message]
2016-11-18 15:00 ` Peter Zijlstra
2016-11-18 16:46 ` Steven Rostedt
2016-11-19 3:10 ` T.Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118095307.799fbac8@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=t1zhou@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).