From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "pankaj.dubey" <pankaj.dubey@samsung.com>,
linux-arm-kernel@lists.infradead.org,
Andrew Lunn <andrew@lunn.ch>, Heiko Stuebner <heiko@sntech.de>,
geert+renesas@glider.be, Linus Walleij <linus.walleij@linaro.org>,
Liviu Dudau <liviu.dudau@arm.com>,
Patrice Chotard <patrice.chotard@st.com>,
krzk@kernel.org, Jisheng Zhang <jszhang@marvell.com>,
vireshk@kernel.org, magnus.damm@gmail.com,
Michal Simek <michal.simek@xilinx.com>,
Wei Xu <xuwei5@hisilicon.com>,
thomas.ab@samsung.com, "cpgs ." <cpgs@samsung.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ray Jui <rjui@broadcom.com>,
horms@verge.net.au, Dinh Nguyen <dinguyen@opensource.altera.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-kernel@vger.kernel.org, Jun Nie <jun.nie@linaro.org>,
shiraz.linux.kernel@gmail.com
Subject: Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU
Date: Fri, 18 Nov 2016 12:48:07 +0000 [thread overview]
Message-ID: <20161118124805.GJ1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <9481995.AMBiYg893F@wuerfel>
On Fri, Nov 18, 2016 at 01:14:35PM +0100, Arnd Bergmann wrote:
> @@ -41,6 +43,9 @@ void scu_enable(void __iomem *scu_base)
> {
> u32 scu_ctrl;
>
> + if (scu_base)
> + scu_base = scu_base_addr;
> +
This looks to me like nonsense.
> #ifdef CONFIG_ARM_ERRATA_764369
> /* Cortex-A9 only */
> if ((read_cpuid_id() & 0xff0ffff0) == 0x410fc090) {
> @@ -85,6 +90,9 @@ int scu_power_mode(void __iomem *scu_base, unsigned int mode)
> unsigned int val;
> int cpu = MPIDR_AFFINITY_LEVEL(cpu_logical_map(smp_processor_id()), 0);
>
> + if (scu_base)
> + scu_base = scu_base_addr;
> +
Ditto.
Rather than doing this, I'd much prefer to always store the SCU base in
the SCU code, and remove the "void __iomem *scu_base" argment from all
these functions.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-11-18 12:49 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 5:01 [PATCH 00/16] Provide support of generic function for SCU enable Pankaj Dubey
2016-11-14 5:01 ` [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU Pankaj Dubey
2016-11-14 6:12 ` Jisheng Zhang
2016-11-14 6:54 ` Jisheng Zhang
2016-11-14 8:23 ` pankaj.dubey
2016-11-14 8:47 ` Jisheng Zhang
2016-11-14 8:40 ` pankaj.dubey
2016-11-14 12:03 ` Arnd Bergmann
2016-11-14 13:50 ` Russell King - ARM Linux
2016-11-14 14:37 ` Arnd Bergmann
2016-11-14 14:51 ` Russell King - ARM Linux
2016-11-17 4:20 ` pankaj.dubey
2016-11-17 17:03 ` Arnd Bergmann
2016-11-18 3:24 ` pankaj.dubey
2016-11-18 12:14 ` Arnd Bergmann
2016-11-18 12:48 ` Russell King - ARM Linux [this message]
2016-11-18 13:32 ` Arnd Bergmann
2016-12-08 15:18 ` Pankaj Dubey
2016-11-14 13:48 ` Russell King - ARM Linux
2016-11-17 2:22 ` pankaj.dubey
2016-11-14 5:01 ` [PATCH 02/16] ARM: EXYNOS: use generic API " Pankaj Dubey
2016-11-15 18:59 ` Krzysztof Kozlowski
2016-11-17 2:15 ` pankaj.dubey
2016-11-14 5:01 ` [PATCH 03/16] ARM: berlin: use generic API for enabling SCU Pankaj Dubey
2016-11-14 8:51 ` Jisheng Zhang
2016-11-14 16:20 ` Pankaj Dubey
2016-11-14 5:01 ` [PATCH 04/16] ARM: realview: " Pankaj Dubey
2016-11-14 11:56 ` Arnd Bergmann
2016-11-14 12:06 ` pankaj.dubey
2016-11-14 14:28 ` Arnd Bergmann
2016-11-14 13:19 ` Pankaj Dubey
2016-11-14 5:02 ` [PATCH 05/16] ARM: socfpga: " Pankaj Dubey
2016-11-14 5:02 ` [PATCH 06/16] ARM: STi: " Pankaj Dubey
2016-11-14 5:02 ` [PATCH 07/16] ARM: ux500: " Pankaj Dubey
2016-11-14 5:02 ` [PATCH 08/16] ARM: vexpress: " Pankaj Dubey
2016-11-16 14:34 ` Sudeep Holla
2016-11-17 2:12 ` pankaj.dubey
2016-11-14 5:02 ` [PATCH 09/16] ARM: BCM: " Pankaj Dubey
2016-11-14 6:10 ` Florian Fainelli
2016-11-14 5:02 ` [PATCH 10/16] ARM: tegra: " Pankaj Dubey
2016-11-14 5:02 ` [PATCH 11/16] ARM: rockchip: " Pankaj Dubey
2016-11-14 5:02 ` [PATCH 12/16] ARM: imx: " Pankaj Dubey
2016-11-14 14:26 ` Shawn Guo
2016-11-17 4:29 ` pankaj.dubey
2016-11-14 5:02 ` [PATCH 13/16] ARM: zynq: " Pankaj Dubey
2016-11-14 5:02 ` [PATCH 14/16] ARM: hisi: " Pankaj Dubey
2016-11-14 5:02 ` [PATCH 15/16] ARM: mvebu: " Pankaj Dubey
2016-11-14 5:02 ` [PATCH 16/16] ARM: zx: " Pankaj Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118124805.GJ1041@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=cpgs@samsung.com \
--cc=dinguyen@opensource.altera.com \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=horms@verge.net.au \
--cc=jszhang@marvell.com \
--cc=jun.nie@linaro.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=magnus.damm@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=pankaj.dubey@samsung.com \
--cc=patrice.chotard@st.com \
--cc=rjui@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=shiraz.linux.kernel@gmail.com \
--cc=swarren@wwwdotorg.org \
--cc=thomas.ab@samsung.com \
--cc=vireshk@kernel.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).