* [PATCHv2]: staging: Greybus: Remove unnecessary braces for single statement block
@ 2016-11-18 13:34 Rahul Krishnan
2016-11-18 14:15 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Rahul Krishnan @ 2016-11-18 13:34 UTC (permalink / raw)
To: rmfrfs; +Cc: elder, johan, gregkh, devel, linux-kernel
This patch fixes the following checkpath.pl warning
WARNING: braces {} are not necessary for single statement blocks
Fixed indentation error, noted by Dan Carpenter
Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
---
drivers/staging/greybus/sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
index f60b458..66b37ea 100644
--- a/drivers/staging/greybus/sdio.c
+++ b/drivers/staging/greybus/sdio.c
@@ -192,7 +192,7 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
}
if (event & GB_SDIO_WP)
- host->read_only = true;
+ host->read_only = true;
if (state_changed) {
dev_info(mmc_dev(host->mmc), "card %s now event\n",
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv2]: staging: Greybus: Remove unnecessary braces for single statement block
2016-11-18 13:34 [PATCHv2]: staging: Greybus: Remove unnecessary braces for single statement block Rahul Krishnan
@ 2016-11-18 14:15 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2016-11-18 14:15 UTC (permalink / raw)
To: Rahul Krishnan; +Cc: rmfrfs, elder, johan, gregkh, devel, linux-kernel
On Fri, Nov 18, 2016 at 07:04:20PM +0530, Rahul Krishnan wrote:
> This patch fixes the following checkpath.pl warning
> WARNING: braces {} are not necessary for single statement blocks
>
> Fixed indentation error, noted by Dan Carpenter
>
> Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
> ---
> drivers/staging/greybus/sdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
> index f60b458..66b37ea 100644
> --- a/drivers/staging/greybus/sdio.c
> +++ b/drivers/staging/greybus/sdio.c
> @@ -192,7 +192,7 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
> }
>
> if (event & GB_SDIO_WP)
> - host->read_only = true;
> + host->read_only = true;
You need to redo your original patch. This one instead looks like a
follow-up to your first revision (which actually removed the braces).
>
> if (state_changed) {
> dev_info(mmc_dev(host->mmc), "card %s now event\n",
Thanks,
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-18 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-18 13:34 [PATCHv2]: staging: Greybus: Remove unnecessary braces for single statement block Rahul Krishnan
2016-11-18 14:15 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).