From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754235AbcKRRF5 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 18 Nov 2016 12:05:57 -0500
Received: from mail-pg0-f47.google.com ([74.125.83.47]:35557 "EHLO
        mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753882AbcKRRFy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 18 Nov 2016 12:05:54 -0500
Date: Fri, 18 Nov 2016 09:05:49 -0800
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ohad Ben-Cohen <ohad@wizery.com>, Vinod Koul <vinod.koul@intel.com>,
        Peter Griffin <peter.griffin@linaro.org>,
        Lee Jones <lee.jones@linaro.org>, linux-remoteproc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remoteproc: wcnss-pil: add QCOM_SMD dependency
Message-ID: <20161118170549.GB2769@tuxbot>
References: <20161118161528.775709-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161118161528.775709-1-arnd@arndb.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri 18 Nov 08:15 PST 2016, Arnd Bergmann wrote:

> When qcom_smd is a loadable module and adsp-pil is built-in,
> we get a link error:
> 
> drivers/remoteproc/qcom_wcnss_pil.o: In function `wcnss_smd_remove':
> qcom_wcnss_iris.c:(.text.wcnss_smd_remove+0x10): undefined reference to `qcom_smd_unregister_edge'
> drivers/remoteproc/qcom_wcnss_pil.o: In function `wcnss_smd_probe':
> qcom_wcnss_iris.c:(.text.wcnss_smd_probe+0x12): undefined reference to `qcom_smd_register_edge'
> 
> This adds a Kconfig dependency to avoid this. We can still allow
> build-testing with SMD disabled.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied

Thanks,
Bjorn

> ---
>  drivers/remoteproc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 5a0019ce7555..677b3fede83d 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -106,6 +106,7 @@ config QCOM_Q6V5_PIL
>  config QCOM_WCNSS_PIL
>  	tristate "Qualcomm WCNSS Peripheral Image Loader"
>  	depends on OF && ARCH_QCOM
> +	depends on QCOM_SMD || (COMPILE_TEST && QCOM_SMD = n)
>  	depends on QCOM_SMEM
>  	depends on REMOTEPROC
>  	select QCOM_MDT_LOADER
> -- 
> 2.9.0
>