Re: [PATCH v6 0/2] usb: musb: da8xx: Fix few issues

Bin Liu
2016-11-18T18:12:52Z

On Tue, Nov 15, 2016 at 06:42:45PM +0100, Alexandre Bailon wrote:
> This series require the following patch to build:
> [PATCH 1/6] usb: musb: Fix broken use of static variable for multiple instances
>
> Currently, the USB OTG of the da8xx doesn't work.
> This series intend to fix them.
>
> Change in v2:
> * Fix the error path da8xx_musb_init()
>
> Changes in v3:
> * Remove the host workaround that was not working on every platform
> * Add a property to the devicetree node of phy to force the phy in a specific
> mode (host or device).
> * Only use dr_mode to configure the controller mode and let the phy in OTG mode.
> The main goal of this change is to prevent the phy to be set in host or
> device mode because these modes have some issues.
>
> Changes in v4:
> * Enable VBUS sense and session end comparator during probe of phy.
> * Add a quirk flag to skip the phy set mode made during the init of musb.
> In that way, we can still can configure the phy mode by using mode file in
> sysfs and configure the controller mode by using dr_mode or platform_data.
> * Init the phy in otg mode in da8xx glue driver.
>
> Changes in v5:
> * Add the init argument to musb_platform_set_mode() and set_mode() callback.
> * Remove the quirk
> * Configure the DA8xx phy in OTG mode if da8xx_musb_set_mode() is called from
> init.
>
> Changes in v6:
> * Remove the patch that was adding a new parametter to musb_platform_set_mode().
> Instead, use the variable is_initialized.
> * The patch fixing the phy has been merged to phy-next, so I removed it from
> this series.
>
> Alexandre Bailon (2):
> usb: musb: da8xx: Call earlier clk_prepare_enable()
> usb: musb: da8xx: Set phy in OTG mode by default

Applied. Thanks.
-Bin.

>
> drivers/usb/musb/da8xx.c | 24 +++++++++++++++---------
> 1 file changed, 15 insertions(+), 9 deletions(-)
>
> --
> 2.7.3
>