From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753510AbcKRXls (ORCPT ); Fri, 18 Nov 2016 18:41:48 -0500 Received: from mail.kernel.org ([198.145.29.136]:57450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752223AbcKRXlq (ORCPT ); Fri, 18 Nov 2016 18:41:46 -0500 Date: Fri, 18 Nov 2016 20:40:22 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Jiri Olsa , Namhyung Kim , Andrew Morton Subject: Re: [PATCH 2/2] tools lib traceevent: Use USECS_PER_SEC instead of hardcoded number Message-ID: <20161118234022.GK11932@kernel.org> References: <20161118225359.378120451@goodmis.org> <20161118225457.987025355@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161118225457.987025355@goodmis.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Nov 18, 2016 at 05:54:01PM -0500, Steven Rostedt escreveu: > From: "Steven Rostedt (Red Hat)" > > Instead of using 1000000, define a USECS_PER_SEC macro and use that instead. We already have it in tools/include/linux/time64.h :-) - Arnaldo > Link: http://lkml.kernel.org/r/20160209204237.006667394@goodmis.org > > Signed-off-by: Steven Rostedt > --- > tools/lib/traceevent/event-parse.c | 4 ++-- > tools/lib/traceevent/event-parse.h | 2 ++ > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c > index d6f3cc0a29b0..2b85b339f6b9 100644 > --- a/tools/lib/traceevent/event-parse.c > +++ b/tools/lib/traceevent/event-parse.c > @@ -5465,8 +5465,8 @@ void pevent_print_event_time(struct pevent *pevent, struct trace_seq *s, > } else { > usecs = (nsecs + 500) / NSECS_PER_USEC; > /* To avoid usecs larger than 1 sec */ > - if (usecs >= 1000000) { > - usecs -= 1000000; > + if (usecs >= USECS_PER_SEC) { > + usecs -= USECS_PER_SEC; > secs++; > } > p = 6; > diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h > index 41b3d2238ed3..b09dd49465b0 100644 > --- a/tools/lib/traceevent/event-parse.h > +++ b/tools/lib/traceevent/event-parse.h > @@ -175,6 +175,8 @@ struct pevent_plugin_option { > #define NSECS_PER_SEC 1000000000ULL > #define NSECS_PER_USEC 1000ULL > > +#define USECS_PER_SEC 1000000ULL > + > enum format_flags { > FIELD_IS_ARRAY = 1, > FIELD_IS_POINTER = 2, > -- > 2.10.2 >