From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: "Usyskin, Alexander" <alexander.usyskin@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [char-misc-next 4/4] mei: bus: enable non-blocking RX
Date: Sat, 19 Nov 2016 09:49:04 +0100 [thread overview]
Message-ID: <20161119084904.GA22816@kroah.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B5432C477@hasmsx108.ger.corp.intel.com>
On Fri, Nov 18, 2016 at 07:30:25PM +0000, Winkler, Tomas wrote:
>
> >
> > On Thu, Nov 17, 2016 at 04:22:24PM +0000, Winkler, Tomas wrote:
> > > > Just make a new function mei_cldev_recv_async() and then call a
> > > > local, static function, that does the work with the correct flag
> > > > set. That way the developer always knows exactly what is going on.
> > >
> > > We can do a wrapper, but _async() is not proper here maybe
> > > _nonblock(),
> >
> > Yes, I just guessed at the name :)
>
> Understood, any how I believe that we should keep patch as is, there is no one
> API _nonblock() function in the whole kernel unlike _async(),
> nonblock is always passed in as a flag or Boolean.
And I'll still argue that this is a horrible api and you can do better.
No need to duplicate the errors of our childhood :)
thanks,
greg k-h
next prev parent reply other threads:[~2016-11-19 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 20:51 [char-misc-next 0/4] mei: bus: rx fixes Tomas Winkler
2016-11-16 20:51 ` [char-misc-next 1/4] mei: introduce host client uninitialized state Tomas Winkler
2016-11-16 20:51 ` [char-misc-next 2/4] mei: bus: make a client pointer always available Tomas Winkler
2016-11-16 20:51 ` [char-misc-next 3/4] mei: bus: split RX and async notification callbacks Tomas Winkler
2016-11-16 20:51 ` [char-misc-next 4/4] mei: bus: enable non-blocking RX Tomas Winkler
2016-11-17 15:37 ` Greg Kroah-Hartman
2016-11-17 16:22 ` Winkler, Tomas
2016-11-17 16:27 ` Greg Kroah-Hartman
2016-11-18 19:30 ` Winkler, Tomas
2016-11-19 8:49 ` Greg Kroah-Hartman [this message]
2016-11-19 10:43 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161119084904.GA22816@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.usyskin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox