From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755020AbcKUPyu (ORCPT ); Mon, 21 Nov 2016 10:54:50 -0500 Received: from smtprelay0024.hostedemail.com ([216.40.44.24]:33928 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753787AbcKUPys (ORCPT ); Mon, 21 Nov 2016 10:54:48 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1434:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2915:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3871:3873:4321:4605:5007:6120:6261:7875:8660:10004:10400:10848:10967:11026:11232:11658:11914:12043:12296:12438:12555:12740:12760:12986:13148:13230:13439:14181:14659:14721:21080:21212:21451:30029:30054:30064:30069:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: band14_63ad571687724 X-Filterd-Recvd-Size: 3382 Date: Mon, 21 Nov 2016 10:54:43 -0500 From: Steven Rostedt To: alexander.levin@verizon.com Cc: "dvyukov@google.com" , "tglx@linutronix.de" , "scientist@fb.com" , "glider@google.com" , "andreyknvl@google.com" , "arnd@arndb.de" , "mathieu.desnoyers@efficios.com" , "daniel.vetter@ffwll.ch" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC 2/3] abi_spec: hooks into syscall to allow pre and post checking Message-ID: <20161121105443.249ddff8@gandalf.local.home> In-Reply-To: <1479317803-17220-3-git-send-email-alexander.levin@verizon.com> References: <1479317803-17220-1-git-send-email-alexander.levin@verizon.com> <1479317803-17220-3-git-send-email-alexander.levin@verizon.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Nov 2016 17:37:01 +0000 alexander.levin@verizon.com wrote: > This is a simple way to be able to verify syscall parameters before the > call to the actual syscall, and also verify the return value after the > call. > > Signed-off-by: Sasha Levin > --- > include/linux/syscalls.h | 7 ++++++- > kernel/Makefile | 2 ++ > kernel/abi_spec.c | 15 +++++++++++++++ > 3 files changed, 23 insertions(+), 1 deletion(-) > create mode 100644 kernel/abi_spec.c > > diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h > index 91a740f..6aa3228 100644 > --- a/include/linux/syscalls.h > +++ b/include/linux/syscalls.h > @@ -79,6 +79,7 @@ union bpf_attr; > #include > #include > #include > +#include > > /* > * __MAP - apply a macro to syscall arguments > @@ -192,13 +193,17 @@ extern struct trace_event_functions exit_syscall_print_funcs; > > #define __PROTECT(...) asmlinkage_protect(__VA_ARGS__) > #define __SYSCALL_DEFINEx(x, name, ...) \ > + extern const struct syscall_spec syscall_spec##name; \ > asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ > __attribute__((alias(__stringify(SyS##name)))); \ > static inline long SYSC##name(__MAP(x,__SC_DECL,__VA_ARGS__)); \ > asmlinkage long SyS##name(__MAP(x,__SC_LONG,__VA_ARGS__)); \ > asmlinkage long SyS##name(__MAP(x,__SC_LONG,__VA_ARGS__)) \ > { \ > - long ret = SYSC##name(__MAP(x,__SC_CAST,__VA_ARGS__)); \ > + long ret; \ > + abispec_check_pre(&syscall_spec##name, __MAP(x,__SC_CAST,__VA_ARGS__)); \ > + ret = SYSC##name(__MAP(x,__SC_CAST,__VA_ARGS__)); \ > + abispec_check_post(&syscall_spec##name, ret, __MAP(x,__SC_CAST,__VA_ARGS__)); \ Do you want this for DEFINE0() too? Or does this not care about system calls with no arguments? -- Steve > __MAP(x,__SC_TEST,__VA_ARGS__); \ > __PROTECT(x, ret,__MAP(x,__SC_ARGS,__VA_ARGS__)); \ > return ret; \