From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754163AbcKULWe (ORCPT ); Mon, 21 Nov 2016 06:22:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41502 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753668AbcKULWd (ORCPT ); Mon, 21 Nov 2016 06:22:33 -0500 Date: Mon, 21 Nov 2016 12:22:29 +0100 From: Jiri Olsa To: Peter Zijlstra Cc: Steven Rostedt , "Paul E. McKenney" , linux-kernel@vger.kernel.org, Ingo Molnar , Josh Triplett , Andi Kleen , Jan Stancek Subject: Re: [BUG] msr-trace.h:42 suspicious rcu_dereference_check() usage! Message-ID: <20161121112229.GA12974@krava> References: <20161121005343.GB1891@krava> <20161121092850.GF3102@twins.programming.kicks-ass.net> <20161121093424.GA9814@krava> <20161121094227.GG3102@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161121094227.GG3102@twins.programming.kicks-ass.net> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 21 Nov 2016 11:22:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 21, 2016 at 10:42:27AM +0100, Peter Zijlstra wrote: > On Mon, Nov 21, 2016 at 10:34:25AM +0100, Jiri Olsa wrote: > > On Mon, Nov 21, 2016 at 10:28:50AM +0100, Peter Zijlstra wrote: > > > > I think I prefer something like the below, that only annotates the one > > > RDMSR in question, instead of all of them. > > > > I was wondering about that, but haven't found RCU_NONIDLE > > Its in rcupdate.h ;-) it was too late in the morning.. ;-) I'm assuming you'll queue this patch.. ? thanks, jirka