From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754149AbcKUO6u (ORCPT ); Mon, 21 Nov 2016 09:58:50 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:35954 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754029AbcKUO6s (ORCPT ); Mon, 21 Nov 2016 09:58:48 -0500 Date: Mon, 21 Nov 2016 15:58:45 +0100 From: Johan Hovold To: Geert Uytterhoeven Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: cp210x: Use tcflag_t to fix incompatible pointer type Message-ID: <20161121145845.GA27409@localhost> References: <1479730771-17759-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479730771-17759-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 21, 2016 at 01:19:31PM +0100, Geert Uytterhoeven wrote: > On sparc32, tcflag_t is unsigned long, unlike all other architectures: > > drivers/usb/serial/cp210x.c: In function 'cp210x_get_termios': > drivers/usb/serial/cp210x.c:717:3: warning: passing argument 2 of 'cp210x_get_termios_port' from incompatible pointer type > cp210x_get_termios_port(tty->driver_data, > ^ > drivers/usb/serial/cp210x.c:35:13: note: expected 'unsigned int *' but argument is of type 'tcflag_t *' > static void cp210x_get_termios_port(struct usb_serial_port *port, > ^ > > Consistently use tcflag_t to fix this. > > Signed-off-by: Geert Uytterhoeven Applied for -next as this an old warning for something that should be benign on 32-bit. Thanks, Johan