From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932141AbcKVBXh (ORCPT ); Mon, 21 Nov 2016 20:23:37 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:44181 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753995AbcKVBXg (ORCPT ); Mon, 21 Nov 2016 20:23:36 -0500 X-Original-SENDERIP: 156.147.1.151 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.249.25 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Tue, 22 Nov 2016 10:22:12 +0900 From: Minchan Kim To: Sergey Senozhatsky CC: Andrew Morton , Takashi Iwai , Nitin Gupta , David Disseldorp , , Sergey Senozhatsky Subject: Re: [PATCH] zram: Fix unbalanced idr management at hot removal Message-ID: <20161122012212.GA11635@bbox> References: <20161121132140.12683-1-tiwai@suse.de> <20161122001104.GA31611@bbox> <20161122010930.GA5197@jagdpanzerIV> MIME-Version: 1.0 In-Reply-To: <20161122010930.GA5197@jagdpanzerIV> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB07/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/11/22 10:22:13, Serialize by Router on LGEKRMHUB07/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/11/22 10:22:14, Serialize complete at 2016/11/22 10:22:14 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sergey, On Tue, Nov 22, 2016 at 10:09:30AM +0900, Sergey Senozhatsky wrote: > Cc Andrew > > On (11/22/16 09:11), Minchan Kim wrote: > [..] > > > This patch adds the proper error check in hot_remove_store() not to > > > call idr_remove() unconditionally. > > > > > > Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1010970 > > > Reported-and-tested-by: David Disseldorp > > > Reviewed-by: David Disseldorp > > > Cc: > > > Signed-off-by: Takashi Iwai > > > > Acked-by: Minchan Kim > > Link: lkml.kernel.org/r/20161121132140.12683-1-tiwai@suse.de > Fixes: 17ec4cd98578 ("zram: don't call idr_remove() from zram_remove()") > Cc: [4.5+] 17ec4cd98578 marked as stable: [4.2+] so we should mark this patch as 4.2+. Thanks. > > Acked-by: Sergey Senozhatsky > > -ss