* [PATCH] zram: Fix unbalanced idr management at hot removal
@ 2016-11-21 13:21 Takashi Iwai
2016-11-21 13:48 ` Takashi Iwai
2016-11-22 0:11 ` Minchan Kim
0 siblings, 2 replies; 10+ messages in thread
From: Takashi Iwai @ 2016-11-21 13:21 UTC (permalink / raw)
To: Minchan Kim, Nitin Gupta
Cc: Sergey Senozhatsky, David Disseldorp, linux-kernel
The zram hot removal code calls idr_remove() even when zram_remove()
returns an error (typically -EBUSY). This results in a leftover at
the device release, eventually leading to a crash when the module is
reloaded.
As described in the bug report below, the following procedure would
cause an Oops with zram:
- provision three zram devices via modprobe zram num_devices=3
- configure a size for each device
+ echo "1G" > /sys/block/$zram_name/disksize
- mkfs and mount zram0 only
- attempt to hot remove all three devices
+ echo 2 > /sys/class/zram-control/hot_remove
+ echo 1 > /sys/class/zram-control/hot_remove
+ echo 0 > /sys/class/zram-control/hot_remove
- zram0 removal fails with EBUSY, as expected
- unmount zram0
- try zram0 hot remove again
+ echo 0 > /sys/class/zram-control/hot_remove
- fails with ENODEV (unexpected)
- unload zram kernel module
+ completes successfully
- zram0 device node still exists
- attempt to mount /dev/zram0
+ mount command is killed
+ following BUG is encountered
BUG: unable to handle kernel paging request at ffffffffa0002ba0
IP: [<ffffffff812eead6>] get_disk+0x16/0x50
Oops: 0000 [#1] SMP
CPU: 0 PID: 252 Comm: mount Not tainted 4.9.0-rc6 #176
task: ffff88001a9f2800 task.stack: ffffc90000300000
RIP: 0010:[<ffffffff812eead6>] [<ffffffff812eead6>] get_disk+0x16/0x50
Call Trace:
[<ffffffff812eeb1c>] exact_lock+0xc/0x20
[<ffffffff813b3e1c>] kobj_lookup+0xdc/0x160
[<ffffffff812edce0>] ? disk_map_sector_rcu+0x70/0x70
[<ffffffff81127410>] ? blkdev_get_by_dev+0x50/0x50
[<ffffffff812eef4f>] get_gendisk+0x2f/0x110
[<ffffffff81127410>] ? blkdev_get_by_dev+0x50/0x50
[<ffffffff81126e2c>] __blkdev_get+0x10c/0x3c0
[<ffffffff81127410>] ? blkdev_get_by_dev+0x50/0x50
[<ffffffff8112727d>] blkdev_get+0x19d/0x2e0
[<ffffffff81127410>] ? blkdev_get_by_dev+0x50/0x50
[<ffffffff81127466>] blkdev_open+0x56/0x70
[<ffffffff810f3e0f>] do_dentry_open.isra.19+0x1ff/0x310
[<ffffffff810f4aa3>] vfs_open+0x43/0x60
[<ffffffff81103009>] path_openat+0x2c9/0xf30
[<ffffffff81023c00>] ? __save_stack_trace+0x40/0xd0
[<ffffffff81104b79>] do_filp_open+0x79/0xd0
[<ffffffff81538219>] ? kmemleak_alloc+0x49/0xa0
[<ffffffff810f4e44>] do_sys_open+0x114/0x1e0
[<ffffffff810f4f29>] SyS_open+0x19/0x20
[<ffffffff8153c2e0>] entry_SYSCALL_64_fastpath+0x13/0x94
This patch adds the proper error check in hot_remove_store() not to
call idr_remove() unconditionally.
Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1010970
Reported-and-tested-by: David Disseldorp <ddiss@suse.de>
Reviewed-by: David Disseldorp <ddiss@suse.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
drivers/block/zram/zram_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 04365b17ee67..5163c8f918cb 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -1403,7 +1403,8 @@ static ssize_t hot_remove_store(struct class *class,
zram = idr_find(&zram_index_idr, dev_id);
if (zram) {
ret = zram_remove(zram);
- idr_remove(&zram_index_idr, dev_id);
+ if (!ret)
+ idr_remove(&zram_index_idr, dev_id);
} else {
ret = -ENODEV;
}
--
2.10.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] zram: Fix unbalanced idr management at hot removal
2016-11-21 13:21 [PATCH] zram: Fix unbalanced idr management at hot removal Takashi Iwai
@ 2016-11-21 13:48 ` Takashi Iwai
2016-11-22 0:11 ` Minchan Kim
1 sibling, 0 replies; 10+ messages in thread
From: Takashi Iwai @ 2016-11-21 13:48 UTC (permalink / raw)
To: Minchan Kim, Nitin Gupta
Cc: Sergey Senozhatsky, David Disseldorp, linux-kernel
On Mon, 21 Nov 2016 14:21:40 +0100,
Takashi Iwai wrote:
>
> The zram hot removal code calls idr_remove() even when zram_remove()
> returns an error (typically -EBUSY). This results in a leftover at
> the device release, eventually leading to a crash when the module is
> reloaded.
>
> As described in the bug report below, the following procedure would
> cause an Oops with zram:
>
> - provision three zram devices via modprobe zram num_devices=3
> - configure a size for each device
> + echo "1G" > /sys/block/$zram_name/disksize
> - mkfs and mount zram0 only
> - attempt to hot remove all three devices
> + echo 2 > /sys/class/zram-control/hot_remove
> + echo 1 > /sys/class/zram-control/hot_remove
> + echo 0 > /sys/class/zram-control/hot_remove
> - zram0 removal fails with EBUSY, as expected
> - unmount zram0
> - try zram0 hot remove again
> + echo 0 > /sys/class/zram-control/hot_remove
> - fails with ENODEV (unexpected)
> - unload zram kernel module
> + completes successfully
> - zram0 device node still exists
> - attempt to mount /dev/zram0
> + mount command is killed
> + following BUG is encountered
>
> BUG: unable to handle kernel paging request at ffffffffa0002ba0
> IP: [<ffffffff812eead6>] get_disk+0x16/0x50
> Oops: 0000 [#1] SMP
> CPU: 0 PID: 252 Comm: mount Not tainted 4.9.0-rc6 #176
> task: ffff88001a9f2800 task.stack: ffffc90000300000
> RIP: 0010:[<ffffffff812eead6>] [<ffffffff812eead6>] get_disk+0x16/0x50
> Call Trace:
> [<ffffffff812eeb1c>] exact_lock+0xc/0x20
> [<ffffffff813b3e1c>] kobj_lookup+0xdc/0x160
> [<ffffffff812edce0>] ? disk_map_sector_rcu+0x70/0x70
> [<ffffffff81127410>] ? blkdev_get_by_dev+0x50/0x50
> [<ffffffff812eef4f>] get_gendisk+0x2f/0x110
> [<ffffffff81127410>] ? blkdev_get_by_dev+0x50/0x50
> [<ffffffff81126e2c>] __blkdev_get+0x10c/0x3c0
> [<ffffffff81127410>] ? blkdev_get_by_dev+0x50/0x50
> [<ffffffff8112727d>] blkdev_get+0x19d/0x2e0
> [<ffffffff81127410>] ? blkdev_get_by_dev+0x50/0x50
> [<ffffffff81127466>] blkdev_open+0x56/0x70
> [<ffffffff810f3e0f>] do_dentry_open.isra.19+0x1ff/0x310
> [<ffffffff810f4aa3>] vfs_open+0x43/0x60
> [<ffffffff81103009>] path_openat+0x2c9/0xf30
> [<ffffffff81023c00>] ? __save_stack_trace+0x40/0xd0
> [<ffffffff81104b79>] do_filp_open+0x79/0xd0
> [<ffffffff81538219>] ? kmemleak_alloc+0x49/0xa0
> [<ffffffff810f4e44>] do_sys_open+0x114/0x1e0
> [<ffffffff810f4f29>] SyS_open+0x19/0x20
> [<ffffffff8153c2e0>] entry_SYSCALL_64_fastpath+0x13/0x94
>
> This patch adds the proper error check in hot_remove_store() not to
> call idr_remove() unconditionally.
>
> Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1010970
> Reported-and-tested-by: David Disseldorp <ddiss@suse.de>
> Reviewed-by: David Disseldorp <ddiss@suse.de>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Forgot to add Fixes tag:
Fixes: 17ec4cd98578 ("zram: don't call idr_remove() from zram_remove()")
Takashi
> ---
> drivers/block/zram/zram_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index 04365b17ee67..5163c8f918cb 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -1403,7 +1403,8 @@ static ssize_t hot_remove_store(struct class *class,
> zram = idr_find(&zram_index_idr, dev_id);
> if (zram) {
> ret = zram_remove(zram);
> - idr_remove(&zram_index_idr, dev_id);
> + if (!ret)
> + idr_remove(&zram_index_idr, dev_id);
> } else {
> ret = -ENODEV;
> }
> --
> 2.10.2
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zram: Fix unbalanced idr management at hot removal
2016-11-21 13:21 [PATCH] zram: Fix unbalanced idr management at hot removal Takashi Iwai
2016-11-21 13:48 ` Takashi Iwai
@ 2016-11-22 0:11 ` Minchan Kim
2016-11-22 1:09 ` Sergey Senozhatsky
1 sibling, 1 reply; 10+ messages in thread
From: Minchan Kim @ 2016-11-22 0:11 UTC (permalink / raw)
To: Takashi Iwai
Cc: Nitin Gupta, Sergey Senozhatsky, David Disseldorp, linux-kernel
On Mon, Nov 21, 2016 at 02:21:40PM +0100, Takashi Iwai wrote:
> The zram hot removal code calls idr_remove() even when zram_remove()
> returns an error (typically -EBUSY). This results in a leftover at
> the device release, eventually leading to a crash when the module is
> reloaded.
>
> As described in the bug report below, the following procedure would
> cause an Oops with zram:
>
> - provision three zram devices via modprobe zram num_devices=3
> - configure a size for each device
> + echo "1G" > /sys/block/$zram_name/disksize
> - mkfs and mount zram0 only
> - attempt to hot remove all three devices
> + echo 2 > /sys/class/zram-control/hot_remove
> + echo 1 > /sys/class/zram-control/hot_remove
> + echo 0 > /sys/class/zram-control/hot_remove
> - zram0 removal fails with EBUSY, as expected
> - unmount zram0
> - try zram0 hot remove again
> + echo 0 > /sys/class/zram-control/hot_remove
> - fails with ENODEV (unexpected)
> - unload zram kernel module
> + completes successfully
> - zram0 device node still exists
> - attempt to mount /dev/zram0
> + mount command is killed
> + following BUG is encountered
>
> BUG: unable to handle kernel paging request at ffffffffa0002ba0
> IP: [<ffffffff812eead6>] get_disk+0x16/0x50
> Oops: 0000 [#1] SMP
> CPU: 0 PID: 252 Comm: mount Not tainted 4.9.0-rc6 #176
> task: ffff88001a9f2800 task.stack: ffffc90000300000
> RIP: 0010:[<ffffffff812eead6>] [<ffffffff812eead6>] get_disk+0x16/0x50
> Call Trace:
> [<ffffffff812eeb1c>] exact_lock+0xc/0x20
> [<ffffffff813b3e1c>] kobj_lookup+0xdc/0x160
> [<ffffffff812edce0>] ? disk_map_sector_rcu+0x70/0x70
> [<ffffffff81127410>] ? blkdev_get_by_dev+0x50/0x50
> [<ffffffff812eef4f>] get_gendisk+0x2f/0x110
> [<ffffffff81127410>] ? blkdev_get_by_dev+0x50/0x50
> [<ffffffff81126e2c>] __blkdev_get+0x10c/0x3c0
> [<ffffffff81127410>] ? blkdev_get_by_dev+0x50/0x50
> [<ffffffff8112727d>] blkdev_get+0x19d/0x2e0
> [<ffffffff81127410>] ? blkdev_get_by_dev+0x50/0x50
> [<ffffffff81127466>] blkdev_open+0x56/0x70
> [<ffffffff810f3e0f>] do_dentry_open.isra.19+0x1ff/0x310
> [<ffffffff810f4aa3>] vfs_open+0x43/0x60
> [<ffffffff81103009>] path_openat+0x2c9/0xf30
> [<ffffffff81023c00>] ? __save_stack_trace+0x40/0xd0
> [<ffffffff81104b79>] do_filp_open+0x79/0xd0
> [<ffffffff81538219>] ? kmemleak_alloc+0x49/0xa0
> [<ffffffff810f4e44>] do_sys_open+0x114/0x1e0
> [<ffffffff810f4f29>] SyS_open+0x19/0x20
> [<ffffffff8153c2e0>] entry_SYSCALL_64_fastpath+0x13/0x94
>
> This patch adds the proper error check in hot_remove_store() not to
> call idr_remove() unconditionally.
>
> Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1010970
> Reported-and-tested-by: David Disseldorp <ddiss@suse.de>
> Reviewed-by: David Disseldorp <ddiss@suse.de>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Minchan Kim <minchan@kernel.org>
Thanks!
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zram: Fix unbalanced idr management at hot removal
2016-11-22 0:11 ` Minchan Kim
@ 2016-11-22 1:09 ` Sergey Senozhatsky
2016-11-22 1:22 ` Minchan Kim
2016-11-22 6:39 ` Sergey Senozhatsky
0 siblings, 2 replies; 10+ messages in thread
From: Sergey Senozhatsky @ 2016-11-22 1:09 UTC (permalink / raw)
To: Andrew Morton
Cc: Takashi Iwai, Nitin Gupta, Sergey Senozhatsky, David Disseldorp,
linux-kernel, Minchan Kim, Sergey Senozhatsky
Cc Andrew
On (11/22/16 09:11), Minchan Kim wrote:
[..]
> > This patch adds the proper error check in hot_remove_store() not to
> > call idr_remove() unconditionally.
> >
> > Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1010970
> > Reported-and-tested-by: David Disseldorp <ddiss@suse.de>
> > Reviewed-by: David Disseldorp <ddiss@suse.de>
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> Acked-by: Minchan Kim <minchan@kernel.org>
Link: lkml.kernel.org/r/20161121132140.12683-1-tiwai@suse.de
Fixes: 17ec4cd98578 ("zram: don't call idr_remove() from zram_remove()")
Cc: <stable@vger.kernel.org> [4.5+]
Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zram: Fix unbalanced idr management at hot removal
2016-11-22 1:09 ` Sergey Senozhatsky
@ 2016-11-22 1:22 ` Minchan Kim
2016-11-22 1:28 ` Sergey Senozhatsky
2016-11-22 6:39 ` Sergey Senozhatsky
1 sibling, 1 reply; 10+ messages in thread
From: Minchan Kim @ 2016-11-22 1:22 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: Andrew Morton, Takashi Iwai, Nitin Gupta, David Disseldorp,
linux-kernel, Sergey Senozhatsky
Hi Sergey,
On Tue, Nov 22, 2016 at 10:09:30AM +0900, Sergey Senozhatsky wrote:
> Cc Andrew
>
> On (11/22/16 09:11), Minchan Kim wrote:
> [..]
> > > This patch adds the proper error check in hot_remove_store() not to
> > > call idr_remove() unconditionally.
> > >
> > > Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1010970
> > > Reported-and-tested-by: David Disseldorp <ddiss@suse.de>
> > > Reviewed-by: David Disseldorp <ddiss@suse.de>
> > > Cc: <stable@vger.kernel.org>
> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
>
>
> > Acked-by: Minchan Kim <minchan@kernel.org>
>
> Link: lkml.kernel.org/r/20161121132140.12683-1-tiwai@suse.de
> Fixes: 17ec4cd98578 ("zram: don't call idr_remove() from zram_remove()")
> Cc: <stable@vger.kernel.org> [4.5+]
17ec4cd98578 marked as stable: [4.2+] so we should mark this patch as
4.2+.
Thanks.
>
> Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>
> -ss
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zram: Fix unbalanced idr management at hot removal
2016-11-22 1:22 ` Minchan Kim
@ 2016-11-22 1:28 ` Sergey Senozhatsky
2016-11-22 1:33 ` Minchan Kim
0 siblings, 1 reply; 10+ messages in thread
From: Sergey Senozhatsky @ 2016-11-22 1:28 UTC (permalink / raw)
To: Minchan Kim
Cc: Sergey Senozhatsky, Andrew Morton, Takashi Iwai, Nitin Gupta,
David Disseldorp, linux-kernel, Sergey Senozhatsky
On (11/22/16 10:22), Minchan Kim wrote:
[..]
> > > Acked-by: Minchan Kim <minchan@kernel.org>
> >
> > Link: lkml.kernel.org/r/20161121132140.12683-1-tiwai@suse.de
> > Fixes: 17ec4cd98578 ("zram: don't call idr_remove() from zram_remove()")
> > Cc: <stable@vger.kernel.org> [4.5+]
>
> 17ec4cd98578 marked as stable: [4.2+] so we should mark this patch as
> 4.2+.
well, no objections. except that the patch in question was
not picked up -stable
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/block/zram/zram_drv.c?id=refs/tags/v4.2#n1365
the change appears starting from 4.5
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/block/zram/zram_drv.c?id=refs/tags/v4.5#n1371
-ss
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zram: Fix unbalanced idr management at hot removal
2016-11-22 1:28 ` Sergey Senozhatsky
@ 2016-11-22 1:33 ` Minchan Kim
2016-11-22 1:39 ` Sergey Senozhatsky
0 siblings, 1 reply; 10+ messages in thread
From: Minchan Kim @ 2016-11-22 1:33 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: Andrew Morton, Takashi Iwai, Nitin Gupta, David Disseldorp,
linux-kernel, Sergey Senozhatsky
On Tue, Nov 22, 2016 at 10:28:12AM +0900, Sergey Senozhatsky wrote:
> On (11/22/16 10:22), Minchan Kim wrote:
> [..]
> > > > Acked-by: Minchan Kim <minchan@kernel.org>
> > >
> > > Link: lkml.kernel.org/r/20161121132140.12683-1-tiwai@suse.de
> > > Fixes: 17ec4cd98578 ("zram: don't call idr_remove() from zram_remove()")
> > > Cc: <stable@vger.kernel.org> [4.5+]
> >
> > 17ec4cd98578 marked as stable: [4.2+] so we should mark this patch as
> > 4.2+.
>
> well, no objections. except that the patch in question was
> not picked up -stable
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/block/zram/zram_drv.c?id=refs/tags/v4.2#n1365
>
> the change appears starting from 4.5
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/block/zram/zram_drv.c?id=refs/tags/v4.5#n1371
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/block/zram/zram_drv.c?id=refs/tags/v4.4.34#n1370
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zram: Fix unbalanced idr management at hot removal
2016-11-22 1:33 ` Minchan Kim
@ 2016-11-22 1:39 ` Sergey Senozhatsky
2016-11-22 5:52 ` Takashi Iwai
0 siblings, 1 reply; 10+ messages in thread
From: Sergey Senozhatsky @ 2016-11-22 1:39 UTC (permalink / raw)
To: Minchan Kim
Cc: Sergey Senozhatsky, Andrew Morton, Takashi Iwai, Nitin Gupta,
David Disseldorp, linux-kernel, Sergey Senozhatsky
On (11/22/16 10:33), Minchan Kim wrote:
> On Tue, Nov 22, 2016 at 10:28:12AM +0900, Sergey Senozhatsky wrote:
> > On (11/22/16 10:22), Minchan Kim wrote:
> > [..]
> > > > > Acked-by: Minchan Kim <minchan@kernel.org>
> > > >
> > > > Link: lkml.kernel.org/r/20161121132140.12683-1-tiwai@suse.de
> > > > Fixes: 17ec4cd98578 ("zram: don't call idr_remove() from zram_remove()")
> > > > Cc: <stable@vger.kernel.org> [4.5+]
> > >
> > > 17ec4cd98578 marked as stable: [4.2+] so we should mark this patch as
> > > 4.2+.
> >
> > well, no objections. except that the patch in question was
> > not picked up -stable
> > https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/block/zram/zram_drv.c?id=refs/tags/v4.2#n1365
> >
> > the change appears starting from 4.5
> > https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/block/zram/zram_drv.c?id=refs/tags/v4.5#n1371
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/block/zram/zram_drv.c?id=refs/tags/v4.4.34#n1370
oh, ok. good find. 4.4+ then? there are no affected stable/longterm
kernels older than 4.4.x anyway (4.1 lts has no dynamic zram management).
-ss
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zram: Fix unbalanced idr management at hot removal
2016-11-22 1:39 ` Sergey Senozhatsky
@ 2016-11-22 5:52 ` Takashi Iwai
0 siblings, 0 replies; 10+ messages in thread
From: Takashi Iwai @ 2016-11-22 5:52 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: Minchan Kim, Andrew Morton, Takashi Iwai, Nitin Gupta,
David Disseldorp, linux-kernel, Sergey Senozhatsky
On Tue, 22 Nov 2016 02:39:13 +0100,
Sergey Senozhatsky wrote:
>
> On (11/22/16 10:33), Minchan Kim wrote:
> > On Tue, Nov 22, 2016 at 10:28:12AM +0900, Sergey Senozhatsky wrote:
> > > On (11/22/16 10:22), Minchan Kim wrote:
> > > [..]
> > > > > > Acked-by: Minchan Kim <minchan@kernel.org>
> > > > >
> > > > > Link: lkml.kernel.org/r/20161121132140.12683-1-tiwai@suse.de
> > > > > Fixes: 17ec4cd98578 ("zram: don't call idr_remove() from zram_remove()")
> > > > > Cc: <stable@vger.kernel.org> [4.5+]
> > > >
> > > > 17ec4cd98578 marked as stable: [4.2+] so we should mark this patch as
> > > > 4.2+.
> > >
> > > well, no objections. except that the patch in question was
> > > not picked up -stable
> > > https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/block/zram/zram_drv.c?id=refs/tags/v4.2#n1365
> > >
> > > the change appears starting from 4.5
> > > https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/block/zram/zram_drv.c?id=refs/tags/v4.5#n1371
>
>
> > https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/block/zram/zram_drv.c?id=refs/tags/v4.4.34#n1370
>
> oh, ok. good find. 4.4+ then? there are no affected stable/longterm
> kernels older than 4.4.x anyway (4.1 lts has no dynamic zram management).
Right, at least, 4.4.x hits the issue (actually the original bug
report was for 4.4.x).
thanks,
Takashi
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zram: Fix unbalanced idr management at hot removal
2016-11-22 1:09 ` Sergey Senozhatsky
2016-11-22 1:22 ` Minchan Kim
@ 2016-11-22 6:39 ` Sergey Senozhatsky
1 sibling, 0 replies; 10+ messages in thread
From: Sergey Senozhatsky @ 2016-11-22 6:39 UTC (permalink / raw)
To: Andrew Morton
Cc: Takashi Iwai, Nitin Gupta, David Disseldorp, linux-kernel,
Minchan Kim, Sergey Senozhatsky, Sergey Senozhatsky
A correction,
On (11/22/16 10:09), Sergey Senozhatsky wrote:
[..]
> > > Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1010970
> > > Reported-and-tested-by: David Disseldorp <ddiss@suse.de>
> > > Reviewed-by: David Disseldorp <ddiss@suse.de>
> > > Cc: <stable@vger.kernel.org>
> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
>
>
> > Acked-by: Minchan Kim <minchan@kernel.org>
>
> Link: lkml.kernel.org/r/20161121132140.12683-1-tiwai@suse.de
> Fixes: 17ec4cd98578 ("zram: don't call idr_remove() from zram_remove()")
> Cc: <stable@vger.kernel.org> [4.5+]
^^^^ 4.4+
> Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
but somehow I didn't notice that Takashi Cc'd stable in the original patch.
so mine can be dropped.
-ss
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-11-22 6:39 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-21 13:21 [PATCH] zram: Fix unbalanced idr management at hot removal Takashi Iwai
2016-11-21 13:48 ` Takashi Iwai
2016-11-22 0:11 ` Minchan Kim
2016-11-22 1:09 ` Sergey Senozhatsky
2016-11-22 1:22 ` Minchan Kim
2016-11-22 1:28 ` Sergey Senozhatsky
2016-11-22 1:33 ` Minchan Kim
2016-11-22 1:39 ` Sergey Senozhatsky
2016-11-22 5:52 ` Takashi Iwai
2016-11-22 6:39 ` Sergey Senozhatsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox