From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933355AbcKVM7K (ORCPT ); Tue, 22 Nov 2016 07:59:10 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:38823 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932362AbcKVM7I (ORCPT ); Tue, 22 Nov 2016 07:59:08 -0500 Date: Tue, 22 Nov 2016 13:02:08 +0000 From: Lee Jones To: Keerthy Cc: tony@atomide.com, robh+dt@kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, nm@ti.com, t-kristo@ti.com Subject: Re: [PATCH v2 2/5] mfd: palmas: Remove redundant check in palmas_power_off Message-ID: <20161122130208.GD316@dell.lan> References: <1478754560-27923-1-git-send-email-j-keerthy@ti.com> <1478754560-27923-3-git-send-email-j-keerthy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1478754560-27923-3-git-send-email-j-keerthy@ti.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Nov 2016, Keerthy wrote: > palmas_dev and palmas_power_off are always assigned together. > So the check for palmas_dev inside palmas_power_off function > is redundant. Removing the same. > > Signed-off-by: Keerthy > --- > drivers/mfd/palmas.c | 3 --- > 1 file changed, 3 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c > index 8f8bacb..ee9e9ea 100644 > --- a/drivers/mfd/palmas.c > +++ b/drivers/mfd/palmas.c > @@ -431,9 +431,6 @@ static void palmas_power_off(void) > unsigned int addr; > int ret, slave; > > - if (!palmas_dev) > - return; > - > slave = PALMAS_BASE_TO_SLAVE(PALMAS_PMU_CONTROL_BASE); > addr = PALMAS_BASE_TO_REG(PALMAS_PMU_CONTROL_BASE, PALMAS_DEV_CTRL); > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog