From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756249AbcKWBUU (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Nov 2016 20:20:20 -0500
Received: from mga02.intel.com ([134.134.136.20]:23312 "EHLO mga02.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755902AbcKWBUS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Nov 2016 20:20:18 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,535,1473145200"; 
   d="scan'208";a="34564200"
Date: Tue, 22 Nov 2016 17:22:17 -0800
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Rafael Wysocki <rjw@sisk.pl>,
        x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
        linux-pm@vger.kernel.org,
        Srinivas Pandruvada <srinivas.pandruvada@intel.com>,
        jacob.jun.pan@linux.intel.com
Subject: Re: [patch 1/5] powercap/intel_rapl: Add missing domain data update
 on hotplug
Message-ID: <20161122172217.28e77ed6@jacob-builder>
In-Reply-To: <20161122211438.432984735@linutronix.de>
References: <20161122210518.079483154@linutronix.de>
        <20161122211438.432984735@linutronix.de>
Organization: OTC
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 22 Nov 2016 21:15:58 -0000
Thomas Gleixner <tglx@linutronix.de> wrote:

> The more interesting question is why rapl_update_domain_data() exists
> at all as nothing ever uses that data.

You are right, initial domain data are read at initialization time but
not used. I seem to remember I did this trying to save and restore rapl
raw settings between module load and unload. But I forgot to use it
for restore :(.

Thanks,

Jacob