From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932763AbcKWEqB (ORCPT ); Tue, 22 Nov 2016 23:46:01 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:36270 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932546AbcKWEp7 (ORCPT ); Tue, 22 Nov 2016 23:45:59 -0500 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 165.244.249.26 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Wed, 23 Nov 2016 13:45:53 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo CC: Steven Rostedt , , Ingo Molnar , Jiri Olsa , Andrew Morton Subject: Re: [PATCH v2] tools lib traceevent: Add retrieval of preempt count and latency flags Message-ID: <20161123044553.GA19719@sejong> References: <20161118225359.378120451@goodmis.org> <20161118225457.823985960@goodmis.org> <20161122065245.GA10108@danjae.aot.lge.com> <20161122113158.03a010a8@gandalf.local.home> <20161122180624.GB5390@kernel.org> MIME-Version: 1.0 In-Reply-To: <20161122180624.GB5390@kernel.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/11/23 13:45:53, Serialize by Router on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/11/23 13:45:53, Serialize complete at 2016/11/23 13:45:53 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo and Steve, On Tue, Nov 22, 2016 at 03:06:24PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Nov 22, 2016 at 11:31:58AM -0500, Steven Rostedt escreveu: > > > > Add a way to retrieve the preempt count as well as the latency flags from a > > pevent_record. > > > > int pevent_data_preempt_count(pevent, record); > > > > returns the preempt count of a record. > > > > int pevent_data_flags(pevent, record); > > > > returns the latency flags for a record. > > Namhyung, I'm preemptively adding your Acked-by, ok? Sure. Acked-by: Namhyung Kim Thanks, Namhyung > > > Signed-off-by: Steven Rostedt > > --- > > tools/lib/traceevent/event-parse.c | 30 ++++++++++++++++++++++++++++-- > > tools/lib/traceevent/event-parse.h | 2 ++ > > 2 files changed, 30 insertions(+), 2 deletions(-) > > > > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c > > index 664c90c8e22b..6e2dfcbf9e30 100644 > > --- a/tools/lib/traceevent/event-parse.c > > +++ b/tools/lib/traceevent/event-parse.c > > @@ -5191,11 +5191,11 @@ struct event_format *pevent_data_event_from_type(struct pevent *pevent, int type > > } > > > > /** > > - * pevent_data_pid - parse the PID from raw data > > + * pevent_data_pid - parse the PID from record > > * @pevent: a handle to the pevent > > * @rec: the record to parse > > * > > - * This returns the PID from a raw data. > > + * This returns the PID from a record. > > */ > > int pevent_data_pid(struct pevent *pevent, struct pevent_record *rec) > > { > > @@ -5203,6 +5203,32 @@ int pevent_data_pid(struct pevent *pevent, struct pevent_record *rec) > > } > > > > /** > > + * pevent_data_prempt_count - parse the preempt count from the record > > + * @pevent: a handle to the pevent > > + * @rec: the record to parse > > + * > > + * This returns the preempt count from a record. > > + */ > > +int pevent_data_prempt_count(struct pevent *pevent, struct pevent_record *rec) > > +{ > > + return parse_common_pc(pevent, rec->data); > > +} > > + > > +/** > > + * pevent_data_flags - parse the latency flags from the record > > + * @pevent: a handle to the pevent > > + * @rec: the record to parse > > + * > > + * This returns the latency flags from a record. > > + * > > + * Use trace_flag_type enum for the flags (see event-parse.h). > > + */ > > +int pevent_data_flags(struct pevent *pevent, struct pevent_record *rec) > > +{ > > + return parse_common_flags(pevent, rec->data); > > +} > > + > > +/** > > * pevent_data_comm_from_pid - return the command line from PID > > * @pevent: a handle to the pevent > > * @pid: the PID of the task to search for > > diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h > > index 9ffde377e89d..82b83c4d621c 100644 > > --- a/tools/lib/traceevent/event-parse.h > > +++ b/tools/lib/traceevent/event-parse.h > > @@ -712,6 +712,8 @@ void pevent_data_lat_fmt(struct pevent *pevent, > > int pevent_data_type(struct pevent *pevent, struct pevent_record *rec); > > struct event_format *pevent_data_event_from_type(struct pevent *pevent, int type); > > int pevent_data_pid(struct pevent *pevent, struct pevent_record *rec); > > +int pevent_data_prempt_count(struct pevent *pevent, struct pevent_record *rec); > > +int pevent_data_flags(struct pevent *pevent, struct pevent_record *rec); > > const char *pevent_data_comm_from_pid(struct pevent *pevent, int pid); > > struct cmdline; > > struct cmdline *pevent_data_pid_from_comm(struct pevent *pevent, const char *comm, > > -- > > 2.1.0 > >