From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934049AbcKWIkb (ORCPT ); Wed, 23 Nov 2016 03:40:31 -0500 Received: from verein.lst.de ([213.95.11.211]:55127 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933767AbcKWIjv (ORCPT ); Wed, 23 Nov 2016 03:39:51 -0500 Date: Wed, 23 Nov 2016 09:39:49 +0100 From: Christoph Hellwig To: Andrey Ryabinin Cc: Christoph Hellwig , akpm@linux-foundation.org, joelaf@google.com, jszhang@marvell.com, chris@chris-wilson.co.uk, joaodias@google.com, linux-mm@kvack.org, linux-rt-users@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/10] mm: warn about vfree from atomic context Message-ID: <20161123083949.GD16966@lst.de> References: <1479474236-4139-1-git-send-email-hch@lst.de> <1479474236-4139-8-git-send-email-hch@lst.de> <996e56cb-137f-cd3e-eb69-e9ef03ad75c4@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <996e56cb-137f-cd3e-eb69-e9ef03ad75c4@virtuozzo.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 22, 2016 at 07:35:34PM +0300, Andrey Ryabinin wrote: > This one is wrong. We still can call vfree() from interrupt context. > So WARN_ON_ONCE(in_atomic() && !in_interrupt()) would be correct, > but also redundant. DEBUG_ATOMIC_SLEEP=y should catch illegal vfree() calls. > Let's just drop this patch, ok? Ok, fine.