From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934836AbcKWJq7 (ORCPT ); Wed, 23 Nov 2016 04:46:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40398 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755941AbcKWJqW (ORCPT ); Wed, 23 Nov 2016 04:46:22 -0500 Date: Wed, 23 Nov 2016 10:46:19 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 02/10] perf, tools: Parse eventcode as number in jevents Message-ID: <20161123094619.GB19377@krava> References: <1479515780-4702-1-git-send-email-andi@firstfloor.org> <1479515780-4702-3-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479515780-4702-3-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 23 Nov 2016 09:46:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2016 at 04:36:12PM -0800, Andi Kleen wrote: > From: Andi Kleen > > The next patch needs to modify event code. Previously eventcode was just > passed through as a string. Now parse it as a number. > > Signed-off-by: Andi Kleen > --- > tools/perf/pmu-events/jevents.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c > index 41611d7f9873..d343156b1dea 100644 > --- a/tools/perf/pmu-events/jevents.c > +++ b/tools/perf/pmu-events/jevents.c > @@ -135,7 +135,6 @@ static struct field { > const char *field; > const char *kernel; > } fields[] = { > - { "EventCode", "event=" }, > { "UMask", "umask=" }, > { "CounterMask", "cmask=" }, > { "Invert", "inv=" }, > @@ -164,6 +163,9 @@ static int match_field(char *map, jsmntok_t *field, int nz, > > for (f = fields; f->field; f++) > if (json_streq(map, field, f->field) && nz) { > + if (json_streq(map, val, "0x00") || > + json_streq(map, val, "0x0")) > + return 1; why is this needed? could you please put in the comment? thanks, jirka