From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 01/10] perf, tools: Factor out scale conversion code
Date: Wed, 23 Nov 2016 10:46:24 +0100 [thread overview]
Message-ID: <20161123094624.GC19377@krava> (raw)
In-Reply-To: <1479515780-4702-2-git-send-email-andi@firstfloor.org>
On Fri, Nov 18, 2016 at 04:36:11PM -0800, Andi Kleen wrote:
SNIP
> @@ -261,6 +267,12 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
> alias->long_desc = long_desc ? strdup(long_desc) :
> desc ? strdup(desc) : NULL;
> alias->topic = topic ? strdup(topic) : NULL;
> + if (unit) {
> + if (convert_scale(unit, &unit, &alias->scale) < 0)
> + return -1;
> + snprintf(alias->unit, sizeof(alias->unit), "%s", unit);
> + }
> + alias->str = strdup(val);
CC util/pmu.o
util/pmu.c: In function ‘__perf_pmu__new_alias’:
util/pmu.c:277:7: error: ‘struct perf_pmu_alias’ has no member named ‘str’
alias->str = strdup(val);
jirka
next prev parent reply other threads:[~2016-11-23 9:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 0:36 Support Intel uncore event lists in perf Andi Kleen
2016-11-19 0:36 ` [PATCH 01/10] perf, tools: Factor out scale conversion code Andi Kleen
2016-11-23 9:26 ` Jiri Olsa
2016-11-23 9:46 ` Jiri Olsa [this message]
2016-11-19 0:36 ` [PATCH 02/10] perf, tools: Parse eventcode as number in jevents Andi Kleen
2016-11-23 9:46 ` Jiri Olsa
2016-11-19 0:36 ` [PATCH 03/10] perf, tools: Add support for parsing uncore json files Andi Kleen
2016-11-19 0:36 ` [PATCH 04/10] perf, tools: Support per pmu json aliases Andi Kleen
2016-11-19 0:36 ` [PATCH 05/10] perf, tools: Support event aliases for non cpu// pmus Andi Kleen
2016-11-19 0:36 ` [PATCH 06/10] perf, tools: Add debug support for outputing alias string Andi Kleen
2016-11-19 0:36 ` [PATCH 07/10] perf, tools: Collapse identically named events in perf stat Andi Kleen
2016-11-19 0:36 ` [PATCH 08/10] perf, tools: Expand PMU events by prefix match Andi Kleen
2016-11-19 0:36 ` [PATCH 09/10] perf, tools: Support DividedBy header in JSON event list Andi Kleen
2016-11-19 0:36 ` [PATCH 10/10] perf, tools, stat: Output generic dividedby metric Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2016-10-13 21:15 Support Intel uncore event lists Andi Kleen
2016-10-13 21:15 ` [PATCH 01/10] perf, tools: Factor out scale conversion code Andi Kleen
2016-10-14 15:35 ` Arnaldo Carvalho de Melo
2016-10-14 15:45 ` Andi Kleen
2016-10-14 16:08 ` Arnaldo Carvalho de Melo
2016-10-14 16:15 ` Andi Kleen
2016-10-14 16:25 ` Arnaldo Carvalho de Melo
2016-10-14 16:36 ` Andi Kleen
2016-10-14 16:38 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123094624.GC19377@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).