From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934785AbcKWJq6 (ORCPT ); Wed, 23 Nov 2016 04:46:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51280 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933883AbcKWJq1 (ORCPT ); Wed, 23 Nov 2016 04:46:27 -0500 Date: Wed, 23 Nov 2016 10:46:24 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 01/10] perf, tools: Factor out scale conversion code Message-ID: <20161123094624.GC19377@krava> References: <1479515780-4702-1-git-send-email-andi@firstfloor.org> <1479515780-4702-2-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1479515780-4702-2-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 23 Nov 2016 09:46:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2016 at 04:36:11PM -0800, Andi Kleen wrote: SNIP > @@ -261,6 +267,12 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name, > alias->long_desc = long_desc ? strdup(long_desc) : > desc ? strdup(desc) : NULL; > alias->topic = topic ? strdup(topic) : NULL; > + if (unit) { > + if (convert_scale(unit, &unit, &alias->scale) < 0) > + return -1; > + snprintf(alias->unit, sizeof(alias->unit), "%s", unit); > + } > + alias->str = strdup(val); CC util/pmu.o util/pmu.c: In function ‘__perf_pmu__new_alias’: util/pmu.c:277:7: error: ‘struct perf_pmu_alias’ has no member named ‘str’ alias->str = strdup(val); jirka