Re: [PATCH 6/6] efi: Add EFI_SECURE_BOOT bit [ver #2]

David Howells
2016-11-23T10:11:20Z

David Howells <dhowells@redhat.com> wrote:

> > > +#ifdef CONFIG_EFI
> > > + if (boot_params.secure_boot) {
> > > + set_bit(EFI_SECURE_BOOT, &efi.flags);
> > > + pr_info("Secure boot enabled\n");
> > > + }
> > > +#endif
> > > +
> >
> > Section 20 of Documentation/CodingStyle recommends IS_ENABLED()
> > instead of #ifdef.
>
> The problem is this:
>
> arch/x86/include/asm/bitops.h:75: undefined reference to `efi'
>
> To quote section 20: "... Thus, you still have to use an #ifdef if the code
> inside the block references symbols that will not exist if the condition is
> not met."

Okay, I take that back - it does actually work. However, should I follow the
scheme of the rest of the file?

David