From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938824AbcKWPQJ (ORCPT ); Wed, 23 Nov 2016 10:16:09 -0500 Received: from fldsmtpe03.verizon.com ([140.108.26.142]:17991 "EHLO fldsmtpe03.verizon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938710AbcKWPPy (ORCPT ); Wed, 23 Nov 2016 10:15:54 -0500 X-Greylist: delayed 673 seconds by postgrey-1.27 at vger.kernel.org; Wed, 23 Nov 2016 10:15:53 EST X-IronPort-Anti-Spam-Filtered: false X-IronPort-AV: E=Sophos;i="5.31,538,1473120000"; d="scan'208";a="239376517" From: alexander.levin@verizon.com X-Host: ranger.odc.vzwcorp.com To: Dmitry Vyukov CC: Steven Rostedt , "tglx@linutronix.de" , "scientist@fb.com" , "glider@google.com" , "andreyknvl@google.com" , "arnd@arndb.de" , "mathieu.desnoyers@efficios.com" , "daniel.vetter@ffwll.ch" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC 2/3] abi_spec: hooks into syscall to allow pre and post checking Thread-Topic: [RFC 2/3] abi_spec: hooks into syscall to allow pre and post checking Thread-Index: AQHSRZriJsVeVV5+J0eJk4i34umcdw== Date: Wed, 23 Nov 2016 15:04:27 +0000 Message-ID: <20161123150435.GA30459@sasha-lappy> References: <1479317803-17220-1-git-send-email-alexander.levin@verizon.com> <1479317803-17220-3-git-send-email-alexander.levin@verizon.com> <20161121105443.249ddff8@gandalf.local.home> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mutt/1.5.24 (2015-08-30) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] Content-Type: text/plain; charset="us-ascii" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uANFGE5g018089 On Mon, Nov 21, 2016 at 04:57:02PM +0100, Dmitry Vyukov wrote: > On Mon, Nov 21, 2016 at 4:54 PM, Steven Rostedt wrote: > > On Wed, 16 Nov 2016 17:37:01 +0000 > > alexander.levin@verizon.com wrote: > >> #define __SYSCALL_DEFINEx(x, name, ...) \ > >> + extern const struct syscall_spec syscall_spec##name; \ > >> asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ > >> __attribute__((alias(__stringify(SyS##name)))); \ > >> static inline long SYSC##name(__MAP(x,__SC_DECL,__VA_ARGS__)); \ > >> asmlinkage long SyS##name(__MAP(x,__SC_LONG,__VA_ARGS__)); \ > >> asmlinkage long SyS##name(__MAP(x,__SC_LONG,__VA_ARGS__)) \ > >> { \ > >> - long ret = SYSC##name(__MAP(x,__SC_CAST,__VA_ARGS__)); \ > >> + long ret; \ > >> + abispec_check_pre(&syscall_spec##name, __MAP(x,__SC_CAST,__VA_ARGS__)); \ > >> + ret = SYSC##name(__MAP(x,__SC_CAST,__VA_ARGS__)); \ > >> + abispec_check_post(&syscall_spec##name, ret, __MAP(x,__SC_CAST,__VA_ARGS__)); \ > > > > Do you want this for DEFINE0() too? Or does this not care about system > > calls with no arguments? > > This should care about syscalls without args: > - we still may want to check return values > - something like debug tracing would like to print them > - there may also be some side effects (or absence of side effects) > that we may want to check Yes, agreed, I just missed that detail in my implementation. -- Thanks, Sasha