Re: [PATCH v2 0/6] staging: speakup: speakup_soft.c checkpatch modifications

[Walt Feasel <waltfeasel@gmail.com>]

On Wed, Nov 23, 2016 at 04:56:32PM +0100, Greg KH wrote:
> On Wed, Nov 23, 2016 at 05:52:25AM -0500, Fleetwood Farm wrote:
> > On Nov 23, 2016 4:08 AM, "Greg KH" <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Mon, Nov 21, 2016 at 10:19:19AM -0500, Walt Feasel wrote:
> > > > Make Linux kernel style modifications for speak_soft.c to include:
> > > >
> > > > Space around operator
> > > > Logical continuation
> > > > Multiple blank lines
> > > > Blank line after {
> > > > comment modifications
> > > > Align parenthesis
> > >
> > > Ok, now that you have a bunch of cleanup patches accepted, why not work
> > > on some "real" code changes?  There's no need to fix all of the coding
> > > style issues in drivers/staging/ at once, leave some for other people to
> > > learn on :)
> > >
> > > thanks,
> > >
> > > greg k-h
> > 
> > Well, I have around 40 more patches already prepared waiting for my limit to
> > clear (which just did) and about 12 more files left to checkpatch in speakup.
> > I am currently waiting on the newbies administer to clear my sent emails asking
> > advice on if some of my tougher challenges (octals and CamelCase) are done
> > correctly.
> 
> "newbies administrator"?
> 

Yes have a email saying my email "is being held until the list moderator can
review it for approval"

> > I am also currently waiting on the u-boot mailing list administer to do the
> > same on some of my patches.
> > I also am doing some online 'c' courses to increase (get) my skills set.
> > What type of "real" code changes did you have in mind with my limited skill
> > set?
> 
> I'd strongly suggest working on some userspace programs to get a
> less-limited skill set :)  Then find some area of the kernel you are
> interested in, and help out there.  Speakup really can use the help, and
> the community of users of their devices is very good, so any real work
> you can do there would always be greatly appreciated.
> 
That is good advice about limiting skill set. I am trying to do that with
converting some of my simple bash scripts to 'c'. While it may not be very
usefull it is a start and won't mess up anything important for others.
I do think I am learning from these simple checkpatch patches as I try to
research the items I do not know. Plus I think it instills a good style
format. I have written programs in the past for my jobs but never in 'c'
and this driver stuff is over my head.

I do not wish to burden/annoy anyone with these simple fixes, I thought
it may help with getting them out of staging. I won't take offense if it is
preferred I did not do them.
I am not very quick on subtleties so if anyone wishes for me to move on I will.
> best of luck,
> 
> greg k-h

Walt