From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751694AbcKXGau (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Nov 2016 01:30:50 -0500
Received: from LGEAMRELO12.lge.com ([156.147.23.52]:56038 "EHLO
        lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750920AbcKXGat (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Nov 2016 01:30:49 -0500
X-Original-SENDERIP: 156.147.1.126
X-Original-MAILFROM: namhyung@kernel.org
X-Original-SENDERIP: 10.177.227.17
X-Original-MAILFROM: namhyung@kernel.org
Date: Thu, 24 Nov 2016 15:30:46 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 1/3] perf sched timehist: Mark schedule function in
 callchains
Message-ID: <20161124063046.GA12782@sejong>
References: <20161124011114.7102-1-namhyung@kernel.org>
 <0eaa350e-8b5d-539f-c073-f230353ae405@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <0eaa350e-8b5d-539f-c073-f230353ae405@gmail.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi David,

On Wed, Nov 23, 2016 at 10:13:46PM -0500, David Ahern wrote:
> On 11/23/16 8:11 PM, Namhyung Kim wrote:
> > The sched_switch event always captured from the scheduler function.  So
> > it'd be great omit them from the callchain.  This patch marks the
> > functions to be omitted by later patch.
> 
> I had this covered by a symbol filter:
> 
> https://github.com/dsahern/linux/blob/perf/full-monty-4.1/tools/perf/builtin-sched.c#L3000
> 
> Not sure what happened over the years but that should still work and
> allows the user to add more symbols to ignore:

The symbol filter was removed by commit be39db9f2932 ("perf symbols:
Remove symbol_filter_t machinery").

Thanks,
Namhyung


> 
> https://github.com/dsahern/linux/blob/perf/full-monty-4.1/tools/perf/builtin-sched.c#L3449
>