From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S938829AbcKXKrZ (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Nov 2016 05:47:25 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:16780 "EHLO
        aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933774AbcKXKrY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Nov 2016 05:47:24 -0500
Date: Thu, 24 Nov 2016 13:46:23 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [patch] char/pcmcia: add some error checking in scr24x_read()
Message-ID: <20161124104623.GA17225@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.6.0 (2016-04-01)
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The "ret = " assignment seems to have accidentally been left off.

Fixes: f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/char/pcmcia/scr24x_cs.c b/drivers/char/pcmcia/scr24x_cs.c
index 4f215ce..8523ec5 100644
--- a/drivers/char/pcmcia/scr24x_cs.c
+++ b/drivers/char/pcmcia/scr24x_cs.c
@@ -157,7 +157,7 @@ static ssize_t scr24x_read(struct file *filp, char __user *buf, size_t count,
 		ret = -EIO;
 		goto out;
 	}
-	read_chunk(dev, CCID_HEADER_SIZE, len);
+	ret = read_chunk(dev, CCID_HEADER_SIZE, len);
 	if (ret < 0)
 		goto out;