From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Nayna <nayna@linux.vnet.ibm.com>
Cc: tpmdd-devel@lists.sourceforge.net, peterhuewe@gmx.de,
tpmdd@selhorst.net, jarkko.sakkinen@linux.intel.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c
Date: Thu, 24 Nov 2016 09:43:31 -0700 [thread overview]
Message-ID: <20161124164331.GA4930@obsidianresearch.com> (raw)
In-Reply-To: <58369E3F.40509@linux.vnet.ibm.com>
On Thu, Nov 24, 2016 at 01:31:03PM +0530, Nayna wrote:
> >>Since the initialization functions are common with the TPM 2.0 event
> >>log support, this patch splits tpm_eventlog.c to have only TPM 1.2
> >>event log parsing logic and moves the init functions into
> >>tpm_eventlog_init.c.
> >
> >I think I'd rather see a tpm_eventlog1.c/tpm_eventlog2.c than this
> >_init thing..
>
> Do you mean tpm_eventlog1.c for TPM 1.2 and tpm_eventlog2.c for TPM 2.0
> event log specific parsing ?
>
> And if so, then which one should have the common functions for TPM 1.2 and
> TPM 2.0?
Leave them in tpm_eventlog.c ..
Jason
next prev parent reply other threads:[~2016-11-24 16:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 17:27 [PATCH v5 0/3] tpm: securityfs support for TPM 2.0 firmware event log Nayna Jain
2016-11-23 17:27 ` [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c Nayna Jain
2016-11-23 19:38 ` Jason Gunthorpe
2016-11-24 8:01 ` Nayna
2016-11-24 16:43 ` Jason Gunthorpe [this message]
2016-11-24 16:50 ` Nayna
2016-11-24 21:01 ` Jarkko Sakkinen
2016-11-25 19:43 ` Jason Gunthorpe
2016-11-23 17:27 ` [PATCH v5 2/3] tpm: enhance read_log_of() to support Physical TPM event log Nayna Jain
2016-11-23 19:37 ` Jason Gunthorpe
2016-11-24 7:53 ` Nayna
2016-11-24 21:06 ` Jarkko Sakkinen
2016-11-23 17:27 ` [PATCH v5 3/3] tpm: add securityfs support for TPM 2.0 firmware " Nayna Jain
2016-11-24 21:10 ` Jarkko Sakkinen
2016-11-25 2:51 ` [tpmdd-devel] " Stefan Berger
2016-11-25 8:11 ` Jarkko Sakkinen
2016-11-26 15:24 ` Jarkko Sakkinen
2016-11-25 19:43 ` Jason Gunthorpe
2016-11-26 12:59 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124164331.GA4930@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox