From: Vinod Koul <vinod.koul@intel.com>
To: Nandor Han <nandor.han@ge.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Senna Tschudin <peter.senna@collabora.com>,
Marek Vasut <marex@denx.de>
Subject: Re: [PATCH 1/1] dmaengine: imx-sdma - correct the dma transfer residue calculation
Date: Fri, 25 Nov 2016 11:06:04 +0530 [thread overview]
Message-ID: <20161125053604.GD2698@localhost> (raw)
In-Reply-To: <0ee9c1d80055ce97cf6cdcc4aa2ce38b293547b7.1476172445.git.nandor.han@ge.com>
On Tue, Oct 11, 2016 at 02:13:41PM +0300, Nandor Han wrote:
> The residue calculation was taking in consideration that dma
> transaction status will be always retrieved in the dma callback
> used to inform that dma transfer is complete. However this is not
> the case for all subsystems that use dma. Some subsystems use a
> timer to check the dma status periodically.
>
> Therefore the calculation was updated and residue is calculated
> accordingly by a) update the residue calculation taking in
> consideration the last used buffer index by using *buf_ptail* variable
> and b) chn_real_count (number of bytes transferred) is initialized to
> zero, when dma channel is created, to avoid using an uninitialized
> value in residue calculation when dma status is checked without
> waiting dma complete event.
Looks to be missed earier, so applying now
Thanks
--
~Vinod
prev parent reply other threads:[~2016-11-25 5:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 11:13 [PATCH 0/1] dmaengine: imx-sdma - fix the dma residue calculation Nandor Han
2016-10-11 11:13 ` [PATCH 1/1] dmaengine: imx-sdma - correct the dma transfer " Nandor Han
2016-10-11 11:35 ` Peter Senna Tschudin
2016-10-16 16:59 ` Marek Vasut
2016-11-25 5:36 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161125053604.GD2698@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=nandor.han@ge.com \
--cc=peter.senna@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox