From: Dan Carpenter <dan.carpenter@oracle.com>
To: Walt Feasel <waltfeasel@gmail.com>
Cc: w.d.hubbs@gmail.com, devel@driverdev.osuosl.org, kirk@reisers.ca,
gregkh@linuxfoundation.org, speakup@linux-speakup.org,
linux-kernel@vger.kernel.org, samuel.thibault@ens-lyon.org,
chris@the-brannons.com
Subject: Re: [PATCH v2 1/5] staging: speakup: synth.c Spaces around operators
Date: Fri, 25 Nov 2016 16:10:29 +0300 [thread overview]
Message-ID: <20161125130946.GE6266@mwanda> (raw)
In-Reply-To: <1479576947-3605-2-git-send-email-waltfeasel@gmail.com>
On Sat, Nov 19, 2016 at 12:35:43PM -0500, Walt Feasel wrote:
> Make suggested checkpatch modification for
> CHECK: spaces preferred around that '+,|,-,/'
>
> Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
> ---
> v2 makes changes to correct for email format patch submission
>
> drivers/staging/speakup/synth.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
> index 54b2f39..9c73a33 100644
> --- a/drivers/staging/speakup/synth.c
> +++ b/drivers/staging/speakup/synth.c
> @@ -1,4 +1,4 @@
> -#include <linux/types.h>
> +w#include <linux/types.h>
This is a mistake.
regards,
dan carpenter
next prev parent reply other threads:[~2016-11-25 13:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 17:35 [PATCH v2 0/5] staging: speakup: synth.c checkpatch modifications Walt Feasel
2016-11-19 17:35 ` [PATCH v2 1/5] staging: speakup: synth.c Spaces around operators Walt Feasel
2016-11-19 18:06 ` kbuild test robot
2016-11-19 18:48 ` kbuild test robot
2016-11-19 19:34 ` [PATCH v3 " Walt Feasel
2016-11-25 13:10 ` Dan Carpenter [this message]
2016-11-19 17:35 ` [PATCH v2 2/5] staging: speakup: synth.c Blank line before } Walt Feasel
2016-11-19 17:35 ` [PATCH v2 3/5] staging: speakup: synth.c Logical continuation Walt Feasel
2016-11-19 17:35 ` [PATCH v2 4/5] staging: speakup: synth.c Comment modifications Walt Feasel
2016-11-19 17:35 ` [PATCH v2 5/5] staging: speakup: synth.c Align parenthesis Walt Feasel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161125130946.GE6266@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
--cc=waltfeasel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox