From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754737AbcKYNtq (ORCPT <rfc822;w@1wt.eu>);
        Fri, 25 Nov 2016 08:49:46 -0500
Received: from mail.kernel.org ([198.145.29.136]:55474 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754283AbcKYNti (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Nov 2016 08:49:38 -0500
Date: Fri, 25 Nov 2016 10:43:24 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Stephane Eranian <eranian@google.com>,
        Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 1/3] perf sched timehist: Mark schedule function in
 callchains
Message-ID: <20161125134324.GA16426@kernel.org>
References: <20161124011114.7102-1-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161124011114.7102-1-namhyung@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Nov 24, 2016 at 10:11:12AM +0900, Namhyung Kim escreveu:
> The sched_switch event always captured from the scheduler function.  So
> it'd be great omit them from the callchain.  This patch marks the
> functions to be omitted by later patch.

I just reorderded this so that after applying 1 I could right away test
it, i.e. 2/3 was applied first.

- Arnaldo
 
> Cc: David Ahern <dsahern@gmail.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/builtin-sched.c | 21 +++++++++++++++++++++
>  tools/perf/util/symbol.h   |  1 +
>  2 files changed, 22 insertions(+)
> 
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 829468defa07..cd14189d3943 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -1965,7 +1965,28 @@ static bool is_idle_sample(struct perf_sched *sched,
>  
>  		return false;
>  	}
> +
>  	callchain_cursor_commit(cursor);
> +
> +	while (true) {
> +		struct callchain_cursor_node *node;
> +		struct symbol *sym;
> +
> +		node = callchain_cursor_current(cursor);
> +		if (node == NULL)
> +			break;
> +
> +		sym = node->sym;
> +		if (sym && sym->name) {
> +			if (!strcmp(sym->name, "schedule") ||
> +			    !strcmp(sym->name, "__schedule") ||
> +			    !strcmp(sym->name, "preempt_schedule"))
> +				sym->ignore = 1;
> +		}
> +
> +		callchain_cursor_advance(cursor);
> +	}
> +
>  	return false;
>  }
>  
> diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
> index dec7e2d44885..1bcbefc0c325 100644
> --- a/tools/perf/util/symbol.h
> +++ b/tools/perf/util/symbol.h
> @@ -58,6 +58,7 @@ struct symbol {
>  	u16		namelen;
>  	u8		binding;
>  	u8		idle:1;
> +	u8		ignore:1;
>  	u8		arch_sym;
>  	char		name[0];
>  };
> -- 
> 2.10.0