[GIT PULL 00/12] perf/core improvements and fixes

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling.

	 I'll continue processing patchsets by Jiri, Namhyung, David, Irina and
others tomorrow.

	I also have to rework the pagefaults patches, as the code it touches
changed lately, will add that NUMA node info you suggested.

- Arnaldo

The following changes since commit ce37f400336a34bb6e72c4700f9dcc2a41ff7163:

  x86: Allow tracing of functions in arch/x86/kernel/rtc.c (2012-10-24 13:14:22 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo

for you to fetch changes up to af3df2cf17f5df079189c3cc88870d28e219496b:

  perf tools: Try to build Documentation when installing (2012-10-24 19:30:48 -0200)

----------------------------------------------------------------
perf/core improvements and fixes

. Align the 'Ok'/'FAILED!' test results in 'perf test.

. Support interrupted syscalls in 'trace'

. Add an event duration column and filter in 'trace'.

. There are references to the man pages in some tools, so try to build
  Documentation when installing, warning the user if that is not possible,
  from Borislav Petkov.

. Give user better message if precise is not supported, from David Ahern.

. Try to find cross-built objdump path by using the session environment
  information in the perf.data file header, from Irina Tirdea, original
  patch and idea by Namhyung Kim.

. Diplays more output on features check for make V=1, so that one can figure
  out what is happening by looking at gcc output, etc. From Jiri Olsa.

. Account the nr_entries in rblist properly, fix by Suzuki K. Poulose.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (7):
      perf tools: Remove noise in python version feature test
      perf test: Align the 'Ok'/'FAILED!' test results
      perf trace: Support interrupted syscalls
      perf trace: Add an event duration column
      perf trace: Add duration filter
      perf tools: Pretty print errno for some more functions
      perf trace: Print the name of a syscall when failing to read its info

Borislav Petkov (1):
      perf tools: Try to build Documentation when installing

David Ahern (1):
      perf tools: Give user better message if precise is not supported

Irina Tirdea (1):
      perf tools: Try to find cross-built objdump path

Jiri Olsa (1):
      perf tools: Diplays more output on features check for make V=1

Suzuki K. Poulose (1):
      Account the nr_entries in rblist properly

 tools/perf/Documentation/Makefile       |   31 +++-
 tools/perf/Documentation/perf-trace.txt |    3 +
 tools/perf/Makefile                     |   53 ++++---
 tools/perf/arch/common.c                |  178 ++++++++++++++++++++++
 tools/perf/arch/common.h                |   10 ++
 tools/perf/builtin-annotate.c           |    7 +
 tools/perf/builtin-record.c             |    5 +
 tools/perf/builtin-report.c             |    7 +
 tools/perf/builtin-test.c               |   18 ++-
 tools/perf/builtin-top.c                |    4 +
 tools/perf/builtin-trace.c              |  250 ++++++++++++++++++++++++++++---
 tools/perf/config/feature-tests.mak     |    5 +-
 tools/perf/config/utilities.mak         |   11 +-
 tools/perf/util/annotate.h              |    1 -
 tools/perf/util/parse-events.c          |    2 +-
 tools/perf/util/rblist.c                |    4 +-
 tools/perf/util/util.h                  |    4 +
 17 files changed, 535 insertions(+), 58 deletions(-)
 create mode 100644 tools/perf/arch/common.c
 create mode 100644 tools/perf/arch/common.h

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling.
> 
> 	 I'll continue processing patchsets by Jiri, Namhyung, David, Irina and
> others tomorrow.
> 
> 	I also have to rework the pagefaults patches, as the code it touches
> changed lately, will add that NUMA node info you suggested.
> 
> - Arnaldo
> 
> The following changes since commit ce37f400336a34bb6e72c4700f9dcc2a41ff7163:
> 
>   x86: Allow tracing of functions in arch/x86/kernel/rtc.c (2012-10-24 13:14:22 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> 
> for you to fetch changes up to af3df2cf17f5df079189c3cc88870d28e219496b:
> 
>   perf tools: Try to build Documentation when installing (2012-10-24 19:30:48 -0200)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes
> 
> . Align the 'Ok'/'FAILED!' test results in 'perf test.
> 
> . Support interrupted syscalls in 'trace'
> 
> . Add an event duration column and filter in 'trace'.
> 
> . There are references to the man pages in some tools, so try to build
>   Documentation when installing, warning the user if that is not possible,
>   from Borislav Petkov.
> 
> . Give user better message if precise is not supported, from David Ahern.
> 
> . Try to find cross-built objdump path by using the session environment
>   information in the perf.data file header, from Irina Tirdea, original
>   patch and idea by Namhyung Kim.
> 
> . Diplays more output on features check for make V=1, so that one can figure
>   out what is happening by looking at gcc output, etc. From Jiri Olsa.
> 
> . Account the nr_entries in rblist properly, fix by Suzuki K. Poulose.
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (7):
>       perf tools: Remove noise in python version feature test
>       perf test: Align the 'Ok'/'FAILED!' test results
>       perf trace: Support interrupted syscalls
>       perf trace: Add an event duration column
>       perf trace: Add duration filter
>       perf tools: Pretty print errno for some more functions
>       perf trace: Print the name of a syscall when failing to read its info
> 
> Borislav Petkov (1):
>       perf tools: Try to build Documentation when installing
> 
> David Ahern (1):
>       perf tools: Give user better message if precise is not supported
> 
> Irina Tirdea (1):
>       perf tools: Try to find cross-built objdump path
> 
> Jiri Olsa (1):
>       perf tools: Diplays more output on features check for make V=1
> 
> Suzuki K. Poulose (1):
>       Account the nr_entries in rblist properly
> 
>  tools/perf/Documentation/Makefile       |   31 +++-
>  tools/perf/Documentation/perf-trace.txt |    3 +
>  tools/perf/Makefile                     |   53 ++++---
>  tools/perf/arch/common.c                |  178 ++++++++++++++++++++++
>  tools/perf/arch/common.h                |   10 ++
>  tools/perf/builtin-annotate.c           |    7 +
>  tools/perf/builtin-record.c             |    5 +
>  tools/perf/builtin-report.c             |    7 +
>  tools/perf/builtin-test.c               |   18 ++-
>  tools/perf/builtin-top.c                |    4 +
>  tools/perf/builtin-trace.c              |  250 ++++++++++++++++++++++++++++---
>  tools/perf/config/feature-tests.mak     |    5 +-
>  tools/perf/config/utilities.mak         |   11 +-
>  tools/perf/util/annotate.h              |    1 -
>  tools/perf/util/parse-events.c          |    2 +-
>  tools/perf/util/rblist.c                |    4 +-
>  tools/perf/util/util.h                  |    4 +
>  17 files changed, 535 insertions(+), 58 deletions(-)
>  create mode 100644 tools/perf/arch/common.c
>  create mode 100644 tools/perf/arch/common.h

Pulled, thanks a lot Arnado!

	Ingo

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 0ed1e0bee0b2c6b4cc6d7a63787739a9d3ac8aa8:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2013-11-30 13:42:48 +0100)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo

for you to fetch changes up to f885037ef6400ce4a4c122a88845dea2c9bca256:

  perf trace: Honour -m option (2013-12-02 16:29:40 -0300)

----------------------------------------------------------------
perf/tools improvements and fixes:

. Honour -m option in 'trace', the tool was offering the option to
  set the mmap size, but wasn't using it when doing the actual mmap
  on the events file descriptors, fix from Jiri Olsa.

. Correct the message in feature-libnuma checking, swowing the right
  devel package names for various distros, from Dongsheng Yang.

. Polish 'readn' function and introduce its counterpart, 'writen', from
  Jiri Olsa.

. Start moving timechart state from global variables to a 'perf_tool' derived
  'timechart' struct.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (4):
      perf timechart: Introduce tool struct
      perf timechart: Move all_data per_pid list to 'struct timechart'
      perf timechart: Move power_events list to 'struct timechart'
      perf timechart: Move wake_events list to 'struct timechart'

Dongsheng Yang (1):
      perf tools: Correct the message in feature-libnuma checking.

Jiri Olsa (7):
      perf record: Unify data output code into perf_record__write function
      perf tools: Use correct return type for readn function
      perf tools: Fine tune readn function
      perf tools: Add writen function
      perf tools: Add perf_data_file__write interface
      perf tools: Include test-stackprotector-all.c in test-all
      perf trace: Honour -m option

 tools/perf/builtin-record.c                 |  20 +-
 tools/perf/builtin-timechart.c              | 364 +++++++++++++++-------------
 tools/perf/builtin-trace.c                  |   2 +-
 tools/perf/config/Makefile                  |   2 +-
 tools/perf/config/feature-checks/test-all.c |   5 +
 tools/perf/util/data.c                      |   6 +
 tools/perf/util/data.h                      |  14 +-
 tools/perf/util/header.c                    |  18 +-
 tools/perf/util/session.c                   |   2 +-
 tools/perf/util/util.c                      |  32 ++-
 tools/perf/util/util.h                      |   3 +-
 11 files changed, 256 insertions(+), 212 deletions(-)

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> 
> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit 0ed1e0bee0b2c6b4cc6d7a63787739a9d3ac8aa8:
> 
>   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2013-11-30 13:42:48 +0100)
> 
> are available in the git repository at:
> 
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> 
> for you to fetch changes up to f885037ef6400ce4a4c122a88845dea2c9bca256:
> 
>   perf trace: Honour -m option (2013-12-02 16:29:40 -0300)
> 
> ----------------------------------------------------------------
> perf/tools improvements and fixes:
> 
> . Honour -m option in 'trace', the tool was offering the option to
>   set the mmap size, but wasn't using it when doing the actual mmap
>   on the events file descriptors, fix from Jiri Olsa.
> 
> . Correct the message in feature-libnuma checking, swowing the right
>   devel package names for various distros, from Dongsheng Yang.
> 
> . Polish 'readn' function and introduce its counterpart, 'writen', from
>   Jiri Olsa.
> 
> . Start moving timechart state from global variables to a 'perf_tool' derived
>   'timechart' struct.
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (4):
>       perf timechart: Introduce tool struct
>       perf timechart: Move all_data per_pid list to 'struct timechart'
>       perf timechart: Move power_events list to 'struct timechart'
>       perf timechart: Move wake_events list to 'struct timechart'
> 
> Dongsheng Yang (1):
>       perf tools: Correct the message in feature-libnuma checking.
> 
> Jiri Olsa (7):
>       perf record: Unify data output code into perf_record__write function
>       perf tools: Use correct return type for readn function
>       perf tools: Fine tune readn function
>       perf tools: Add writen function
>       perf tools: Add perf_data_file__write interface
>       perf tools: Include test-stackprotector-all.c in test-all
>       perf trace: Honour -m option
> 
>  tools/perf/builtin-record.c                 |  20 +-
>  tools/perf/builtin-timechart.c              | 364 +++++++++++++++-------------
>  tools/perf/builtin-trace.c                  |   2 +-
>  tools/perf/config/Makefile                  |   2 +-
>  tools/perf/config/feature-checks/test-all.c |   5 +
>  tools/perf/util/data.c                      |   6 +
>  tools/perf/util/data.h                      |  14 +-
>  tools/perf/util/header.c                    |  18 +-
>  tools/perf/util/session.c                   |   2 +-
>  tools/perf/util/util.c                      |  32 ++-
>  tools/perf/util/util.h                      |   3 +-
>  11 files changed, 256 insertions(+), 212 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo

for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:

  perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)

----------------------------------------------------------------
perf/core improvements and fixes

. Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)

. Fix build race in the generation of bison files (Jiri Olsa)

. Further streamline the feature detection display, trimming it a bit to
  show just the libraries detected, using VF=1 gets a more verbose output,
  showing the less interesting feature checks as well (Jiri Olsa).

. Check compatible symtab type before loading dso (Namhyung Kim)

. Check return value of filename__read_debuglink() (Stephane Eranian)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
      perf tools: Warn the user about how to enable libunwind support

Jiri Olsa (9):
      perf tests: Fix *.o make tests
      perf tests: Add pmu-bison.o make test
      perf tools: Fix bison OUTPUT directories dependency
      perf tools: Factor features display code
      perf tools: Add variable display for VF make output
      perf tools: Add feature check for libdw dwarf unwind
      perf tools: Add libdw DWARF post unwind support
      perf tools: Setup default dwarf post unwinder
      perf tests: Add NO_LIBDW_DWARF_UNWIND make test

Namhyung Kim (1):
      perf symbols: Check compatible symtab type before loading dso

Stephane Eranian (1):
      perf symbols: Check return value of filename__read_debuglink()

 tools/perf/Makefile.perf                           |  24 ++-
 tools/perf/arch/x86/Makefile                       |   5 +
 tools/perf/arch/x86/util/unwind-libdw.c            |  51 +++++
 tools/perf/config/Makefile                         | 232 +++++++++++++++------
 tools/perf/config/feature-checks/Makefile          |   6 +-
 tools/perf/config/feature-checks/test-all.c        |   5 +
 .../feature-checks/test-libdw-dwarf-unwind.c       |  13 ++
 tools/perf/tests/make                              |  25 ++-
 tools/perf/util/dso.c                              |   4 +-
 tools/perf/util/symbol-elf.c                       |   2 +
 tools/perf/util/symbol.c                           |  61 +++++-
 tools/perf/util/unwind-libdw.c                     | 210 +++++++++++++++++++
 tools/perf/util/unwind-libdw.h                     |  21 ++
 13 files changed, 569 insertions(+), 90 deletions(-)
 create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
 create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
 create mode 100644 tools/perf/util/unwind-libdw.c
 create mode 100644 tools/perf/util/unwind-libdw.h

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> 
> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:
> 
>   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)
> 
> are available in the git repository at:
> 
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> 
> for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:
> 
>   perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes
> 
> . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)
> 
> . Fix build race in the generation of bison files (Jiri Olsa)
> 
> . Further streamline the feature detection display, trimming it a bit to
>   show just the libraries detected, using VF=1 gets a more verbose output,
>   showing the less interesting feature checks as well (Jiri Olsa).
> 
> . Check compatible symtab type before loading dso (Namhyung Kim)
> 
> . Check return value of filename__read_debuglink() (Stephane Eranian)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
>       perf tools: Warn the user about how to enable libunwind support
> 
> Jiri Olsa (9):
>       perf tests: Fix *.o make tests
>       perf tests: Add pmu-bison.o make test
>       perf tools: Fix bison OUTPUT directories dependency
>       perf tools: Factor features display code
>       perf tools: Add variable display for VF make output
>       perf tools: Add feature check for libdw dwarf unwind
>       perf tools: Add libdw DWARF post unwind support
>       perf tools: Setup default dwarf post unwinder
>       perf tests: Add NO_LIBDW_DWARF_UNWIND make test
> 
> Namhyung Kim (1):
>       perf symbols: Check compatible symtab type before loading dso
> 
> Stephane Eranian (1):
>       perf symbols: Check return value of filename__read_debuglink()
> 
>  tools/perf/Makefile.perf                           |  24 ++-
>  tools/perf/arch/x86/Makefile                       |   5 +
>  tools/perf/arch/x86/util/unwind-libdw.c            |  51 +++++
>  tools/perf/config/Makefile                         | 232 +++++++++++++++------
>  tools/perf/config/feature-checks/Makefile          |   6 +-
>  tools/perf/config/feature-checks/test-all.c        |   5 +
>  .../feature-checks/test-libdw-dwarf-unwind.c       |  13 ++
>  tools/perf/tests/make                              |  25 ++-
>  tools/perf/util/dso.c                              |   4 +-
>  tools/perf/util/symbol-elf.c                       |   2 +
>  tools/perf/util/symbol.c                           |  61 +++++-
>  tools/perf/util/unwind-libdw.c                     | 210 +++++++++++++++++++
>  tools/perf/util/unwind-libdw.h                     |  21 ++
>  13 files changed, 569 insertions(+), 90 deletions(-)
>  create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
>  create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
>  create mode 100644 tools/perf/util/unwind-libdw.c
>  create mode 100644 tools/perf/util/unwind-libdw.h

Pulled, thanks a lot Arnaldo!

Btw., the build output looks weird now - on a system that used to pass 
all feature tests there's this output:

  BUILD:   Doing 'make -j12' parallel build
config/Makefile:288: No libdw DWARF unwind found, Please install 
elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR

Auto-detecting system features:
...                         dwarf: [ on  ]
...                         glibc: [ on  ]
...                          gtk2: [ on  ]
...                      libaudit: [ on  ]
...                        libbfd: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                      libslang: [ on  ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ OFF ]
...     DWARF post unwind library: libunwind

but:

   Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version

Also, the information content of this line is unclear to me:

...     DWARF post unwind library: libunwind


what does that line want to tell?

Thanks,

	Ingo

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Jiri Olsa]

On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
> 
> * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> 
> > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> > 
> > Hi Ingo,
> > 
> > 	Please consider pulling,
> > 
> > - Arnaldo
> > 
> > The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:
> > 
> >   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)
> > 
> > are available in the git repository at:
> > 
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> > 
> > for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:
> > 
> >   perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)
> > 
> > ----------------------------------------------------------------
> > perf/core improvements and fixes
> > 
> > . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)
> > 
> > . Fix build race in the generation of bison files (Jiri Olsa)
> > 
> > . Further streamline the feature detection display, trimming it a bit to
> >   show just the libraries detected, using VF=1 gets a more verbose output,
> >   showing the less interesting feature checks as well (Jiri Olsa).
> > 
> > . Check compatible symtab type before loading dso (Namhyung Kim)
> > 
> > . Check return value of filename__read_debuglink() (Stephane Eranian)
> > 
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > 
> > ----------------------------------------------------------------
> > Arnaldo Carvalho de Melo (1):
> >       perf tools: Warn the user about how to enable libunwind support
> > 
> > Jiri Olsa (9):
> >       perf tests: Fix *.o make tests
> >       perf tests: Add pmu-bison.o make test
> >       perf tools: Fix bison OUTPUT directories dependency
> >       perf tools: Factor features display code
> >       perf tools: Add variable display for VF make output
> >       perf tools: Add feature check for libdw dwarf unwind
> >       perf tools: Add libdw DWARF post unwind support
> >       perf tools: Setup default dwarf post unwinder
> >       perf tests: Add NO_LIBDW_DWARF_UNWIND make test
> > 
> > Namhyung Kim (1):
> >       perf symbols: Check compatible symtab type before loading dso
> > 
> > Stephane Eranian (1):
> >       perf symbols: Check return value of filename__read_debuglink()
> > 
> >  tools/perf/Makefile.perf                           |  24 ++-
> >  tools/perf/arch/x86/Makefile                       |   5 +
> >  tools/perf/arch/x86/util/unwind-libdw.c            |  51 +++++
> >  tools/perf/config/Makefile                         | 232 +++++++++++++++------
> >  tools/perf/config/feature-checks/Makefile          |   6 +-
> >  tools/perf/config/feature-checks/test-all.c        |   5 +
> >  .../feature-checks/test-libdw-dwarf-unwind.c       |  13 ++
> >  tools/perf/tests/make                              |  25 ++-
> >  tools/perf/util/dso.c                              |   4 +-
> >  tools/perf/util/symbol-elf.c                       |   2 +
> >  tools/perf/util/symbol.c                           |  61 +++++-
> >  tools/perf/util/unwind-libdw.c                     | 210 +++++++++++++++++++
> >  tools/perf/util/unwind-libdw.h                     |  21 ++
> >  13 files changed, 569 insertions(+), 90 deletions(-)
> >  create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
> >  create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
> >  create mode 100644 tools/perf/util/unwind-libdw.c
> >  create mode 100644 tools/perf/util/unwind-libdw.h
> 
> Pulled, thanks a lot Arnaldo!
> 
> Btw., the build output looks weird now - on a system that used to pass 
> all feature tests there's this output:
> 
>   BUILD:   Doing 'make -j12' parallel build
> config/Makefile:288: No libdw DWARF unwind found, Please install 
> elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
> 
> Auto-detecting system features:
> ...                         dwarf: [ on  ]
> ...                         glibc: [ on  ]
> ...                          gtk2: [ on  ]
> ...                      libaudit: [ on  ]
> ...                        libbfd: [ on  ]
> ...                        libelf: [ on  ]
> ...                       libnuma: [ on  ]
> ...                       libperl: [ on  ]
> ...                     libpython: [ on  ]
> ...                      libslang: [ on  ]
> ...                     libunwind: [ on  ]
> ...            libdw-dwarf-unwind: [ OFF ]
> ...     DWARF post unwind library: libunwind
> 
> but:
> 
>    Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version
> 
> Also, the information content of this line is unclear to me:
> 
> ...     DWARF post unwind library: libunwind
> 
> 
> what does that line want to tell?

this tells what DWARF unwind library is compiled
in.. 'libunwind' in this case

the other choice is 'libdw', which was not detected
in your case (and thats what the 1st message tells you)

we discussed with Arnaldo, that we would not display warnings
for missing features by default.. only tell that there are
missing features and display them for verbose (VF=1) output

jirka

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Jiri Olsa]

On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
> 
> * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> 
> > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> > 
> > Hi Ingo,
> > 
> > 	Please consider pulling,
> > 
> > - Arnaldo
> > 
> > The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:
> > 
> >   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)
> > 
> > are available in the git repository at:
> > 
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> > 
> > for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:
> > 
> >   perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)
> > 
> > ----------------------------------------------------------------
> > perf/core improvements and fixes
> > 
> > . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)
> > 
> > . Fix build race in the generation of bison files (Jiri Olsa)
> > 
> > . Further streamline the feature detection display, trimming it a bit to
> >   show just the libraries detected, using VF=1 gets a more verbose output,
> >   showing the less interesting feature checks as well (Jiri Olsa).
> > 
> > . Check compatible symtab type before loading dso (Namhyung Kim)
> > 
> > . Check return value of filename__read_debuglink() (Stephane Eranian)
> > 
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > 
> > ----------------------------------------------------------------
> > Arnaldo Carvalho de Melo (1):
> >       perf tools: Warn the user about how to enable libunwind support
> > 
> > Jiri Olsa (9):
> >       perf tests: Fix *.o make tests
> >       perf tests: Add pmu-bison.o make test
> >       perf tools: Fix bison OUTPUT directories dependency
> >       perf tools: Factor features display code
> >       perf tools: Add variable display for VF make output
> >       perf tools: Add feature check for libdw dwarf unwind
> >       perf tools: Add libdw DWARF post unwind support
> >       perf tools: Setup default dwarf post unwinder
> >       perf tests: Add NO_LIBDW_DWARF_UNWIND make test
> > 
> > Namhyung Kim (1):
> >       perf symbols: Check compatible symtab type before loading dso
> > 
> > Stephane Eranian (1):
> >       perf symbols: Check return value of filename__read_debuglink()
> > 
> >  tools/perf/Makefile.perf                           |  24 ++-
> >  tools/perf/arch/x86/Makefile                       |   5 +
> >  tools/perf/arch/x86/util/unwind-libdw.c            |  51 +++++
> >  tools/perf/config/Makefile                         | 232 +++++++++++++++------
> >  tools/perf/config/feature-checks/Makefile          |   6 +-
> >  tools/perf/config/feature-checks/test-all.c        |   5 +
> >  .../feature-checks/test-libdw-dwarf-unwind.c       |  13 ++
> >  tools/perf/tests/make                              |  25 ++-
> >  tools/perf/util/dso.c                              |   4 +-
> >  tools/perf/util/symbol-elf.c                       |   2 +
> >  tools/perf/util/symbol.c                           |  61 +++++-
> >  tools/perf/util/unwind-libdw.c                     | 210 +++++++++++++++++++
> >  tools/perf/util/unwind-libdw.h                     |  21 ++
> >  13 files changed, 569 insertions(+), 90 deletions(-)
> >  create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
> >  create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
> >  create mode 100644 tools/perf/util/unwind-libdw.c
> >  create mode 100644 tools/perf/util/unwind-libdw.h
> 
> Pulled, thanks a lot Arnaldo!
> 
> Btw., the build output looks weird now - on a system that used to pass 
> all feature tests there's this output:
> 
>   BUILD:   Doing 'make -j12' parallel build
> config/Makefile:288: No libdw DWARF unwind found, Please install 
> elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
> 
> Auto-detecting system features:
> ...                         dwarf: [ on  ]
> ...                         glibc: [ on  ]
> ...                          gtk2: [ on  ]
> ...                      libaudit: [ on  ]
> ...                        libbfd: [ on  ]
> ...                        libelf: [ on  ]
> ...                       libnuma: [ on  ]
> ...                       libperl: [ on  ]
> ...                     libpython: [ on  ]
> ...                      libslang: [ on  ]
> ...                     libunwind: [ on  ]
> ...            libdw-dwarf-unwind: [ OFF ]
> ...     DWARF post unwind library: libunwind
> 
> but:
> 
>    Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version

forgot.. remote unwind in libdw is supported from version 0.158,
which I guess wasn't updated in FC19 yet

jirka

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Jiri Olsa <jolsa@redhat.com> wrote:

> On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
> > 
> > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> > 
> > > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> > > 
> > > Hi Ingo,
> > > 
> > > 	Please consider pulling,
> > > 
> > > - Arnaldo
> > > 
> > > The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:
> > > 
> > >   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)
> > > 
> > > are available in the git repository at:
> > > 
> > > 
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> > > 
> > > for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:
> > > 
> > >   perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)
> > > 
> > > ----------------------------------------------------------------
> > > perf/core improvements and fixes
> > > 
> > > . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)
> > > 
> > > . Fix build race in the generation of bison files (Jiri Olsa)
> > > 
> > > . Further streamline the feature detection display, trimming it a bit to
> > >   show just the libraries detected, using VF=1 gets a more verbose output,
> > >   showing the less interesting feature checks as well (Jiri Olsa).
> > > 
> > > . Check compatible symtab type before loading dso (Namhyung Kim)
> > > 
> > > . Check return value of filename__read_debuglink() (Stephane Eranian)
> > > 
> > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > > 
> > > ----------------------------------------------------------------
> > > Arnaldo Carvalho de Melo (1):
> > >       perf tools: Warn the user about how to enable libunwind support
> > > 
> > > Jiri Olsa (9):
> > >       perf tests: Fix *.o make tests
> > >       perf tests: Add pmu-bison.o make test
> > >       perf tools: Fix bison OUTPUT directories dependency
> > >       perf tools: Factor features display code
> > >       perf tools: Add variable display for VF make output
> > >       perf tools: Add feature check for libdw dwarf unwind
> > >       perf tools: Add libdw DWARF post unwind support
> > >       perf tools: Setup default dwarf post unwinder
> > >       perf tests: Add NO_LIBDW_DWARF_UNWIND make test
> > > 
> > > Namhyung Kim (1):
> > >       perf symbols: Check compatible symtab type before loading dso
> > > 
> > > Stephane Eranian (1):
> > >       perf symbols: Check return value of filename__read_debuglink()
> > > 
> > >  tools/perf/Makefile.perf                           |  24 ++-
> > >  tools/perf/arch/x86/Makefile                       |   5 +
> > >  tools/perf/arch/x86/util/unwind-libdw.c            |  51 +++++
> > >  tools/perf/config/Makefile                         | 232 +++++++++++++++------
> > >  tools/perf/config/feature-checks/Makefile          |   6 +-
> > >  tools/perf/config/feature-checks/test-all.c        |   5 +
> > >  .../feature-checks/test-libdw-dwarf-unwind.c       |  13 ++
> > >  tools/perf/tests/make                              |  25 ++-
> > >  tools/perf/util/dso.c                              |   4 +-
> > >  tools/perf/util/symbol-elf.c                       |   2 +
> > >  tools/perf/util/symbol.c                           |  61 +++++-
> > >  tools/perf/util/unwind-libdw.c                     | 210 +++++++++++++++++++
> > >  tools/perf/util/unwind-libdw.h                     |  21 ++
> > >  13 files changed, 569 insertions(+), 90 deletions(-)
> > >  create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
> > >  create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
> > >  create mode 100644 tools/perf/util/unwind-libdw.c
> > >  create mode 100644 tools/perf/util/unwind-libdw.h
> > 
> > Pulled, thanks a lot Arnaldo!
> > 
> > Btw., the build output looks weird now - on a system that used to pass 
> > all feature tests there's this output:
> > 
> >   BUILD:   Doing 'make -j12' parallel build
> > config/Makefile:288: No libdw DWARF unwind found, Please install 
> > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
> > 
> > Auto-detecting system features:
> > ...                         dwarf: [ on  ]
> > ...                         glibc: [ on  ]
> > ...                          gtk2: [ on  ]
> > ...                      libaudit: [ on  ]
> > ...                        libbfd: [ on  ]
> > ...                        libelf: [ on  ]
> > ...                       libnuma: [ on  ]
> > ...                       libperl: [ on  ]
> > ...                     libpython: [ on  ]
> > ...                      libslang: [ on  ]
> > ...                     libunwind: [ on  ]
> > ...            libdw-dwarf-unwind: [ OFF ]
> > ...     DWARF post unwind library: libunwind
> > 
> > but:
> > 
> >    Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version
> > 
> > Also, the information content of this line is unclear to me:
> > 
> > ...     DWARF post unwind library: libunwind
> > 
> > 
> > what does that line want to tell?
> 
> this tells what DWARF unwind library is compiled
> in.. 'libunwind' in this case

So my (stylistic) complaint is that it's really reading weird in a 
table generated with the following purpose:

      Auto-detecting system features:

Also, we already know that libunwind is present, because just in the 
line before it, it says:

    ...                     libunwind: [ on  ]

So it's doubly confusing. How about not displaying that line at all? 
Is there a strong reason to not keep 'OFF' messages on a single line?

> the other choice is 'libdw', which was not detected in your case 
> (and thats what the 1st message tells you)
> 
> we discussed with Arnaldo, that we would not display warnings for 
> missing features by default.. only tell that there are missing 
> features and display them for verbose (VF=1) output

That's probably a good plan. I'd suggest the following 'short log' for 
failures:

     # Auto-detecting system features: 2 libraries are missing. Try 'make VF=1' for a verbose list.

I.e. that way people can notice if the count goes up or down after an 
update. Also, that too should be a single line, so that it does not 
spam people.

Thanks,

	Ingo

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Jiri Olsa]

On Thu, Feb 27, 2014 at 01:30:52PM +0100, Ingo Molnar wrote:
> 
> * Jiri Olsa <jolsa@redhat.com> wrote:
> 
> > On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
> > > 
> > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> > > 
> > > > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> > > > 

SNIP

> > > Pulled, thanks a lot Arnaldo!
> > > 
> > > Btw., the build output looks weird now - on a system that used to pass 
> > > all feature tests there's this output:
> > > 
> > >   BUILD:   Doing 'make -j12' parallel build
> > > config/Makefile:288: No libdw DWARF unwind found, Please install 
> > > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
> > > 
> > > Auto-detecting system features:
> > > ...                         dwarf: [ on  ]
> > > ...                         glibc: [ on  ]
> > > ...                          gtk2: [ on  ]
> > > ...                      libaudit: [ on  ]
> > > ...                        libbfd: [ on  ]
> > > ...                        libelf: [ on  ]
> > > ...                       libnuma: [ on  ]
> > > ...                       libperl: [ on  ]
> > > ...                     libpython: [ on  ]
> > > ...                      libslang: [ on  ]
> > > ...                     libunwind: [ on  ]
> > > ...            libdw-dwarf-unwind: [ OFF ]
> > > ...     DWARF post unwind library: libunwind
> > > 
> > > but:
> > > 
> > >    Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version
> > > 
> > > Also, the information content of this line is unclear to me:
> > > 
> > > ...     DWARF post unwind library: libunwind
> > > 
> > > 
> > > what does that line want to tell?
> > 
> > this tells what DWARF unwind library is compiled
> > in.. 'libunwind' in this case
> 
> So my (stylistic) complaint is that it's really reading weird in a 
> table generated with the following purpose:
> 
>       Auto-detecting system features:
> 
> Also, we already know that libunwind is present, because just in the 
> line before it, it says:
> 
>     ...                     libunwind: [ on  ]
> 
> So it's doubly confusing. How about not displaying that line at all? 
> Is there a strong reason to not keep 'OFF' messages on a single line?

well, on/OFF lines are only about detecting libs

this line:
'DWARF post unwind library: libunwind'

is about telling which one goes in.. could be you have both
libraries detected and need to choose one or keep default

> 
> > the other choice is 'libdw', which was not detected in your case 
> > (and thats what the 1st message tells you)
> > 
> > we discussed with Arnaldo, that we would not display warnings for 
> > missing features by default.. only tell that there are missing 
> > features and display them for verbose (VF=1) output
> 
> That's probably a good plan. I'd suggest the following 'short log' for 
> failures:
> 
>      # Auto-detecting system features: 2 libraries are missing. Try 'make VF=1' for a verbose list.
> 
> I.e. that way people can notice if the count goes up or down after an 
> update. Also, that too should be a single line, so that it does not 
> spam people.

ook

jirka

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Jiri Olsa <jolsa@redhat.com> wrote:

> On Thu, Feb 27, 2014 at 01:30:52PM +0100, Ingo Molnar wrote:
> > 
> > * Jiri Olsa <jolsa@redhat.com> wrote:
> > 
> > > On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
> > > > 
> > > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> > > > 
> > > > > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> > > > > 
> 
> SNIP
> 
> > > > Pulled, thanks a lot Arnaldo!
> > > > 
> > > > Btw., the build output looks weird now - on a system that used to pass 
> > > > all feature tests there's this output:
> > > > 
> > > >   BUILD:   Doing 'make -j12' parallel build
> > > > config/Makefile:288: No libdw DWARF unwind found, Please install 
> > > > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
> > > > 
> > > > Auto-detecting system features:
> > > > ...                         dwarf: [ on  ]
> > > > ...                         glibc: [ on  ]
> > > > ...                          gtk2: [ on  ]
> > > > ...                      libaudit: [ on  ]
> > > > ...                        libbfd: [ on  ]
> > > > ...                        libelf: [ on  ]
> > > > ...                       libnuma: [ on  ]
> > > > ...                       libperl: [ on  ]
> > > > ...                     libpython: [ on  ]
> > > > ...                      libslang: [ on  ]
> > > > ...                     libunwind: [ on  ]
> > > > ...            libdw-dwarf-unwind: [ OFF ]
> > > > ...     DWARF post unwind library: libunwind
> > > > 
> > > > but:
> > > > 
> > > >    Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version
> > > > 
> > > > Also, the information content of this line is unclear to me:
> > > > 
> > > > ...     DWARF post unwind library: libunwind
> > > > 
> > > > 
> > > > what does that line want to tell?
> > > 
> > > this tells what DWARF unwind library is compiled
> > > in.. 'libunwind' in this case
> > 
> > So my (stylistic) complaint is that it's really reading weird in a 
> > table generated with the following purpose:
> > 
> >       Auto-detecting system features:
> > 
> > Also, we already know that libunwind is present, because just in the 
> > line before it, it says:
> > 
> >     ...                     libunwind: [ on  ]
> > 
> > So it's doubly confusing. How about not displaying that line at all? 
> > Is there a strong reason to not keep 'OFF' messages on a single line?
> 
> well, on/OFF lines are only about detecting libs
> 
> this line:
> 'DWARF post unwind library: libunwind'
> 
> is about telling which one goes in.. could be you have both
> libraries detected and need to choose one or keep default

Okay - but that is not at all clear from the output.

Thanks,

	Ingo

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 4e6e311e596eadba30d4f56f64eae7d45611a01c:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-11-20 08:32:01 +0100)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to 1d9e446b91e182055d874fbb30150aad479a4981:

  perf tools: Add snapshot format file parsing (2014-11-24 18:03:51 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Callchain improvements from Andi Kleen including:
  * Enable printing the srcline in the history
  * Make get_srcline fall back to sym+offset

- Allow to force redirect pr_debug to stderr. (Andi Kleen)

- TUI hist_entry browser fixes, including showing missing overhead
  value for first level callchain. Detected comparing the output of
  --stdio/--gui (that matched) with --tui, that had this problem. (Namhyung Kim)

- Fix segfault due to invalid kernel dso access (Namhyung Kim)

Infrastructure:

- Move bfd_demangle stubbing to its only user (Arnaldo Carvalho de Melo)

- 'perf stat' refactorings, moving stuff from it to evsel.c to use in
  per-pkg/snapshot format changes (Jiri Olsa)

- Add per-pkg format file parsing (Matt Fleming)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Andi Kleen (3):
      perf callchain: Enable printing the srcline in the history
      perf callchain: Make get_srcline fall back to sym+offset
      perf tools: Allow to force redirect pr_debug to stderr.

Arnaldo Carvalho de Melo (1):
      perf symbols: Move bfd_demangle stubbing to its only user

Jiri Olsa (4):
      perf evsel: Introduce perf_evsel__compute_deltas function
      perf evsel: Introduce perf_counts_values__scale function
      perf evsel: Introduce perf_evsel__read_cb function
      perf tools: Add snapshot format file parsing

Matt Fleming (1):
      perf tools: Add per-pkg format file parsing

Namhyung Kim (3):
      perf hists browser: Print overhead percent value for first-level callchain
      perf tools: Collapse first level callchain entry if it has sibling
      perf tools: Fix segfault due to invalid kernel dso access

 tools/perf/ui/browsers/hists.c | 25 +++++++++++---
 tools/perf/util/annotate.c     |  2 +-
 tools/perf/util/callchain.c    | 12 ++++++-
 tools/perf/util/callchain.h    |  1 +
 tools/perf/util/debug.c        |  4 ++-
 tools/perf/util/evsel.c        | 72 +++++++++++++++++++++++-----------------
 tools/perf/util/evsel.h        | 15 +++++++++
 tools/perf/util/machine.c      |  4 +--
 tools/perf/util/map.c          |  2 +-
 tools/perf/util/parse-events.c |  2 ++
 tools/perf/util/pmu.c          | 74 +++++++++++++++++++++++++++++++++++-------
 tools/perf/util/pmu.h          |  4 +++
 tools/perf/util/sort.c         |  6 ++--
 tools/perf/util/srcline.c      | 15 +++++++--
 tools/perf/util/symbol-elf.c   | 21 ++++++++++++
 tools/perf/util/symbol.h       | 21 ------------
 tools/perf/util/util.h         |  4 ++-
 17 files changed, 205 insertions(+), 79 deletions(-)

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling, way more to process in the next days, with the
patchkit for eBPF looking good, perf stat stuff from Jiri and some new hardware
stuff from Andi.

- Arnaldo

The following changes since commit 75f80859b130a1cc84e59e71295ce2dd51fe1c81:

  perf/x86/intel/pebs: Robustify PEBS buffer drain (2015-08-04 10:17:01 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to f151f53aa4f54a647353e1935e4c6cef7f094dd4:

  perf tools: Fix build errors with mipsel-linux-uclibc compiler (2015-08-05 16:56:16 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

New features:

- Deref sys_enter pointer args with contents from probe:vfs_getname, showing
  pathnames instead of pointers in many syscalls in 'perf trace' (Arnaldo Carvalho de Melo)

- Make 'perf trace' write to stderr by default, just like 'strace' (Milian Woff)

Infrastructure:

- color_vfprintf() fixes (Andi Kleen, Jiri Olsa)

- Allow enabling/disabling PERF_SAMPLE_TIME per event (Kan Liang)

- Fix build errors with mipsel-linux-uclibc compiler (Petri Gynther)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Andi Kleen (1):
      perf tools: Do not include escape sequences in color_vfprintf return

Arnaldo Carvalho de Melo (6):
      perf script: No tracepoints? Don't call libtraceevent.
      perf trace: Do not show syscall tracepoint filter in the --no-syscalls case
      perf trace: Remember if the vfs_getname tracepoint/kprobe is in place
      perf trace: Use a constant for the syscall formatting buffer
      perf trace: Deref sys_enter pointer args with contents from probe:vfs_getname
      perf trace: Use vfs_getname syscall arg beautifier in more syscalls

Jiri Olsa (1):
      perf tools: Remove trail argument to color vsprintf

Kan Liang (2):
      perf tools: Per-event time support
      perf tools: Refine parse/config callchain functions

Milian Wolff (1):
      perf trace: Write to stderr by default

Petri Gynther (1):
      perf tools: Fix build errors with mipsel-linux-uclibc compiler

 tools/build/feature/test-glibc.c         |  11 ++
 tools/perf/Documentation/perf-record.txt |   4 +-
 tools/perf/builtin-record.c              |   2 +-
 tools/perf/builtin-script.c              |   3 +-
 tools/perf/builtin-trace.c               | 175 +++++++++++++++++++++++++++----
 tools/perf/util/callchain.c              |  14 +--
 tools/perf/util/callchain.h              |   2 +-
 tools/perf/util/cloexec.h                |   2 +-
 tools/perf/util/color.c                  |  21 +---
 tools/perf/util/color.h                  |   1 -
 tools/perf/util/evsel.c                  |  25 +++--
 tools/perf/util/evsel.h                  |   2 +
 tools/perf/util/parse-events.c           |  12 +++
 tools/perf/util/parse-events.h           |   1 +
 tools/perf/util/parse-events.l           |   1 +
 tools/perf/util/pmu.c                    |   2 +-
 16 files changed, 220 insertions(+), 58 deletions(-)

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 4341801873e23bbecee76dabb7c111e3693b900f:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-25 09:40:31 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to 443f8c75e8d58d394b0e65b47e02e5cd8ed32b41:

  perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore (2015-10-28 11:19:30 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Enable per-event perf_event_attr.inherit setting by config terms, i.e.
  this becomes possible:

      $ perf record -e cycles/inherit/ -e instructions/no-inherit/

  This affects the default, that can be changed globally using the --no-inherit
  option.

  This fine grained control appeared in the eBPF patchkit, but this added
  flexibility may end up being useful in other scenarios (Wang Nan)

- Setup pager when printing usage and help, we have long lists of options,
  better use the pager like we do with normal tooling output, i.e. when needed,
  and including any error messages in the paged output (Namhyung Kim)

- Search for more options when passing args to -h, e.g.: (Arnaldo Carvalho de Melo)

  $ perf report -h interface

   Usage: perf report [<options>]

    --gtk    Use the GTK2 interface
    --stdio  Use the stdio interface
    --tui    Use the TUI interface

- Fix reading separate debuginfo files based on a build-id, problem
  found on a Debian system (Dima Kogan)

- Fix endless loop when splitting kallsyms symbols per section for
  handling kcore files, problem found on a s390x system (Jiri Olsa)

Infrastructure:

- Prep work for the 'perf stat record' work that will allow generating
  perf.data files with counting data in addition to the sampling mode
  we have now (Jiri Olsa)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
      perf tools: Search for more options when passing args to -h

Dima Kogan (2):
      perf symbols: Fix type error when reading a build-id
      perf symbols: we can now read separate debug-info files based on a build ID

Jiri Olsa (4):
      perf evsel: Move id_offset out of struct perf_evsel union member
      perf cpu_map: Add cpu_map__empty_new function
      perf stat: Cache aggregated map entries in extra cpumap
      perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore

Namhyung Kim (4):
      perf tools: Improve ambiguous option help message
      perf report: Rename to --show-cpu-utilization
      perf tools: Setup pager when printing usage and help
      perf tools: Introduce usage_with_options_msg()

Wang Nan (1):
      perf tools: Enable pre-event inherit setting by config terms

 tools/perf/Documentation/perf-report.txt |  2 +-
 tools/perf/builtin-evlist.c              |  4 +--
 tools/perf/builtin-probe.c               | 20 ++++++-----
 tools/perf/builtin-record.c              | 11 +++---
 tools/perf/builtin-report.c              |  4 ++-
 tools/perf/builtin-sched.c               |  4 +--
 tools/perf/builtin-script.c              |  8 ++---
 tools/perf/builtin-stat.c                | 59 +++++++++++++++++++++++++++---
 tools/perf/util/cpumap.c                 | 17 +++++++++
 tools/perf/util/cpumap.h                 |  1 +
 tools/perf/util/evsel.c                  |  9 +++++
 tools/perf/util/evsel.h                  |  4 ++-
 tools/perf/util/parse-events.c           | 14 ++++++++
 tools/perf/util/parse-events.h           |  2 ++
 tools/perf/util/parse-events.l           |  2 ++
 tools/perf/util/parse-options.c          | 62 +++++++++++++++++++++++++-------
 tools/perf/util/parse-options.h          |  5 +++
 tools/perf/util/strbuf.c                 | 22 ++++++++----
 tools/perf/util/strbuf.h                 |  2 ++
 tools/perf/util/symbol-minimal.c         |  2 +-
 tools/perf/util/symbol.c                 | 11 +++++-
 21 files changed, 216 insertions(+), 49 deletions(-)

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit 4341801873e23bbecee76dabb7c111e3693b900f:
> 
>   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-25 09:40:31 +0100)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
> 
> for you to fetch changes up to 443f8c75e8d58d394b0e65b47e02e5cd8ed32b41:
> 
>   perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore (2015-10-28 11:19:30 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> User visible:
> 
> - Enable per-event perf_event_attr.inherit setting by config terms, i.e.
>   this becomes possible:
> 
>       $ perf record -e cycles/inherit/ -e instructions/no-inherit/
> 
>   This affects the default, that can be changed globally using the --no-inherit
>   option.
> 
>   This fine grained control appeared in the eBPF patchkit, but this added
>   flexibility may end up being useful in other scenarios (Wang Nan)
> 
> - Setup pager when printing usage and help, we have long lists of options,
>   better use the pager like we do with normal tooling output, i.e. when needed,
>   and including any error messages in the paged output (Namhyung Kim)
> 
> - Search for more options when passing args to -h, e.g.: (Arnaldo Carvalho de Melo)
> 
>   $ perf report -h interface
> 
>    Usage: perf report [<options>]
> 
>     --gtk    Use the GTK2 interface
>     --stdio  Use the stdio interface
>     --tui    Use the TUI interface

I love this! For example if I'd like to know what symbol related options we have, 
I only have to type:

triton:~/tip> perf top -h sym

 Usage: perf top [<options>]

    -D, --dump-symtab     dump the symbol table used for profiling
    -K, --hide_kernel_symbols
                          hide kernel symbols
    -s, --sort <key[,key2...]>
                          sort by key(s): pid, comm, dso, symbol, parent, cpu, srcline, ... Please refer the man page for the complete list.
    -U, --hide_user_symbols
                          hide user symbols
        --comms <comm[,comm...]>
                          only consider symbols in these comms
        --demangle-kernel
                          Enable kernel symbol demangling
        --dsos <dso[,dso...]>
                          only consider symbols in these dsos
        --sym-annotate <symbol name>
                          symbol to annotate
        --symbols <symbol[,symbol...]>
                          only consider these symbols

and it's a nice touch that it's searching in the parameter descriptions as well, 
not just the parameter name. Thus if I only remember some sort of keyword that's 
enough to narrow things down and figure out the option.

One small detail I noticed, for some reason the following search does not work:

  triton:~/tip> perf report -h --invert

    Usage: perf report [<options>]

It only works if I don't use the dashes:

  triton:~/tip> perf report -h invert

   Usage: perf report [<options>]

      -G, --inverted        alias for inverted call graph

... which is a bit surprising, agreed?

> - Fix reading separate debuginfo files based on a build-id, problem
>   found on a Debian system (Dima Kogan)
> 
> - Fix endless loop when splitting kallsyms symbols per section for
>   handling kcore files, problem found on a s390x system (Jiri Olsa)

Btw., is this bug specific to perf/core, or do we want it for perf/urgent as well?

> 
> Infrastructure:
> 
> - Prep work for the 'perf stat record' work that will allow generating
>   perf.data files with counting data in addition to the sampling mode
>   we have now (Jiri Olsa)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
>       perf tools: Search for more options when passing args to -h
> 
> Dima Kogan (2):
>       perf symbols: Fix type error when reading a build-id
>       perf symbols: we can now read separate debug-info files based on a build ID
> 
> Jiri Olsa (4):
>       perf evsel: Move id_offset out of struct perf_evsel union member
>       perf cpu_map: Add cpu_map__empty_new function
>       perf stat: Cache aggregated map entries in extra cpumap
>       perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore
> 
> Namhyung Kim (4):
>       perf tools: Improve ambiguous option help message
>       perf report: Rename to --show-cpu-utilization
>       perf tools: Setup pager when printing usage and help
>       perf tools: Introduce usage_with_options_msg()
> 
> Wang Nan (1):
>       perf tools: Enable pre-event inherit setting by config terms
> 
>  tools/perf/Documentation/perf-report.txt |  2 +-
>  tools/perf/builtin-evlist.c              |  4 +--
>  tools/perf/builtin-probe.c               | 20 ++++++-----
>  tools/perf/builtin-record.c              | 11 +++---
>  tools/perf/builtin-report.c              |  4 ++-
>  tools/perf/builtin-sched.c               |  4 +--
>  tools/perf/builtin-script.c              |  8 ++---
>  tools/perf/builtin-stat.c                | 59 +++++++++++++++++++++++++++---
>  tools/perf/util/cpumap.c                 | 17 +++++++++
>  tools/perf/util/cpumap.h                 |  1 +
>  tools/perf/util/evsel.c                  |  9 +++++
>  tools/perf/util/evsel.h                  |  4 ++-
>  tools/perf/util/parse-events.c           | 14 ++++++++
>  tools/perf/util/parse-events.h           |  2 ++
>  tools/perf/util/parse-events.l           |  2 ++
>  tools/perf/util/parse-options.c          | 62 +++++++++++++++++++++++++-------
>  tools/perf/util/parse-options.h          |  5 +++
>  tools/perf/util/strbuf.c                 | 22 ++++++++----
>  tools/perf/util/strbuf.h                 |  2 ++
>  tools/perf/util/symbol-minimal.c         |  2 +-
>  tools/perf/util/symbol.c                 | 11 +++++-
>  21 files changed, 216 insertions(+), 49 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Ingo Molnar <mingo@kernel.org> wrote:

> One small detail I noticed, for some reason the following search does not work:
> 
>   triton:~/tip> perf report -h --invert
> 
>     Usage: perf report [<options>]
> 

Btw., another detail, if it searches but does not try, I think we should output a 
warning to the user.

Printing something like this would be more helpful:

   triton:~/tip> perf report -h --invert
 
     Search pattern '--invert' not found amongst the parameters. To resolve this 
     use a different search pattern or use '-h' to list all parameters.

Thanks,

	Ingo

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Jiri Olsa]

On Thu, Oct 29, 2015 at 10:36:36AM +0100, Ingo Molnar wrote:

SNIP

> 
> > - Fix reading separate debuginfo files based on a build-id, problem
> >   found on a Debian system (Dima Kogan)
> > 
> > - Fix endless loop when splitting kallsyms symbols per section for
> >   handling kcore files, problem found on a s390x system (Jiri Olsa)
> 
> Btw., is this bug specific to perf/core, or do we want it for perf/urgent as well?

it could go to perf/urgent as well

jirka

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit bebd23a2ed31d47e7dd746d3b125068aa2c42d85:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-30 10:09:37 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to 0014de172d228e450377d1fd079d94e67128d27f:

  perf sched latency: Fix thread pid reuse issue (2015-11-05 12:51:00 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Fix 'perf top' segfault related to splitting overlapping mmaps (Jiri Olsa)

- Fix 'perf sched latency' when there is pid/tid reuse (Jiri Olsa)

- Fix documentation for 'perf trace -i' (Peter Feiner)

Infrastructure:

- Make the LINUX_VERSION_CODE define available for bpf scriptlets to use (Wang Nan)

- Pass the number of configured CPUs via the __NR_CPUS__ define to bpf scriptlets (Wang Nan)

- Fix libbpf compiler warning on CentOS 6 (Namhyung Kim)

- Only be verbose in several perf test entries, bpf included, when -v is used (Wang Nan)

- Don't run the 'build-test' entries always in the same order, the full
  set takes a long time, so sometimes we interrupt, shuffling them avoids
  running just the first same few in interrupted runs (Arnaldo Carvalho de Melo)

- Change FEATURE-DUMP to FEATURE-DUMP.libbpf in .gitignore and 'clean' make target (Yunlong Song)

- 'perf stat' refactorings to avoid duplicated code (Andi Kleen)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Andi Kleen (2):
      perf stat: Move sw clock metrics printout to stat-shadow
      perf stat: Use common printout function to avoid duplicated code

Arnaldo Carvalho de Melo (1):
      perf tools: Allow shuffling the build tests

Jiri Olsa (2):
      perf tools: Insert split maps correctly into origin group
      perf sched latency: Fix thread pid reuse issue

Namhyung Kim (1):
      tools lib bpf: Fix compiler warning on CentOS 6

Peter Feiner (1):
      perf trace: Fix documentation for -i

Wang Nan (5):
      perf test: Keep test result clean if '-v' not set
      perf bpf: Mute libbpf when '-v' not set
      perf llvm: Pass number of configured CPUs to clang compiler
      perf llvm: Pass LINUX_VERSION_CODE to BPF program when compiling
      perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

Yunlong Song (1):
      tools lib bpf: Change FEATURE-DUMP to FEATURE-DUMP.libbpf

 tools/lib/bpf/.gitignore                |  2 +-
 tools/lib/bpf/Makefile                  |  2 +-
 tools/lib/bpf/libbpf.c                  |  4 +--
 tools/lib/bpf/libbpf.h                  |  2 +-
 tools/perf/Documentation/perf-trace.txt |  1 -
 tools/perf/Makefile                     |  2 +-
 tools/perf/builtin-sched.c              |  5 +--
 tools/perf/builtin-stat.c               | 59 +++++++++++----------------------
 tools/perf/tests/attr.c                 |  3 +-
 tools/perf/tests/code-reading.c         |  8 ++---
 tools/perf/tests/keep-tracking.c        |  4 +--
 tools/perf/tests/llvm.c                 | 11 +++---
 tools/perf/tests/make                   |  5 +++
 tools/perf/tests/switch-tracking.c      |  4 +--
 tools/perf/util/bpf-loader.c            |  4 +--
 tools/perf/util/llvm-utils.c            | 51 ++++++++++++++++++++++++----
 tools/perf/util/map.c                   | 10 ++++--
 tools/perf/util/probe-event.c           |  3 ++
 tools/perf/util/stat-shadow.c           |  5 +++
 19 files changed, 110 insertions(+), 75 deletions(-)

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 3f56e687a138481894a1088d5aa7d41951bdb020:

  perf/core: Disable the event on a truncated AUX record (2016-05-12 10:14:55 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160516

for you to fetch changes up to a29d5c9b8167dbc21a7ca8c0302e3799f9063b4e:

  perf tools: Separate accounting of contexts and real addresses in a stack trace (2016-05-16 23:11:54 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Honour the kernel.perf_event_max_stack knob more precisely by not counting
  PERF_CONTEXT_{KERNEL,USER} when deciding when to stop adding entries to
  the perf_sample->ip_callchain[] array (Arnaldo Carvalho de Melo)

- Fix identation of 'stalled-backend-cycles' in 'perf stat' (Namhyung Kim)

- Update runtime using 'cpu-clock' event in 'perf stat' (Namhyung Kim)

- Use 'cpu-clock' for cpu targets in 'perf stat' (Namhyung Kim)

- Avoid fractional digits for integer scales in 'perf stat' (Andi Kleen)

- Store vdso buildid unconditionally, as it appears in callchains and
  we're not checking those when creating the build-id table, so we
  end up not being able to resolve VDSO symbols when doing analysis
  on a different machine than the one where recording was done, possibly
  of a different arch even (arm -> x86_64) (He Kuang)

Infrastructure:

- Generalize max_stack sysctl handler, will be used for configuring
  multiple kernel knobs related to callchains (Arnaldo Carvalho de Melo)

Cleanups:

- Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE, to stop using
  open coded strings (Masami Hiramatsu)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Andi Kleen (1):
      perf stat: Avoid fractional digits for integer scales

Arnaldo Carvalho de Melo (6):
      perf core: Generalize max_stack sysctl handler
      perf core: Pass max stack as a perf_callchain_entry context
      perf core: Add a 'nr' field to perf_event_callchain_context
      perf core: Add perf_callchain_store_context() helper
      perf core: Separate accounting of contexts and real addresses in a stack trace
      perf tools: Separate accounting of contexts and real addresses in a stack trace

He Kuang (1):
      perf symbols: Store vdso buildid unconditionally

Masami Hiramatsu (1):
      perf symbols: Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE

Namhyung Kim (3):
      perf stat: Fix indentation of stalled backend cycle
      perf stat: Update runtime using cpu-clock event
      perf stat: Use cpu-clock event for cpu targets

 Documentation/sysctl/kernel.txt    | 14 ++++++++++++++
 arch/arc/kernel/perf_event.c       |  6 +++---
 arch/arm/kernel/perf_callchain.c   | 10 +++++-----
 arch/arm64/kernel/perf_callchain.c | 14 +++++++-------
 arch/metag/kernel/perf_callchain.c | 10 +++++-----
 arch/mips/kernel/perf_event.c      | 12 ++++++------
 arch/powerpc/perf/callchain.c      | 20 ++++++++++----------
 arch/s390/kernel/perf_event.c      |  4 ++--
 arch/sh/kernel/perf_callchain.c    |  4 ++--
 arch/sparc/kernel/perf_event.c     | 14 +++++++-------
 arch/tile/kernel/perf_event.c      |  6 +++---
 arch/x86/events/core.c             | 14 +++++++-------
 arch/xtensa/kernel/perf_event.c    | 10 +++++-----
 include/linux/perf_event.h         | 34 +++++++++++++++++++++++++++++-----
 include/uapi/linux/perf_event.h    |  1 +
 kernel/bpf/stackmap.c              |  3 ++-
 kernel/events/callchain.c          | 36 ++++++++++++++++++++++++------------
 kernel/sysctl.c                    | 11 ++++++++++-
 tools/perf/builtin-buildid-cache.c |  8 ++++----
 tools/perf/builtin-stat.c          | 22 +++++++++++++---------
 tools/perf/perf.c                  |  3 +++
 tools/perf/util/annotate.c         |  2 +-
 tools/perf/util/build-id.c         |  2 +-
 tools/perf/util/dso.c              |  3 ++-
 tools/perf/util/machine.c          | 28 ++++++++++++++++++----------
 tools/perf/util/stat-shadow.c      |  8 +++++---
 tools/perf/util/symbol.c           | 10 +++++-----
 tools/perf/util/symbol.h           |  3 +++
 tools/perf/util/util.c             |  3 ++-
 tools/perf/util/util.h             |  3 ++-
 30 files changed, 201 insertions(+), 117 deletions(-)

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit 3f56e687a138481894a1088d5aa7d41951bdb020:
> 
>   perf/core: Disable the event on a truncated AUX record (2016-05-12 10:14:55 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160516
> 
> for you to fetch changes up to a29d5c9b8167dbc21a7ca8c0302e3799f9063b4e:
> 
>   perf tools: Separate accounting of contexts and real addresses in a stack trace (2016-05-16 23:11:54 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> User visible:
> 
> - Honour the kernel.perf_event_max_stack knob more precisely by not counting
>   PERF_CONTEXT_{KERNEL,USER} when deciding when to stop adding entries to
>   the perf_sample->ip_callchain[] array (Arnaldo Carvalho de Melo)
> 
> - Fix identation of 'stalled-backend-cycles' in 'perf stat' (Namhyung Kim)
> 
> - Update runtime using 'cpu-clock' event in 'perf stat' (Namhyung Kim)
> 
> - Use 'cpu-clock' for cpu targets in 'perf stat' (Namhyung Kim)
> 
> - Avoid fractional digits for integer scales in 'perf stat' (Andi Kleen)
> 
> - Store vdso buildid unconditionally, as it appears in callchains and
>   we're not checking those when creating the build-id table, so we
>   end up not being able to resolve VDSO symbols when doing analysis
>   on a different machine than the one where recording was done, possibly
>   of a different arch even (arm -> x86_64) (He Kuang)
> 
> Infrastructure:
> 
> - Generalize max_stack sysctl handler, will be used for configuring
>   multiple kernel knobs related to callchains (Arnaldo Carvalho de Melo)
> 
> Cleanups:
> 
> - Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE, to stop using
>   open coded strings (Masami Hiramatsu)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Andi Kleen (1):
>       perf stat: Avoid fractional digits for integer scales
> 
> Arnaldo Carvalho de Melo (6):
>       perf core: Generalize max_stack sysctl handler
>       perf core: Pass max stack as a perf_callchain_entry context
>       perf core: Add a 'nr' field to perf_event_callchain_context
>       perf core: Add perf_callchain_store_context() helper
>       perf core: Separate accounting of contexts and real addresses in a stack trace
>       perf tools: Separate accounting of contexts and real addresses in a stack trace
> 
> He Kuang (1):
>       perf symbols: Store vdso buildid unconditionally
> 
> Masami Hiramatsu (1):
>       perf symbols: Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE
> 
> Namhyung Kim (3):
>       perf stat: Fix indentation of stalled backend cycle
>       perf stat: Update runtime using cpu-clock event
>       perf stat: Use cpu-clock event for cpu targets
> 
>  Documentation/sysctl/kernel.txt    | 14 ++++++++++++++
>  arch/arc/kernel/perf_event.c       |  6 +++---
>  arch/arm/kernel/perf_callchain.c   | 10 +++++-----
>  arch/arm64/kernel/perf_callchain.c | 14 +++++++-------
>  arch/metag/kernel/perf_callchain.c | 10 +++++-----
>  arch/mips/kernel/perf_event.c      | 12 ++++++------
>  arch/powerpc/perf/callchain.c      | 20 ++++++++++----------
>  arch/s390/kernel/perf_event.c      |  4 ++--
>  arch/sh/kernel/perf_callchain.c    |  4 ++--
>  arch/sparc/kernel/perf_event.c     | 14 +++++++-------
>  arch/tile/kernel/perf_event.c      |  6 +++---
>  arch/x86/events/core.c             | 14 +++++++-------
>  arch/xtensa/kernel/perf_event.c    | 10 +++++-----
>  include/linux/perf_event.h         | 34 +++++++++++++++++++++++++++++-----
>  include/uapi/linux/perf_event.h    |  1 +
>  kernel/bpf/stackmap.c              |  3 ++-
>  kernel/events/callchain.c          | 36 ++++++++++++++++++++++++------------
>  kernel/sysctl.c                    | 11 ++++++++++-
>  tools/perf/builtin-buildid-cache.c |  8 ++++----
>  tools/perf/builtin-stat.c          | 22 +++++++++++++---------
>  tools/perf/perf.c                  |  3 +++
>  tools/perf/util/annotate.c         |  2 +-
>  tools/perf/util/build-id.c         |  2 +-
>  tools/perf/util/dso.c              |  3 ++-
>  tools/perf/util/machine.c          | 28 ++++++++++++++++++----------
>  tools/perf/util/stat-shadow.c      |  8 +++++---
>  tools/perf/util/symbol.c           | 10 +++++-----
>  tools/perf/util/symbol.h           |  3 +++
>  tools/perf/util/util.c             |  3 ++-
>  tools/perf/util/util.h             |  3 ++-
>  30 files changed, 201 insertions(+), 117 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 711460514b1c80494f14001bdf30dd70fd401a8f:

  Merge tag 'perf-urgent-for-mingo-20160527' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-05-29 20:15:37 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160530

for you to fetch changes up to 01412261d99497021353c4b1d67e8df6c9cdc3c6:

  perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid (2016-05-30 13:15:03 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible/kernel ABI:

- Per event callchain limit: Recently we introduced a sysctl to tune the
  max-stack for all events for which callchains were requested:

  $ sysctl kernel.perf_event_max_stack
  kernel.perf_event_max_stack = 127

  Now this patch introduces a way to configure this per event, i.e. this
  becomes possible:

  $ perf record -e sched:*/max-stack=2/ -e block:*/max-stack=10/ -a

  allowing finer tuning of how much buffer space callchains use.

  This uses an u16 from the reserved space at the end, leaving another
  u16 for future use.

  There has been interest in even finer tuning, namely to control the
  max stack for kernel and userspace callchains separately. Further
  discussion is needed, we may for instance use the remaining u16 for
  that and when it is present, assume that the sample_max_stack introduced
  in this patch applies for the kernel, and the u16 left is used for
  limiting the userspace callchain. (Arnaldo Carvalho de Melo)

Infrastructure:

- Adopt get_main_thread from db-export.c (Andi Kleen)

- More prep work for backward ring buffer support (Wang Nan)

- Prep work for supporting SDT (Statically Defined Tracing)
  tracepoints (Masami Hiramatsu)

- Add arch/*/include/generated/ to .gitignore (Taeung Song)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Andi Kleen (1):
      perf thread: Adopt get_main_thread from db-export.c

Arnaldo Carvalho de Melo (2):
      perf core: Per event callchain limit
      perf tools: Per event max-stack settings

Masami Hiramatsu (3):
      perf symbols: Introduce filename__readable to check readability
      perf symbols: Cleanup the code flow of dso__find_kallsyms
      perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid

Taeung Song (1):
      perf tools: Add arch/*/include/generated/ to .gitignore

Wang Nan (5):
      perf record: Robustify perf_event__synth_time_conv()
      perf evlist: Don't poll and mmap overwritable events
      perf evlist: Check 'base' pointer before checking refcnt when put a mmap
      perf evlist: Choose correct reading direction according to evlist->backward
      tools: Pass arg to fdarray__filter's call back function

 include/linux/perf_event.h      |   2 +-
 include/uapi/linux/perf_event.h |   6 ++-
 kernel/bpf/stackmap.c           |   2 +-
 kernel/events/callchain.c       |  14 ++++-
 kernel/events/core.c            |   5 +-
 tools/lib/api/fd/array.c        |   5 +-
 tools/lib/api/fd/array.h        |   3 +-
 tools/perf/.gitignore           |   1 +
 tools/perf/arch/x86/util/tsc.c  |   2 +
 tools/perf/builtin-record.c     |   9 +++-
 tools/perf/tests/fdarray.c      |   8 +--
 tools/perf/util/build-id.c      | 115 ++++++++++++++++++++++++++++++----------
 tools/perf/util/build-id.h      |   2 +
 tools/perf/util/callchain.h     |   1 +
 tools/perf/util/db-export.c     |  13 +----
 tools/perf/util/dso.h           |   5 ++
 tools/perf/util/evlist.c        |  43 +++++++++++----
 tools/perf/util/evlist.h        |   2 +
 tools/perf/util/evsel.c         |  16 +++++-
 tools/perf/util/evsel.h         |   2 +
 tools/perf/util/parse-events.c  |   8 +++
 tools/perf/util/parse-events.h  |   1 +
 tools/perf/util/parse-events.l  |   1 +
 tools/perf/util/session.c       |   2 +
 tools/perf/util/symbol.c        |  71 ++++++++++++-------------
 tools/perf/util/thread.c        |  11 ++++
 tools/perf/util/thread.h        |   2 +
 27 files changed, 252 insertions(+), 100 deletions(-)

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit 711460514b1c80494f14001bdf30dd70fd401a8f:
> 
>   Merge tag 'perf-urgent-for-mingo-20160527' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-05-29 20:15:37 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160530
> 
> for you to fetch changes up to 01412261d99497021353c4b1d67e8df6c9cdc3c6:
> 
>   perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid (2016-05-30 13:15:03 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> User visible/kernel ABI:
> 
> - Per event callchain limit: Recently we introduced a sysctl to tune the
>   max-stack for all events for which callchains were requested:
> 
>   $ sysctl kernel.perf_event_max_stack
>   kernel.perf_event_max_stack = 127
> 
>   Now this patch introduces a way to configure this per event, i.e. this
>   becomes possible:
> 
>   $ perf record -e sched:*/max-stack=2/ -e block:*/max-stack=10/ -a
> 
>   allowing finer tuning of how much buffer space callchains use.
> 
>   This uses an u16 from the reserved space at the end, leaving another
>   u16 for future use.
> 
>   There has been interest in even finer tuning, namely to control the
>   max stack for kernel and userspace callchains separately. Further
>   discussion is needed, we may for instance use the remaining u16 for
>   that and when it is present, assume that the sample_max_stack introduced
>   in this patch applies for the kernel, and the u16 left is used for
>   limiting the userspace callchain. (Arnaldo Carvalho de Melo)
> 
> Infrastructure:
> 
> - Adopt get_main_thread from db-export.c (Andi Kleen)
> 
> - More prep work for backward ring buffer support (Wang Nan)
> 
> - Prep work for supporting SDT (Statically Defined Tracing)
>   tracepoints (Masami Hiramatsu)
> 
> - Add arch/*/include/generated/ to .gitignore (Taeung Song)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Andi Kleen (1):
>       perf thread: Adopt get_main_thread from db-export.c
> 
> Arnaldo Carvalho de Melo (2):
>       perf core: Per event callchain limit
>       perf tools: Per event max-stack settings
> 
> Masami Hiramatsu (3):
>       perf symbols: Introduce filename__readable to check readability
>       perf symbols: Cleanup the code flow of dso__find_kallsyms
>       perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid
> 
> Taeung Song (1):
>       perf tools: Add arch/*/include/generated/ to .gitignore
> 
> Wang Nan (5):
>       perf record: Robustify perf_event__synth_time_conv()
>       perf evlist: Don't poll and mmap overwritable events
>       perf evlist: Check 'base' pointer before checking refcnt when put a mmap
>       perf evlist: Choose correct reading direction according to evlist->backward
>       tools: Pass arg to fdarray__filter's call back function
> 
>  include/linux/perf_event.h      |   2 +-
>  include/uapi/linux/perf_event.h |   6 ++-
>  kernel/bpf/stackmap.c           |   2 +-
>  kernel/events/callchain.c       |  14 ++++-
>  kernel/events/core.c            |   5 +-
>  tools/lib/api/fd/array.c        |   5 +-
>  tools/lib/api/fd/array.h        |   3 +-
>  tools/perf/.gitignore           |   1 +
>  tools/perf/arch/x86/util/tsc.c  |   2 +
>  tools/perf/builtin-record.c     |   9 +++-
>  tools/perf/tests/fdarray.c      |   8 +--
>  tools/perf/util/build-id.c      | 115 ++++++++++++++++++++++++++++++----------
>  tools/perf/util/build-id.h      |   2 +
>  tools/perf/util/callchain.h     |   1 +
>  tools/perf/util/db-export.c     |  13 +----
>  tools/perf/util/dso.h           |   5 ++
>  tools/perf/util/evlist.c        |  43 +++++++++++----
>  tools/perf/util/evlist.h        |   2 +
>  tools/perf/util/evsel.c         |  16 +++++-
>  tools/perf/util/evsel.h         |   2 +
>  tools/perf/util/parse-events.c  |   8 +++
>  tools/perf/util/parse-events.h  |   1 +
>  tools/perf/util/parse-events.l  |   1 +
>  tools/perf/util/session.c       |   2 +
>  tools/perf/util/symbol.c        |  71 ++++++++++++-------------
>  tools/perf/util/thread.c        |  11 ++++
>  tools/perf/util/thread.h        |   2 +
>  27 files changed, 252 insertions(+), 100 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit c0b172e5b6770048751b2c0a4fe44346c2080c5d:

  Merge tag 'perf-core-for-mingo-20160901' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-09-05 15:15:49 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160908

for you to fetch changes up to 25b8592e912f085ce2ff736a2927584ddeab238c:

  perf powerpc: Fix build-test failure (2016-09-08 13:44:07 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Add branch stack / basic block info to 'perf annotate --stdio', where for
  each branch, we add an asm comment after the instruction with information on
  how often it was taken and predicted. See example with color output at:

    http://vger.kernel.org/~acme/perf/annotate_basic_blocks.png

  (Peter Zijlstra)

- Only open an evsel in CPUs in its cpu map, fixing some use cases in
  systems with multiple PMUs with different CPU maps (Mark Rutland)

- Fix handling of huge TLB maps, recognizing it as anonymous (Wang Nan)

Infrastructure:

- Remove the symbol filtering code, i.e. the callbacks passed to all functions
  that could end up loading a DSO symtab, simplifying the code, eventually
  allowing what we should have had since day one: removing the 'map' parameter
  from dso__load() functions (Arnaldo Carvalho de Melo)

Arch specific build fixes:

- Fix detached tarball build on powerpc, where we were still accessing a
  file outside tools/ (Ravi Bangoria)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (5):
      perf symbols: Mark if a symbol is idle in the library
      perf top: Remove old kernel-only symbol filter
      perf machine: Remove machine->symbol_filter and friends
      perf test vmlinux: Remove dead symbol_filter_t code
      perf symbols: Remove symbol_filter_t machinery

Mark Rutland (2):
      perf evlist: Only open events on CPUs an evsel permits
      perf pmu: Support alternative sysfs cpumask

Peter Zijlstra (1):
      perf annotate: Add branch stack / basic block

Ravi Bangoria (1):
      perf powerpc: Fix build-test failure

Wang Nan (3):
      perf tools: Recognize hugetlb mapping as anon mapping
      tools lib api fs: Add hugetlbfs filesystem detector
      perf record: Mark MAP_HUGETLB when synthesizing mmap events

 tools/lib/api/fs/fs.c                       |  15 ++
 tools/lib/api/fs/fs.h                       |   1 +
 tools/perf/arch/powerpc/util/sym-handling.c |   2 +-
 tools/perf/builtin-annotate.c               | 104 +++++++++
 tools/perf/builtin-inject.c                 |   2 +-
 tools/perf/builtin-kmem.c                   |  10 +-
 tools/perf/builtin-script.c                 |   4 +-
 tools/perf/builtin-top.c                    |  30 ---
 tools/perf/perf-sys.h                       |   1 -
 tools/perf/tests/code-reading.c             |   4 +-
 tools/perf/tests/vmlinux-kallsyms.c         |  17 +-
 tools/perf/ui/browsers/annotate.c           |   2 +-
 tools/perf/ui/browsers/map.c                |   4 +-
 tools/perf/util/Build                       |   1 +
 tools/perf/util/annotate.c                  |  95 +++++++-
 tools/perf/util/annotate.h                  |   1 +
 tools/perf/util/block-range.c               | 328 ++++++++++++++++++++++++++++
 tools/perf/util/block-range.h               |  71 ++++++
 tools/perf/util/event.c                     |  21 +-
 tools/perf/util/evlist.c                    |   8 +-
 tools/perf/util/intel-bts.c                 |   2 +-
 tools/perf/util/intel-pt.c                  |   4 +-
 tools/perf/util/machine.c                   |  38 +---
 tools/perf/util/machine.h                   |  34 +--
 tools/perf/util/map.c                       |  50 ++---
 tools/perf/util/map.h                       |  32 +--
 tools/perf/util/pmu.c                       |  15 +-
 tools/perf/util/probe-event.c               |  17 +-
 tools/perf/util/symbol-elf.c                |  32 +--
 tools/perf/util/symbol-minimal.c            |   4 +-
 tools/perf/util/symbol.c                    | 134 ++++++------
 tools/perf/util/symbol.h                    |  20 +-
 32 files changed, 817 insertions(+), 286 deletions(-)
 create mode 100644 tools/perf/util/block-range.c
 create mode 100644 tools/perf/util/block-range.h

Build stats:

  [root@jouet ~]# time dm
   1 69.078 alpine:3.4: Ok
   2 24.055 android-ndk:r12b-arm: Ok
   3 71.911 archlinux:latest: Ok
   4 41.209 centos:5: Ok
   5 58.240 centos:6: Ok
   6 67.238 centos:7: Ok
   7 62.040 debian:7: Ok
   8 69.061 debian:8: Ok
   9 38.124 debian:experimental: Ok
  10 67.623 fedora:20: Ok
  11 71.458 fedora:21: Ok
  12 70.807 fedora:22: Ok
  13 71.013 fedora:23: Ok
  14 73.330 fedora:24: Ok
  15 30.062 fedora:24-x-ARC-uClibc: Ok
  16 77.616 fedora:rawhide: Ok
  17 73.663 mageia:5: Ok
  18 69.264 opensuse:13.2: Ok
  19 71.532 opensuse:42.1: Ok
  20 76.282 opensuse:tumbleweed: Ok
  21 54.666 ubuntu:12.04.5: Ok
  22 37.170 ubuntu:14.04: Ok
  23 66.101 ubuntu:14.04.4: Ok
  24 68.881 ubuntu:15.10: Ok
  25 62.698 ubuntu:16.04: Ok
  26 53.046 ubuntu:16.04-x-arm: Ok
  27 51.609 ubuntu:16.04-x-arm64: Ok
  28 51.842 ubuntu:16.04-x-powerpc64: Ok
  29 53.347 ubuntu:16.04-x-powerpc64el: Ok
  30 72.280 ubuntu:16.10: Ok
  31 54.078 ubuntu:16.10-x-s390: Ok

  real	31m19.919s
  user	0m1.890s
  sys	0m2.201s
  [root@jouet ~]#

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit c0b172e5b6770048751b2c0a4fe44346c2080c5d:
> 
>   Merge tag 'perf-core-for-mingo-20160901' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-09-05 15:15:49 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160908
> 
> for you to fetch changes up to 25b8592e912f085ce2ff736a2927584ddeab238c:
> 
>   perf powerpc: Fix build-test failure (2016-09-08 13:44:07 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> User visible:
> 
> - Add branch stack / basic block info to 'perf annotate --stdio', where for
>   each branch, we add an asm comment after the instruction with information on
>   how often it was taken and predicted. See example with color output at:
> 
>     http://vger.kernel.org/~acme/perf/annotate_basic_blocks.png
> 
>   (Peter Zijlstra)
> 
> - Only open an evsel in CPUs in its cpu map, fixing some use cases in
>   systems with multiple PMUs with different CPU maps (Mark Rutland)
> 
> - Fix handling of huge TLB maps, recognizing it as anonymous (Wang Nan)
> 
> Infrastructure:
> 
> - Remove the symbol filtering code, i.e. the callbacks passed to all functions
>   that could end up loading a DSO symtab, simplifying the code, eventually
>   allowing what we should have had since day one: removing the 'map' parameter
>   from dso__load() functions (Arnaldo Carvalho de Melo)
> 
> Arch specific build fixes:
> 
> - Fix detached tarball build on powerpc, where we were still accessing a
>   file outside tools/ (Ravi Bangoria)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (5):
>       perf symbols: Mark if a symbol is idle in the library
>       perf top: Remove old kernel-only symbol filter
>       perf machine: Remove machine->symbol_filter and friends
>       perf test vmlinux: Remove dead symbol_filter_t code
>       perf symbols: Remove symbol_filter_t machinery
> 
> Mark Rutland (2):
>       perf evlist: Only open events on CPUs an evsel permits
>       perf pmu: Support alternative sysfs cpumask
> 
> Peter Zijlstra (1):
>       perf annotate: Add branch stack / basic block
> 
> Ravi Bangoria (1):
>       perf powerpc: Fix build-test failure
> 
> Wang Nan (3):
>       perf tools: Recognize hugetlb mapping as anon mapping
>       tools lib api fs: Add hugetlbfs filesystem detector
>       perf record: Mark MAP_HUGETLB when synthesizing mmap events
> 
>  tools/lib/api/fs/fs.c                       |  15 ++
>  tools/lib/api/fs/fs.h                       |   1 +
>  tools/perf/arch/powerpc/util/sym-handling.c |   2 +-
>  tools/perf/builtin-annotate.c               | 104 +++++++++
>  tools/perf/builtin-inject.c                 |   2 +-
>  tools/perf/builtin-kmem.c                   |  10 +-
>  tools/perf/builtin-script.c                 |   4 +-
>  tools/perf/builtin-top.c                    |  30 ---
>  tools/perf/perf-sys.h                       |   1 -
>  tools/perf/tests/code-reading.c             |   4 +-
>  tools/perf/tests/vmlinux-kallsyms.c         |  17 +-
>  tools/perf/ui/browsers/annotate.c           |   2 +-
>  tools/perf/ui/browsers/map.c                |   4 +-
>  tools/perf/util/Build                       |   1 +
>  tools/perf/util/annotate.c                  |  95 +++++++-
>  tools/perf/util/annotate.h                  |   1 +
>  tools/perf/util/block-range.c               | 328 ++++++++++++++++++++++++++++
>  tools/perf/util/block-range.h               |  71 ++++++
>  tools/perf/util/event.c                     |  21 +-
>  tools/perf/util/evlist.c                    |   8 +-
>  tools/perf/util/intel-bts.c                 |   2 +-
>  tools/perf/util/intel-pt.c                  |   4 +-
>  tools/perf/util/machine.c                   |  38 +---
>  tools/perf/util/machine.h                   |  34 +--
>  tools/perf/util/map.c                       |  50 ++---
>  tools/perf/util/map.h                       |  32 +--
>  tools/perf/util/pmu.c                       |  15 +-
>  tools/perf/util/probe-event.c               |  17 +-
>  tools/perf/util/symbol-elf.c                |  32 +--
>  tools/perf/util/symbol-minimal.c            |   4 +-
>  tools/perf/util/symbol.c                    | 134 ++++++------
>  tools/perf/util/symbol.h                    |  20 +-
>  32 files changed, 817 insertions(+), 286 deletions(-)
>  create mode 100644 tools/perf/util/block-range.c
>  create mode 100644 tools/perf/util/block-range.h
> 
> Build stats:
> 
>   [root@jouet ~]# time dm
>    1 69.078 alpine:3.4: Ok
>    2 24.055 android-ndk:r12b-arm: Ok
>    3 71.911 archlinux:latest: Ok
>    4 41.209 centos:5: Ok
>    5 58.240 centos:6: Ok
>    6 67.238 centos:7: Ok
>    7 62.040 debian:7: Ok
>    8 69.061 debian:8: Ok
>    9 38.124 debian:experimental: Ok
>   10 67.623 fedora:20: Ok
>   11 71.458 fedora:21: Ok
>   12 70.807 fedora:22: Ok
>   13 71.013 fedora:23: Ok
>   14 73.330 fedora:24: Ok
>   15 30.062 fedora:24-x-ARC-uClibc: Ok
>   16 77.616 fedora:rawhide: Ok
>   17 73.663 mageia:5: Ok
>   18 69.264 opensuse:13.2: Ok
>   19 71.532 opensuse:42.1: Ok
>   20 76.282 opensuse:tumbleweed: Ok
>   21 54.666 ubuntu:12.04.5: Ok
>   22 37.170 ubuntu:14.04: Ok
>   23 66.101 ubuntu:14.04.4: Ok
>   24 68.881 ubuntu:15.10: Ok
>   25 62.698 ubuntu:16.04: Ok
>   26 53.046 ubuntu:16.04-x-arm: Ok
>   27 51.609 ubuntu:16.04-x-arm64: Ok
>   28 51.842 ubuntu:16.04-x-powerpc64: Ok
>   29 53.347 ubuntu:16.04-x-powerpc64el: Ok
>   30 72.280 ubuntu:16.10: Ok
>   31 54.078 ubuntu:16.10-x-s390: Ok
> 
>   real	31m19.919s
>   user	0m1.890s
>   sys	0m2.201s
>   [root@jouet ~]#

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

Test results at the end of this message.

The following changes since commit 47414424c53a70eceb0fc6e0a35a31a2b763d5b2:

  Merge tag 'perf-core-for-mingo-20161123' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-11-24 05:09:31 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161125

for you to fetch changes up to 4708bbda5cb2f6cdc331744597527143f46394d5:

  tools lib bpf: Fix maps resolution (2016-11-25 11:27:33 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

New features:

- Improve ARM support in the annotation code, affecting 'perf annotate', 'perf
  report' and live annotation in 'perf top' (Kim Phillips)

- Initial support for PowerPC in the annotation code (Ravi Bangoria)

- Skip repetitive scheduler function on the top of the stack in
  'perf sched timehist' (Namhyung Kim)

Fixes:

- Fix maps resolution in libbpf (Eric Leblond)

- Get the kernel signature via /proc/version_signature, available on
  ubuntu systems, to make sure bpf proggies works, as the one provided
  via 'uname -r' doesn't (Wang Nan)

- Fix segfault in 'perf record' when running with suid and kptr_restrict
  is 1 (Wang Nan)

Infrastructure:

- Support per-arch instruction tables, kept via a static or dynamic table
  (Arnaldo Carvalho de Melo)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (4):
      perf annotate: Remove duplicate 'name' field from disasm_line
      perf annotate: Introduce alternative method of keeping instructions table
      perf annotate: Allow arches to have a init routine and a priv area
      perf annotate: Improve support for ARM

Eric Leblond (1):
      tools lib bpf: Fix maps resolution

Namhyung Kim (3):
      perf callchain: Add option to skip ignore symbol when printing callchains
      perf sched timehist: Mark schedule function in callchains
      perf sched timehist: Enlarge max stack depth by 2

Ravi Bangoria (1):
      perf annotate: Initial PowerPC support

Wang Nan (3):
      perf tools: Fix kernel version error in ubuntu
      perf record: Fix segfault when running with suid and kptr_restrict is 1
      perf tools: Add missing struct definition in probe_event.h

 tools/lib/bpf/libbpf.c                          | 142 ++++++++++++++-------
 tools/perf/arch/arm/annotate/instructions.c     | 147 +++++++++-------------
 tools/perf/arch/powerpc/annotate/instructions.c |  58 +++++++++
 tools/perf/builtin-sched.c                      |  26 +++-
 tools/perf/ui/browsers/annotate.c               |  18 +--
 tools/perf/util/annotate.c                      | 157 +++++++++++++++++-------
 tools/perf/util/annotate.h                      |  17 ++-
 tools/perf/util/evsel.h                         |   1 +
 tools/perf/util/evsel_fprintf.c                 |   7 +-
 tools/perf/util/probe-event.h                   |   2 +
 tools/perf/util/symbol.c                        |   2 +-
 tools/perf/util/symbol.h                        |   1 +
 tools/perf/util/util.c                          |  55 ++++++++-
 13 files changed, 431 insertions(+), 202 deletions(-)
 create mode 100644 tools/perf/arch/powerpc/annotate/instructions.c

  Rebuilding containers, so limited coverage at this time:
  # dm
   1 debian:experimental: Ok
   2 fedora:24: Ok
   3 fedora:24-x-ARC-uClibc: Ok
   4 fedora:rawhide: Ok
   5 opensuse:tumbleweed: Ok

  # perf test
   1: vmlinux symtab matches kallsyms                          : Ok
   2: detect openat syscall event                              : Ok
   3: detect openat syscall event on all cpus                  : Ok
   4: read samples using the mmap interface                    : Ok
   5: parse events tests                                       : Ok
   6: Validate PERF_RECORD_* events & perf_sample fields       : Ok
   7: Test perf pmu format parsing                             : Ok
   8: Test dso data read                                       : Ok
   9: Test dso data cache                                      : Ok
  10: Test dso data reopen                                     : Ok
  11: roundtrip evsel->name check                              : Ok
  12: Check parsing of sched tracepoints fields                : Ok
  13: Generate and check syscalls:sys_enter_openat event fields: Ok
  14: struct perf_event_attr setup                             : Ok
  15: Test matching and linking multiple hists                 : Ok
  16: Try 'import perf' in python, checking link problems      : Ok
  17: Test breakpoint overflow signal handler                  : Ok
  18: Test breakpoint overflow sampling                        : Ok
  19: Test number of exit event of a simple workload           : Ok
  20: Test software clock events have valid period values      : Ok
  21: Test object code reading                                 : Ok
  22: Test sample parsing                                      : Ok
  23: Test using a dummy software event to keep tracking       : Ok
  24: Test parsing with no sample_id_all bit set               : Ok
  25: Test filtering hist entries                              : Ok
  26: Test mmap thread lookup                                  : Ok
  27: Test thread mg sharing                                   : Ok
  28: Test output sorting of hist entries                      : Ok
  29: Test cumulation of child hist entries                    : Ok
  30: Test tracking with sched_switch                          : Ok
  31: Filter fds with revents mask in a fdarray                : Ok
  32: Add fd to a fdarray, making it autogrow                  : Ok
  33: Test kmod_path__parse function                           : Ok
  34: Test thread map                                          : Ok
  35: Test LLVM searching and compiling                        :
  35.1: Basic BPF llvm compiling test                          : Ok
  35.2: Test kbuild searching                                  : Ok
  35.3: Compile source for BPF prologue generation test        : Ok
  35.4: Compile source for BPF relocation test                 : Ok
  36: Test topology in session                                 : Ok
  37: Test BPF filter                                          :
  37.1: Test basic BPF filtering                               : Ok
  37.2: Test BPF prologue generation                           : Ok
  37.3: Test BPF relocation checker                            : Ok
  38: Test thread map synthesize                               : Ok
  39: Test cpu map synthesize                                  : Ok
  40: Test stat config synthesize                              : Ok
  41: Test stat synthesize                                     : Ok
  42: Test stat round synthesize                               : Ok
  43: Test attr update synthesize                              : Ok
  44: Test events times                                        : Ok
  45: Test backward reading from ring buffer                   : Ok
  46: Test cpu map print                                       : Ok
  47: Test SDT event probing                                   : Ok
  48: Test is_printable_array function                         : Ok
  49: Test bitmap print                                        : Ok
  50: x86 rdpmc test                                           : Ok
  51: Test converting perf time to TSC                         : Ok
  52: Test dwarf unwind                                        : Ok
  53: Test x86 instruction decoder - new instructions          : Ok
  54: Test intel cqm nmi context read                          : Skip
  #
  $ make -C tools/perf build-test
  make: Entering directory '/home/acme/git/linux/tools/perf'
  - tarpkg: ./tests/perf-targz-src-pkg .
             make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
               make_no_slang_O: make NO_SLANG=1
                make_no_gtk2_O: make NO_GTK2=1
             make_no_libperl_O: make NO_LIBPERL=1
            make_no_libaudit_O: make NO_LIBAUDIT=1
        make_with_babeltrace_O: make LIBBABELTRACE=1
                make_no_newt_O: make NO_NEWT=1
             make_util_map_o_O: make util/map.o
                   make_pure_O: make
              make_no_libbpf_O: make NO_LIBBPF=1
                    make_doc_O: make doc
             make_no_libnuma_O: make NO_LIBNUMA=1
       make_util_pmu_bison_o_O: make util/pmu-bison.o
                   make_tags_O: make tags
         make_install_prefix_O: make install prefix=/tmp/krava
            make_no_demangle_O: make NO_DEMANGLE=1
           make_no_libpython_O: make NO_LIBPYTHON=1
                 make_static_O: make LDFLAGS=-static
                  make_debug_O: make DEBUG=1
                  make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
   make_install_prefix_slash_O: make install prefix=/tmp/krava/
  make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
            make_no_auxtrace_O: make NO_AUXTRACE=1
                make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
                 make_perf_o_O: make perf.o
           make_no_libbionic_O: make NO_LIBBIONIC=1
              make_clean_all_O: make clean all
           make_no_backtrace_O: make NO_BACKTRACE=1
                make_install_O: make install
           make_no_libunwind_O: make NO_LIBUNWIND=1
            make_install_bin_O: make install-bin
              make_no_libelf_O: make NO_LIBELF=1
                   make_help_O: make help
  OK
  make: Leaving directory '/home/acme/git/linux/tools/perf'
  $

[PATCH 01/12] perf annotate: Remove duplicate 'name' field from disasm_line

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

The disasm_line::name field is always equal to ins::name, being used
just to locate the instruction's ins_ops from the per-arch instructions
table.

Eliminate this duplication, nuking that field and instead make
ins__find() return an ins_ops, store it in disasm_line::ins.ops, and
keep just in disasm_line::ins.name what was in disasm_line::name, this
way we end up not keeping a reference to entries in the per-arch
instructions table.

This in turn will help supporting multiple ways to manage the per-arch
instructions table, allowing resorting that array, for instance, when
the entries will move after references to its addresses were made. The
same problem is avoided when one grows the array with realloc.

So architectures simply keeping a constant array will work as well as
architectures building the table using regular expressions or other
logic that involves resorting the table.

Reviewed-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Chris Riyder <chris.ryder@arm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kim Phillips <kim.phillips@arm.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Taeung Song <treeze.taeung@gmail.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-vr899azvabnw9gtuepuqfd9t@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/ui/browsers/annotate.c | 18 +++++-----
 tools/perf/util/annotate.c        | 73 ++++++++++++++++++---------------------
 tools/perf/util/annotate.h        | 17 +++++----
 3 files changed, 51 insertions(+), 57 deletions(-)

diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index e6e9f7d80dbd..cee0eee31ce6 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -213,17 +213,17 @@ static void annotate_browser__write(struct ui_browser *browser, void *entry, int
 		ui_browser__write_nstring(browser, bf, printed);
 		if (change_color)
 			ui_browser__set_color(browser, color);
-		if (dl->ins && dl->ins->ops->scnprintf) {
-			if (ins__is_jump(dl->ins)) {
+		if (dl->ins.ops && dl->ins.ops->scnprintf) {
+			if (ins__is_jump(&dl->ins)) {
 				bool fwd = dl->ops.target.offset > (u64)dl->offset;
 
 				ui_browser__write_graph(browser, fwd ? SLSMG_DARROW_CHAR :
 								    SLSMG_UARROW_CHAR);
 				SLsmg_write_char(' ');
-			} else if (ins__is_call(dl->ins)) {
+			} else if (ins__is_call(&dl->ins)) {
 				ui_browser__write_graph(browser, SLSMG_RARROW_CHAR);
 				SLsmg_write_char(' ');
-			} else if (ins__is_ret(dl->ins)) {
+			} else if (ins__is_ret(&dl->ins)) {
 				ui_browser__write_graph(browser, SLSMG_LARROW_CHAR);
 				SLsmg_write_char(' ');
 			} else {
@@ -243,7 +243,7 @@ static void annotate_browser__write(struct ui_browser *browser, void *entry, int
 
 static bool disasm_line__is_valid_jump(struct disasm_line *dl, struct symbol *sym)
 {
-	if (!dl || !dl->ins || !ins__is_jump(dl->ins)
+	if (!dl || !dl->ins.ops || !ins__is_jump(&dl->ins)
 	    || !disasm_line__has_offset(dl)
 	    || dl->ops.target.offset >= symbol__size(sym))
 		return false;
@@ -492,7 +492,7 @@ static bool annotate_browser__callq(struct annotate_browser *browser,
 	};
 	char title[SYM_TITLE_MAX_SIZE];
 
-	if (!ins__is_call(dl->ins))
+	if (!ins__is_call(&dl->ins))
 		return false;
 
 	if (map_groups__find_ams(&target) ||
@@ -545,7 +545,7 @@ static bool annotate_browser__jump(struct annotate_browser *browser)
 	struct disasm_line *dl = browser->selection;
 	s64 idx;
 
-	if (!ins__is_jump(dl->ins))
+	if (!ins__is_jump(&dl->ins))
 		return false;
 
 	dl = annotate_browser__find_offset(browser, dl->ops.target.offset, &idx);
@@ -841,9 +841,9 @@ static int annotate_browser__run(struct annotate_browser *browser,
 				ui_helpline__puts("Huh? No selection. Report to linux-kernel@vger.kernel.org");
 			else if (browser->selection->offset == -1)
 				ui_helpline__puts("Actions are only available for assembly lines.");
-			else if (!browser->selection->ins)
+			else if (!browser->selection->ins.ops)
 				goto show_sup_ins;
-			else if (ins__is_ret(browser->selection->ins))
+			else if (ins__is_ret(&browser->selection->ins))
 				goto out;
 			else if (!(annotate_browser__jump(browser) ||
 				     annotate_browser__callq(browser, evsel, hbt))) {
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 095d90a9077f..b48a39be071b 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -28,8 +28,8 @@ const char 	*disassembler_style;
 const char	*objdump_path;
 static regex_t	 file_lineno;
 
-static struct ins *ins__find(struct arch *arch, const char *name);
-static int disasm_line__parse(char *line, char **namep, char **rawp);
+static struct ins_ops *ins__find(struct arch *arch, const char *name);
+static int disasm_line__parse(char *line, const char **namep, char **rawp);
 
 struct arch {
 	const char	*name;
@@ -218,26 +218,20 @@ static int comment__symbol(char *raw, char *comment, u64 *addrp, char **namep)
 
 static int lock__parse(struct arch *arch, struct ins_operands *ops, struct map *map)
 {
-	char *name;
-
 	ops->locked.ops = zalloc(sizeof(*ops->locked.ops));
 	if (ops->locked.ops == NULL)
 		return 0;
 
-	if (disasm_line__parse(ops->raw, &name, &ops->locked.ops->raw) < 0)
+	if (disasm_line__parse(ops->raw, &ops->locked.ins.name, &ops->locked.ops->raw) < 0)
 		goto out_free_ops;
 
-	ops->locked.ins = ins__find(arch, name);
-	free(name);
+	ops->locked.ins.ops = ins__find(arch, ops->locked.ins.name);
 
-	if (ops->locked.ins == NULL)
+	if (ops->locked.ins.ops == NULL)
 		goto out_free_ops;
 
-	if (!ops->locked.ins->ops)
-		return 0;
-
-	if (ops->locked.ins->ops->parse &&
-	    ops->locked.ins->ops->parse(arch, ops->locked.ops, map) < 0)
+	if (ops->locked.ins.ops->parse &&
+	    ops->locked.ins.ops->parse(arch, ops->locked.ops, map) < 0)
 		goto out_free_ops;
 
 	return 0;
@@ -252,19 +246,19 @@ static int lock__scnprintf(struct ins *ins, char *bf, size_t size,
 {
 	int printed;
 
-	if (ops->locked.ins == NULL)
+	if (ops->locked.ins.ops == NULL)
 		return ins__raw_scnprintf(ins, bf, size, ops);
 
 	printed = scnprintf(bf, size, "%-6.6s ", ins->name);
-	return printed + ins__scnprintf(ops->locked.ins, bf + printed,
+	return printed + ins__scnprintf(&ops->locked.ins, bf + printed,
 					size - printed, ops->locked.ops);
 }
 
 static void lock__delete(struct ins_operands *ops)
 {
-	struct ins *ins = ops->locked.ins;
+	struct ins *ins = &ops->locked.ins;
 
-	if (ins && ins->ops->free)
+	if (ins->ops && ins->ops->free)
 		ins->ops->free(ops->locked.ops);
 	else
 		ins__delete(ops->locked.ops);
@@ -425,8 +419,9 @@ static void ins__sort(struct arch *arch)
 	qsort(arch->instructions, nmemb, sizeof(struct ins), ins__cmp);
 }
 
-static struct ins *ins__find(struct arch *arch, const char *name)
+static struct ins_ops *ins__find(struct arch *arch, const char *name)
 {
+	struct ins *ins;
 	const int nmemb = arch->nr_instructions;
 
 	if (!arch->sorted_instructions) {
@@ -434,7 +429,8 @@ static struct ins *ins__find(struct arch *arch, const char *name)
 		arch->sorted_instructions = true;
 	}
 
-	return bsearch(name, arch->instructions, nmemb, sizeof(struct ins), ins__key_cmp);
+	ins = bsearch(name, arch->instructions, nmemb, sizeof(struct ins), ins__key_cmp);
+	return ins ? ins->ops : NULL;
 }
 
 static int arch__key_cmp(const void *name, const void *archp)
@@ -691,19 +687,16 @@ int hist_entry__inc_addr_samples(struct hist_entry *he, int evidx, u64 ip)
 
 static void disasm_line__init_ins(struct disasm_line *dl, struct arch *arch, struct map *map)
 {
-	dl->ins = ins__find(arch, dl->name);
-
-	if (dl->ins == NULL)
-		return;
+	dl->ins.ops = ins__find(arch, dl->ins.name);
 
-	if (!dl->ins->ops)
+	if (!dl->ins.ops)
 		return;
 
-	if (dl->ins->ops->parse && dl->ins->ops->parse(arch, &dl->ops, map) < 0)
-		dl->ins = NULL;
+	if (dl->ins.ops->parse && dl->ins.ops->parse(arch, &dl->ops, map) < 0)
+		dl->ins.ops = NULL;
 }
 
-static int disasm_line__parse(char *line, char **namep, char **rawp)
+static int disasm_line__parse(char *line, const char **namep, char **rawp)
 {
 	char *name = line, tmp;
 
@@ -736,7 +729,8 @@ static int disasm_line__parse(char *line, char **namep, char **rawp)
 	return 0;
 
 out_free_name:
-	zfree(namep);
+	free((void *)namep);
+	*namep = NULL;
 	return -1;
 }
 
@@ -755,7 +749,7 @@ static struct disasm_line *disasm_line__new(s64 offset, char *line,
 			goto out_delete;
 
 		if (offset != -1) {
-			if (disasm_line__parse(dl->line, &dl->name, &dl->ops.raw) < 0)
+			if (disasm_line__parse(dl->line, &dl->ins.name, &dl->ops.raw) < 0)
 				goto out_free_line;
 
 			disasm_line__init_ins(dl, arch, map);
@@ -774,20 +768,21 @@ static struct disasm_line *disasm_line__new(s64 offset, char *line,
 void disasm_line__free(struct disasm_line *dl)
 {
 	zfree(&dl->line);
-	zfree(&dl->name);
-	if (dl->ins && dl->ins->ops->free)
-		dl->ins->ops->free(&dl->ops);
+	if (dl->ins.ops && dl->ins.ops->free)
+		dl->ins.ops->free(&dl->ops);
 	else
 		ins__delete(&dl->ops);
+	free((void *)dl->ins.name);
+	dl->ins.name = NULL;
 	free(dl);
 }
 
 int disasm_line__scnprintf(struct disasm_line *dl, char *bf, size_t size, bool raw)
 {
-	if (raw || !dl->ins)
-		return scnprintf(bf, size, "%-6.6s %s", dl->name, dl->ops.raw);
+	if (raw || !dl->ins.ops)
+		return scnprintf(bf, size, "%-6.6s %s", dl->ins.name, dl->ops.raw);
 
-	return ins__scnprintf(dl->ins, bf, size, &dl->ops);
+	return ins__scnprintf(&dl->ins, bf, size, &dl->ops);
 }
 
 static void disasm__add(struct list_head *head, struct disasm_line *line)
@@ -1143,7 +1138,7 @@ static int symbol__parse_objdump_line(struct symbol *sym, struct map *map,
 					map__rip_2objdump(map, sym->start);
 
 	/* kcore has no symbols, so add the call target name */
-	if (dl->ins && ins__is_call(dl->ins) && !dl->ops.target.name) {
+	if (dl->ins.ops && ins__is_call(&dl->ins) && !dl->ops.target.name) {
 		struct addr_map_symbol target = {
 			.map = map,
 			.addr = dl->ops.target.addr,
@@ -1173,8 +1168,8 @@ static void delete_last_nop(struct symbol *sym)
 	while (!list_empty(list)) {
 		dl = list_entry(list->prev, struct disasm_line, node);
 
-		if (dl->ins && dl->ins->ops) {
-			if (dl->ins->ops != &nop_ops)
+		if (dl->ins.ops) {
+			if (dl->ins.ops != &nop_ops)
 				return;
 		} else {
 			if (!strstr(dl->line, " nop ") &&
@@ -1767,7 +1762,7 @@ static size_t disasm_line__fprintf(struct disasm_line *dl, FILE *fp)
 	if (dl->offset == -1)
 		return fprintf(fp, "%s\n", dl->line);
 
-	printed = fprintf(fp, "%#" PRIx64 " %s", dl->offset, dl->name);
+	printed = fprintf(fp, "%#" PRIx64 " %s", dl->offset, dl->ins.name);
 
 	if (dl->ops.raw[0] != '\0') {
 		printed += fprintf(fp, "%.*s %s\n", 6 - (int)printed, " ",
diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
index 8e490b5c91bc..87e4cadc5d27 100644
--- a/tools/perf/util/annotate.h
+++ b/tools/perf/util/annotate.h
@@ -11,7 +11,12 @@
 #include <linux/rbtree.h>
 #include <pthread.h>
 
-struct ins;
+struct ins_ops;
+
+struct ins {
+	const char     *name;
+	struct ins_ops *ops;
+};
 
 struct ins_operands {
 	char	*raw;
@@ -28,7 +33,7 @@ struct ins_operands {
 			u64	addr;
 		} source;
 		struct {
-			struct ins *ins;
+			struct ins	    ins;
 			struct ins_operands *ops;
 		} locked;
 	};
@@ -43,11 +48,6 @@ struct ins_ops {
 			 struct ins_operands *ops);
 };
 
-struct ins {
-	const char     *name;
-	struct ins_ops *ops;
-};
-
 bool ins__is_jump(const struct ins *ins);
 bool ins__is_call(const struct ins *ins);
 bool ins__is_ret(const struct ins *ins);
@@ -59,8 +59,7 @@ struct disasm_line {
 	struct list_head    node;
 	s64		    offset;
 	char		    *line;
-	char		    *name;
-	struct ins	    *ins;
+	struct ins	    ins;
 	int		    line_nr;
 	float		    ipc;
 	u64		    cycles;
-- 
2.7.4

[PATCH 02/12] perf annotate: Introduce alternative method of keeping instructions table

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

Some arches may want to dynamically populate the table using regular
expressions on the instruction names to associate them with a set of
parsing/formatting/etc functions (struct ins_ops), so provide a fallback
for when the ins__find() method fails.

That fall back will be able to resize the arch->instructions, setting
arch->nr_instructions appropriately, helper functions to associate an
ins_ops to an instruction name, growing the arch->instructions if needed
and resorting it are provided, all the arch specific callback needs to
do is to decide if the missing instruction should be added to
arch->instructions with a ins_ops association.

Reviewed-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Chris Riyder <chris.ryder@arm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kim Phillips <kim.phillips@arm.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Taeung Song <treeze.taeung@gmail.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-auu13yradxf7g5dgtpnzt97a@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/annotate.c | 63 +++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 62 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index b48a39be071b..026915a7dac8 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -29,12 +29,15 @@ const char	*objdump_path;
 static regex_t	 file_lineno;
 
 static struct ins_ops *ins__find(struct arch *arch, const char *name);
+static void ins__sort(struct arch *arch);
 static int disasm_line__parse(char *line, const char **namep, char **rawp);
 
 struct arch {
 	const char	*name;
 	struct ins	*instructions;
 	size_t		nr_instructions;
+	size_t		nr_instructions_allocated;
+	struct ins_ops  *(*associate_instruction_ops)(struct arch *arch, const char *name);
 	bool		sorted_instructions;
 	struct		{
 		char comment_char;
@@ -50,6 +53,54 @@ static struct ins_ops nop_ops;
 static struct ins_ops lock_ops;
 static struct ins_ops ret_ops;
 
+static int arch__grow_instructions(struct arch *arch)
+{
+	struct ins *new_instructions;
+	size_t new_nr_allocated;
+
+	if (arch->nr_instructions_allocated == 0 && arch->instructions)
+		goto grow_from_non_allocated_table;
+
+	new_nr_allocated = arch->nr_instructions_allocated + 128;
+	new_instructions = realloc(arch->instructions, new_nr_allocated * sizeof(struct ins));
+	if (new_instructions == NULL)
+		return -1;
+
+out_update_instructions:
+	arch->instructions = new_instructions;
+	arch->nr_instructions_allocated = new_nr_allocated;
+	return 0;
+
+grow_from_non_allocated_table:
+	new_nr_allocated = arch->nr_instructions + 128;
+	new_instructions = calloc(new_nr_allocated, sizeof(struct ins));
+	if (new_instructions == NULL)
+		return -1;
+
+	memcpy(new_instructions, arch->instructions, arch->nr_instructions);
+	goto out_update_instructions;
+}
+
+static __maybe_unused int arch__associate_ins_ops(struct arch* arch, const char *name, struct ins_ops *ops)
+{
+	struct ins *ins;
+
+	if (arch->nr_instructions == arch->nr_instructions_allocated &&
+	    arch__grow_instructions(arch))
+		return -1;
+
+	ins = &arch->instructions[arch->nr_instructions];
+	ins->name = strdup(name);
+	if (!ins->name)
+		return -1;
+
+	ins->ops  = ops;
+	arch->nr_instructions++;
+
+	ins__sort(arch);
+	return 0;
+}
+
 #include "arch/arm/annotate/instructions.c"
 #include "arch/x86/annotate/instructions.c"
 
@@ -419,7 +470,7 @@ static void ins__sort(struct arch *arch)
 	qsort(arch->instructions, nmemb, sizeof(struct ins), ins__cmp);
 }
 
-static struct ins_ops *ins__find(struct arch *arch, const char *name)
+static struct ins_ops *__ins__find(struct arch *arch, const char *name)
 {
 	struct ins *ins;
 	const int nmemb = arch->nr_instructions;
@@ -433,6 +484,16 @@ static struct ins_ops *ins__find(struct arch *arch, const char *name)
 	return ins ? ins->ops : NULL;
 }
 
+static struct ins_ops *ins__find(struct arch *arch, const char *name)
+{
+	struct ins_ops *ops = __ins__find(arch, name);
+
+	if (!ops && arch->associate_instruction_ops)
+		ops = arch->associate_instruction_ops(arch, name);
+
+	return ops;
+}
+
 static int arch__key_cmp(const void *name, const void *archp)
 {
 	const struct arch *arch = archp;
-- 
2.7.4

[PATCH 03/12] perf annotate: Allow arches to have a init routine and a priv area

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

Arches like ARM will want to use regular expressions when deciding what
instructions to associate with what ins_ops, provide infrastructure for
that.

Reviewed-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Chris Riyder <chris.ryder@arm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kim Phillips <kim.phillips@arm.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Taeung Song <treeze.taeung@gmail.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-7dmnk9el2ipu3nxog092k9z5@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/annotate.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 026915a7dac8..1e96549650d7 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -39,6 +39,9 @@ struct arch {
 	size_t		nr_instructions_allocated;
 	struct ins_ops  *(*associate_instruction_ops)(struct arch *arch, const char *name);
 	bool		sorted_instructions;
+	bool		initialized;
+	void		*priv;
+	int		(*init)(struct arch *arch);
 	struct		{
 		char comment_char;
 		char skip_functions_char;
@@ -1356,6 +1359,14 @@ int symbol__disassemble(struct symbol *sym, struct map *map, const char *arch_na
 	if (arch == NULL)
 		return -ENOTSUP;
 
+	if (arch->init) {
+		err = arch->init(arch);
+		if (err) {
+			pr_err("%s: failed to initialize %s arch priv area\n", __func__, arch->name);
+			return err;
+		}
+	}
+
 	pr_debug("%s: filename=%s, sym=%s, start=%#" PRIx64 ", end=%#" PRIx64 "\n", __func__,
 		 symfs_filename, sym->name, map->unmap_ip(map, sym->start),
 		 map->unmap_ip(map, sym->end));
-- 
2.7.4

[PATCH 04/12] perf annotate: Improve support for ARM

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

By using arch->init() to set up some regular expressions to associate
ins_ops to ARM instructions, ditching that old table that has
instructions not present on ARM.

Take advantage of having an arch->init() to hide more arm specific stuff
from the common code, like the objdump details.

The regular expressions comes from a patch written by Kim Phillips.

Reviewed-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Chris Riyder <chris.ryder@arm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kim Phillips <kim.phillips@arm.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Taeung Song <treeze.taeung@gmail.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-77m7lufz9ajjimkrebtg5ead@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/arch/arm/annotate/instructions.c | 147 +++++++++++-----------------
 tools/perf/util/annotate.c                  |   9 +-
 2 files changed, 60 insertions(+), 96 deletions(-)

diff --git a/tools/perf/arch/arm/annotate/instructions.c b/tools/perf/arch/arm/annotate/instructions.c
index d67b8aa26274..1ce0872b1726 100644
--- a/tools/perf/arch/arm/annotate/instructions.c
+++ b/tools/perf/arch/arm/annotate/instructions.c
@@ -1,90 +1,59 @@
-static struct ins arm__instructions[] = {
-	{ .name = "add",	.ops = &mov_ops,  },
-	{ .name = "addl",	.ops = &mov_ops,  },
-	{ .name = "addq",	.ops = &mov_ops,  },
-	{ .name = "addw",	.ops = &mov_ops,  },
-	{ .name = "and",	.ops = &mov_ops,  },
-	{ .name = "b",		.ops = &jump_ops, }, // might also be a call
-	{ .name = "bcc",	.ops = &jump_ops, },
-	{ .name = "bcs",	.ops = &jump_ops, },
-	{ .name = "beq",	.ops = &jump_ops, },
-	{ .name = "bge",	.ops = &jump_ops, },
-	{ .name = "bgt",	.ops = &jump_ops, },
-	{ .name = "bhi",	.ops = &jump_ops, },
-	{ .name = "bl",		.ops = &call_ops, },
-	{ .name = "bls",	.ops = &jump_ops, },
-	{ .name = "blt",	.ops = &jump_ops, },
-	{ .name = "blx",	.ops = &call_ops, },
-	{ .name = "bne",	.ops = &jump_ops, },
-	{ .name = "bts",	.ops = &mov_ops,  },
-	{ .name = "call",	.ops = &call_ops, },
-	{ .name = "callq",	.ops = &call_ops, },
-	{ .name = "cmp",	.ops = &mov_ops,  },
-	{ .name = "cmpb",	.ops = &mov_ops,  },
-	{ .name = "cmpl",	.ops = &mov_ops,  },
-	{ .name = "cmpq",	.ops = &mov_ops,  },
-	{ .name = "cmpw",	.ops = &mov_ops,  },
-	{ .name = "cmpxch",	.ops = &mov_ops,  },
-	{ .name = "dec",	.ops = &dec_ops,  },
-	{ .name = "decl",	.ops = &dec_ops,  },
-	{ .name = "imul",	.ops = &mov_ops,  },
-	{ .name = "inc",	.ops = &dec_ops,  },
-	{ .name = "incl",	.ops = &dec_ops,  },
-	{ .name = "ja",		.ops = &jump_ops, },
-	{ .name = "jae",	.ops = &jump_ops, },
-	{ .name = "jb",		.ops = &jump_ops, },
-	{ .name = "jbe",	.ops = &jump_ops, },
-	{ .name = "jc",		.ops = &jump_ops, },
-	{ .name = "jcxz",	.ops = &jump_ops, },
-	{ .name = "je",		.ops = &jump_ops, },
-	{ .name = "jecxz",	.ops = &jump_ops, },
-	{ .name = "jg",		.ops = &jump_ops, },
-	{ .name = "jge",	.ops = &jump_ops, },
-	{ .name = "jl",		.ops = &jump_ops, },
-	{ .name = "jle",	.ops = &jump_ops, },
-	{ .name = "jmp",	.ops = &jump_ops, },
-	{ .name = "jmpq",	.ops = &jump_ops, },
-	{ .name = "jna",	.ops = &jump_ops, },
-	{ .name = "jnae",	.ops = &jump_ops, },
-	{ .name = "jnb",	.ops = &jump_ops, },
-	{ .name = "jnbe",	.ops = &jump_ops, },
-	{ .name = "jnc",	.ops = &jump_ops, },
-	{ .name = "jne",	.ops = &jump_ops, },
-	{ .name = "jng",	.ops = &jump_ops, },
-	{ .name = "jnge",	.ops = &jump_ops, },
-	{ .name = "jnl",	.ops = &jump_ops, },
-	{ .name = "jnle",	.ops = &jump_ops, },
-	{ .name = "jno",	.ops = &jump_ops, },
-	{ .name = "jnp",	.ops = &jump_ops, },
-	{ .name = "jns",	.ops = &jump_ops, },
-	{ .name = "jnz",	.ops = &jump_ops, },
-	{ .name = "jo",		.ops = &jump_ops, },
-	{ .name = "jp",		.ops = &jump_ops, },
-	{ .name = "jpe",	.ops = &jump_ops, },
-	{ .name = "jpo",	.ops = &jump_ops, },
-	{ .name = "jrcxz",	.ops = &jump_ops, },
-	{ .name = "js",		.ops = &jump_ops, },
-	{ .name = "jz",		.ops = &jump_ops, },
-	{ .name = "lea",	.ops = &mov_ops,  },
-	{ .name = "lock",	.ops = &lock_ops, },
-	{ .name = "mov",	.ops = &mov_ops,  },
-	{ .name = "movb",	.ops = &mov_ops,  },
-	{ .name = "movdqa",	.ops = &mov_ops,  },
-	{ .name = "movl",	.ops = &mov_ops,  },
-	{ .name = "movq",	.ops = &mov_ops,  },
-	{ .name = "movslq",	.ops = &mov_ops,  },
-	{ .name = "movzbl",	.ops = &mov_ops,  },
-	{ .name = "movzwl",	.ops = &mov_ops,  },
-	{ .name = "nop",	.ops = &nop_ops,  },
-	{ .name = "nopl",	.ops = &nop_ops,  },
-	{ .name = "nopw",	.ops = &nop_ops,  },
-	{ .name = "or",		.ops = &mov_ops,  },
-	{ .name = "orl",	.ops = &mov_ops,  },
-	{ .name = "test",	.ops = &mov_ops,  },
-	{ .name = "testb",	.ops = &mov_ops,  },
-	{ .name = "testl",	.ops = &mov_ops,  },
-	{ .name = "xadd",	.ops = &mov_ops,  },
-	{ .name = "xbeginl",	.ops = &jump_ops, },
-	{ .name = "xbeginq",	.ops = &jump_ops, },
-	{ .name = "retq",	.ops = &ret_ops,  },
+#include <sys/types.h>
+#include <regex.h>
+
+struct arm_annotate {
+	regex_t call_insn,
+		jump_insn;
 };
+
+static struct ins_ops *arm__associate_instruction_ops(struct arch *arch, const char *name)
+{
+	struct arm_annotate *arm = arch->priv;
+	struct ins_ops *ops;
+	regmatch_t match[2];
+
+	if (!regexec(&arm->call_insn, name, 2, match, 0))
+		ops = &call_ops;
+	else if (!regexec(&arm->jump_insn, name, 2, match, 0))
+		ops = &jump_ops;
+	else
+		return NULL;
+
+	arch__associate_ins_ops(arch, name, ops);
+	return ops;
+}
+
+static int arm__annotate_init(struct arch *arch)
+{
+	struct arm_annotate *arm;
+	int err;
+
+	if (arch->initialized)
+		return 0;
+
+	arm = zalloc(sizeof(*arm));
+	if (!arm)
+		return -1;
+
+#define ARM_CONDS "(cc|cs|eq|ge|gt|hi|le|ls|lt|mi|ne|pl|vc|vs)"
+	err = regcomp(&arm->call_insn, "^blx?" ARM_CONDS "?$", REG_EXTENDED);
+	if (err)
+		goto out_free_arm;
+	err = regcomp(&arm->jump_insn, "^bx?" ARM_CONDS "?$", REG_EXTENDED);
+	if (err)
+		goto out_free_call;
+#undef ARM_CONDS
+
+	arch->initialized = true;
+	arch->priv	  = arm;
+	arch->associate_instruction_ops   = arm__associate_instruction_ops;
+	arch->objdump.comment_char	  = ';';
+	arch->objdump.skip_functions_char = '+';
+	return 0;
+
+out_free_call:
+	regfree(&arm->call_insn);
+out_free_arm:
+	free(arm);
+	return -1;
+}
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 1e96549650d7..bad44db7dd67 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -84,7 +84,7 @@ static int arch__grow_instructions(struct arch *arch)
 	goto out_update_instructions;
 }
 
-static __maybe_unused int arch__associate_ins_ops(struct arch* arch, const char *name, struct ins_ops *ops)
+static int arch__associate_ins_ops(struct arch* arch, const char *name, struct ins_ops *ops)
 {
 	struct ins *ins;
 
@@ -110,12 +110,7 @@ static __maybe_unused int arch__associate_ins_ops(struct arch* arch, const char
 static struct arch architectures[] = {
 	{
 		.name = "arm",
-		.instructions = arm__instructions,
-		.nr_instructions = ARRAY_SIZE(arm__instructions),
-		.objdump =  {
-			.comment_char = ';',
-			.skip_functions_char = '+',
-		},
+		.init = arm__annotate_init,
 	},
 	{
 		.name = "x86",
-- 
2.7.4

[PATCH 05/12] perf annotate: Initial PowerPC support

[Arnaldo Carvalho de Melo]

From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>

Support the PowerPC architecture using the ins_ops association
method.

Committer notes:

Testing it with a perf.data file collected on a PowerPC machine and
cross-annotated on a x86_64 workstation, using the associated vmlinux
file:

$ perf report -i perf.data.f22vm.powerdev --vmlinux vmlinux.powerpc
  .ktime_get  vmlinux.powerpc
        │      clrldi r9,r28,63
   8.57 │   ┌──bne    e0                   <- TUI cursor positioned here
        │54:│  lwsync
   2.86 │   │  std    r2,40(r1)
        │   │  ld     r9,144(r31)
        │   │  ld     r3,136(r31)
        │   │  ld     r30,184(r31)
        │   │  ld     r10,0(r9)
        │   │  mtctr  r10
        │   │  ld     r2,8(r9)
   8.57 │   │→ bctrl
        │   │  ld     r2,40(r1)
        │   │  ld     r10,160(r31)
        │   │  ld     r5,152(r31)
        │   │  lwz    r7,168(r31)
        │   │  ld     r9,176(r31)
   8.57 │   │  lwz    r6,172(r31)
        │   │  lwsync
   2.86 │   │  lwz    r8,128(r31)
        │   │  cmpw   cr7,r8,r28
   2.86 │   │↑ bne    48
        │   │  subf   r10,r10,r3
        │   │  mr     r3,r29
        │   │  and    r10,r10,r5
   2.86 │   │  mulld  r10,r10,r7
        │   │  add    r9,r10,r9
        │   │  srd    r9,r9,r6
        │   │  add    r9,r9,r30
        │   │  std    r9,0(r29)
        │   │  addi   r1,r1,144
        │   │  ld     r0,16(r1)
        │   │  ld     r28,-32(r1)
        │   │  ld     r29,-24(r1)
        │   │  ld     r30,-16(r1)
        │   │  mtlr   r0
        │   │  ld     r31,-8(r1)
        │   │← blr
   5.71 │e0:└─→mr     r1,r1
  11.43 │      mr     r2,r2
  11.43 │      lwz    r28,128(r31)
  Press 'h' for help on key bindings

  $ perf report -i perf.data.f22vm.powerdev --header-only
  # ========
  # captured on: Thu Nov 24 12:40:38 2016
  # hostname : pdev-f22-qemu
  # os release : 4.4.10-200.fc22.ppc64
  # perf version : 4.9.rc1.g6298ce
  # arch : ppc64
  # nrcpus online : 48
  # nrcpus avail : 48
  # cpudesc : POWER7 (architected), altivec supported
  # cpuid : 74,513
  # total memory : 4158976 kB
  # cmdline : /home/ravi/Workspace/linux/tools/perf/perf record -a
  # event : name = cycles:ppp, , size = 112, { sample_period, sample_freq } = 4000, sample_type = IP|TID|TIME|CPU|PERIOD, disabled = 1, inherit = 1, mmap = 1, comm = 1, freq = 1, task = 1, precise_ip = 3, sample_id_all = 1, exclude_guest = 1, mmap2 = 1, comm_exec = 1
  # HEADER_CPU_TOPOLOGY info available, use -I to display
  # HEADER_NUMA_TOPOLOGY info available, use -I to display
  # pmu mappings: cpu = 4, software = 1, tracepoint = 2, breakpoint = 5
  # missing features: HEADER_TRACING_DATA HEADER_BRANCH_STACK HEADER_GROUP_DESC HEADER_AUXTRACE HEADER_STAT HEADER_CACHE
  # ========
  #
  $

Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Kim Phillips <kim.phillips@arm.com>
Link: http://lkml.kernel.org/n/tip-tbjnp40ddoxxl474uvhwi6g4@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/arch/powerpc/annotate/instructions.c | 58 +++++++++++++++++++++++++
 tools/perf/util/annotate.c                      |  5 +++
 2 files changed, 63 insertions(+)
 create mode 100644 tools/perf/arch/powerpc/annotate/instructions.c

diff --git a/tools/perf/arch/powerpc/annotate/instructions.c b/tools/perf/arch/powerpc/annotate/instructions.c
new file mode 100644
index 000000000000..3c4004db81b9
--- /dev/null
+++ b/tools/perf/arch/powerpc/annotate/instructions.c
@@ -0,0 +1,58 @@
+static struct ins_ops *powerpc__associate_instruction_ops(struct arch *arch, const char *name)
+{
+	int i;
+	struct ins_ops *ops;
+
+	/*
+	 * - Interested only if instruction starts with 'b'.
+	 * - Few start with 'b', but aren't branch instructions.
+	 */
+	if (name[0] != 'b'             ||
+	    !strncmp(name, "bcd", 3)   ||
+	    !strncmp(name, "brinc", 5) ||
+	    !strncmp(name, "bper", 4))
+		return NULL;
+
+	ops = &jump_ops;
+
+	i = strlen(name) - 1;
+	if (i < 0)
+		return NULL;
+
+	/* ignore optional hints at the end of the instructions */
+	if (name[i] == '+' || name[i] == '-')
+		i--;
+
+	if (name[i] == 'l' || (name[i] == 'a' && name[i-1] == 'l')) {
+		/*
+		 * if the instruction ends up with 'l' or 'la', then
+		 * those are considered 'calls' since they update LR.
+		 * ... except for 'bnl' which is branch if not less than
+		 * and the absolute form of the same.
+		 */
+		if (strcmp(name, "bnl") && strcmp(name, "bnl+") &&
+		    strcmp(name, "bnl-") && strcmp(name, "bnla") &&
+		    strcmp(name, "bnla+") && strcmp(name, "bnla-"))
+			ops = &call_ops;
+	}
+	if (name[i] == 'r' && name[i-1] == 'l')
+		/*
+		 * instructions ending with 'lr' are considered to be
+		 * return instructions
+		 */
+		ops = &ret_ops;
+
+	arch__associate_ins_ops(arch, name, ops);
+	return ops;
+}
+
+static int powerpc__annotate_init(struct arch *arch)
+{
+	if (!arch->initialized) {
+		arch->initialized = true;
+		arch->associate_instruction_ops = powerpc__associate_instruction_ops;
+		arch->objdump.comment_char      = '#';
+	}
+
+	return 0;
+}
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index bad44db7dd67..3e34ee0fde28 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -106,6 +106,7 @@ static int arch__associate_ins_ops(struct arch* arch, const char *name, struct i
 
 #include "arch/arm/annotate/instructions.c"
 #include "arch/x86/annotate/instructions.c"
+#include "arch/powerpc/annotate/instructions.c"
 
 static struct arch architectures[] = {
 	{
@@ -120,6 +121,10 @@ static struct arch architectures[] = {
 			.comment_char = '#',
 		},
 	},
+	{
+		.name = "powerpc",
+		.init = powerpc__annotate_init,
+	},
 };
 
 static void ins__delete(struct ins_operands *ops)
-- 
2.7.4

[PATCH 06/12] perf callchain: Add option to skip ignore symbol when printing callchains

[Arnaldo Carvalho de Melo]

From: Namhyung Kim <namhyung@kernel.org>

For tracepoint events, callchains always contain certain functions.
Sometimes it'd be better to skip those functions as they have no value.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/20161124011114.7102-2-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-sched.c      | 3 ++-
 tools/perf/util/evsel.h         | 1 +
 tools/perf/util/evsel_fprintf.c | 7 ++++++-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 829468defa07..43fcc13e402d 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1876,7 +1876,8 @@ static void timehist_print_sample(struct perf_sched *sched,
 
 	sample__fprintf_sym(sample, al, 0,
 			    EVSEL__PRINT_SYM | EVSEL__PRINT_ONELINE |
-			    EVSEL__PRINT_CALLCHAIN_ARROW,
+			    EVSEL__PRINT_CALLCHAIN_ARROW |
+			    EVSEL__PRINT_SKIP_IGNORED,
 			    &callchain_cursor, stdout);
 
 out:
diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
index 27fa3a343577..6abb89cd27f9 100644
--- a/tools/perf/util/evsel.h
+++ b/tools/perf/util/evsel.h
@@ -392,6 +392,7 @@ int perf_evsel__fprintf(struct perf_evsel *evsel,
 #define EVSEL__PRINT_SRCLINE		(1<<5)
 #define EVSEL__PRINT_UNKNOWN_AS_ADDR	(1<<6)
 #define EVSEL__PRINT_CALLCHAIN_ARROW	(1<<7)
+#define EVSEL__PRINT_SKIP_IGNORED	(1<<8)
 
 struct callchain_cursor;
 
diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c
index 53bb614feafb..5a6f52284452 100644
--- a/tools/perf/util/evsel_fprintf.c
+++ b/tools/perf/util/evsel_fprintf.c
@@ -109,6 +109,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,
 	int print_srcline = print_opts & EVSEL__PRINT_SRCLINE;
 	int print_unknown_as_addr = print_opts & EVSEL__PRINT_UNKNOWN_AS_ADDR;
 	int print_arrow = print_opts & EVSEL__PRINT_CALLCHAIN_ARROW;
+	int print_skip_ignored = print_opts & EVSEL__PRINT_SKIP_IGNORED;
 	char s = print_oneline ? ' ' : '\t';
 	bool first = true;
 
@@ -124,6 +125,9 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,
 			if (!node)
 				break;
 
+			if (node->sym && node->sym->ignore && print_skip_ignored)
+				goto next;
+
 			printed += fprintf(fp, "%-*.*s", left_alignment, left_alignment, " ");
 
 			if (print_arrow && !first)
@@ -162,8 +166,9 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,
 			if (!print_oneline)
 				printed += fprintf(fp, "\n");
 
-			callchain_cursor_advance(cursor);
 			first = false;
+next:
+			callchain_cursor_advance(cursor);
 		}
 	}
 
-- 
2.7.4

[PATCH 07/12] perf sched timehist: Mark schedule function in callchains

[Arnaldo Carvalho de Melo]

From: Namhyung Kim <namhyung@kernel.org>

The sched_switch event always captured from the scheduler function.  So
it'd be great omit them from the callchain.  This patch marks the
functions to be omitted by later patch.

Committer notes:

Testing it:

Before:

  [root@jouet experimental]# perf sched record -g ls
  Dockerfile  perf.data  x-mips64
  [ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 1.355 MB perf.data (29 samples) ]
  [root@jouet experimental]# perf sched timehist
      time  cpu  task name         wait time sch delay run time
                 [tid/pid]             (msec) (msec) (msec)
  ----------- -----  ----------------- ------ ------ ------
  6.494998 [001] <idle>                0.000  0.000  0.000
  6.495027 [002] perf[519]             0.000  0.000  0.000 __schedule <- schedule <- schedule_hrtimeout_range_clock <- schedule_hrtimeou
  6.495096 [003] <idle>                0.000  0.000  0.000
  6.495100 [003] rcuos/0[9]            0.000  0.005  0.003 __schedule <- schedule <- rcu_nocb_kthread <- kthread <- ret_from_fork
  6.495113 [001] perf[520]             0.000  0.008  0.114 __schedule <- preempt_schedule_common <- _cond_resched <- wait_for_completion
  6.495121 [000] <idle>                0.000  0.000  0.000
  6.495129 [001] migration/1[17]       0.000  0.003  0.016 __schedule <- schedule <- smpboot_thread_fn <- kthread <- ret_from_fork
  6.496085 [002] <idle>                0.000  0.000  1.057
  6.496096 [002] kworker/u16:1[31169]  0.000  0.004  0.011 __schedule <- schedule <- worker_thread <- kthread <- ret_from_fork
  6.496096 [003] <idle>                0.003  0.000  0.996
  6.496169 [002] <idle>                0.011  0.000  0.072
  6.496171 [000] ls[520]               0.008  0.000  1.049 __schedule <- schedule <- do_exit <- do_group_exit <- [unknown]
  6.496172 [003] gnome-terminal-[4391] 0.000  0.003  0.076 __schedule <- schedule <- schedule_hrtimeout_range_clock <- schedule_hrtimeo

After:

  [root@jouet experimental]# perf sched timehist
      time  cpu  task name         wait time sch delay run time
                 [tid/pid]            (msec)  (msec)  (msec)
  ----------- -----  ----------------- -----  -----  ------
  6.494998 [001] <idle>                0.000  0.000  0.000
  6.495027 [002] perf[519]             0.000  0.000  0.000 schedule_hrtimeout_range_clock <- schedule_hrtimeout_range <- poll_schedule_t
  6.495096 [003] <idle>                0.000  0.000  0.000
  6.495100 [003] rcuos/0[9]            0.000  0.005  0.003 rcu_nocb_kthread <- kthread <- ret_from_fork
  6.495113 [001] perf[520]             0.000  0.008  0.114 preempt_schedule_common <- _cond_resched <- wait_for_completion <- stop_one_c
  6.495121 [000] <idle>                0.000  0.000  0.000
  6.495129 [001] migration/1[17]       0.000  0.003  0.016 smpboot_thread_fn <- kthread <- ret_from_fork
  6.496085 [002] <idle>                0.000  0.000  1.057
  6.496096 [002] kworker/u16:1[31169]  0.000  0.004  0.011 worker_thread <- kthread <- ret_from_fork
  6.496096 [003] <idle>                0.003  0.000  0.996
  6.496169 [002] <idle>                0.011  0.000  0.072
  6.496171 [000] ls[520]               0.008  0.000  1.049 do_exit <- do_group_exit <- [unknown]
  6.496172 [003] gnome-terminal-[4391] 0.000  0.003  0.076 schedule_hrtimeout_range_clock <- schedule_hrtimeout_range <- poll_schedule_
  [root@jouet experimental]#

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/20161124011114.7102-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-sched.c | 21 +++++++++++++++++++++
 tools/perf/util/symbol.h   |  1 +
 2 files changed, 22 insertions(+)

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 43fcc13e402d..06be809a02ab 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1966,7 +1966,28 @@ static bool is_idle_sample(struct perf_sched *sched,
 
 		return false;
 	}
+
 	callchain_cursor_commit(cursor);
+
+	while (true) {
+		struct callchain_cursor_node *node;
+		struct symbol *sym;
+
+		node = callchain_cursor_current(cursor);
+		if (node == NULL)
+			break;
+
+		sym = node->sym;
+		if (sym && sym->name) {
+			if (!strcmp(sym->name, "schedule") ||
+			    !strcmp(sym->name, "__schedule") ||
+			    !strcmp(sym->name, "preempt_schedule"))
+				sym->ignore = 1;
+		}
+
+		callchain_cursor_advance(cursor);
+	}
+
 	return false;
 }
 
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
index dec7e2d44885..1bcbefc0c325 100644
--- a/tools/perf/util/symbol.h
+++ b/tools/perf/util/symbol.h
@@ -58,6 +58,7 @@ struct symbol {
 	u16		namelen;
 	u8		binding;
 	u8		idle:1;
+	u8		ignore:1;
 	u8		arch_sym;
 	char		name[0];
 };
-- 
2.7.4

[PATCH 08/12] perf sched timehist: Enlarge max stack depth by 2

[Arnaldo Carvalho de Melo]

From: Namhyung Kim <namhyung@kernel.org>

When it records callchains, they will always have 2 scheduler functions
(__schedule + schedule or __schedule + preempt_schedule) and get
ignored.  So it should collect 2 more functions to show the expected
number of callchains to user.

Committer Notes:

Example of final result, using the same perf.data file as in the
previous cset comment, but this time redirecting the output of 'perf
sched timehist' to a file instead of copy'n'pasting from xterm:

  [root@jouet experimental]# perf sched timehist > /tmp/bla
  [root@jouet experimental]# cat /tmp/bla
      time  cpu task name        wait time sch delay run time
                 [tid/pid]            (msec) (msec) (msec)
  -------- ----  -------------------- ------ ------ -----
  6.494998 [01] <idle>                0.000  0.000  0.000
  6.495027 [02] perf[519]             0.000  0.000  0.000 schedule_hrtimeout_range_clock <- schedule_hrtimeout_range <- poll_schedule_timeout <- do_sys_poll <- sys_poll
  6.495096 [03] <idle>                0.000  0.000  0.000
  6.495100 [03] rcuos/0[9]            0.000  0.005  0.003 rcu_nocb_kthread <- kthread <- ret_from_fork
  6.495113 [01] perf[520]             0.000  0.008  0.114 preempt_schedule_common <- _cond_resched <- wait_for_completion <- stop_one_cpu <- sched_exec <- do_execveat_common.isra.35
  6.495121 [00] <idle>                0.000  0.000  0.000
  6.495129 [01] migration/1[17]       0.000  0.003  0.016 smpboot_thread_fn <- kthread <- ret_from_fork
  6.496085 [02] <idle>                0.000  0.000  1.057
  6.496096 [02] kworker/u16:1[31169]  0.000  0.004  0.011 worker_thread <- kthread <- ret_from_fork
  6.496096 [03] <idle>                0.003  0.000  0.996
  6.496169 [02] <idle>                0.011  0.000  0.072
  6.496171 [00] ls[520]               0.008  0.000  1.049 do_exit <- do_group_exit <- [unknown] <- entry_SYSCALL_64_fastpath
  6.496172 [03] gnome-terminal-[4391] 0.000  0.003  0.076 schedule_hrtimeout_range_clock <- schedule_hrtimeout_range <- poll_schedule_timeout <- do_sys_poll <- sys_poll

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/20161124011114.7102-3-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 06be809a02ab..a49a032f5b15 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1960,7 +1960,7 @@ static bool is_idle_sample(struct perf_sched *sched,
 		return false;
 
 	if (thread__resolve_callchain(thread, cursor, evsel, sample,
-				      NULL, NULL, sched->max_stack) != 0) {
+				      NULL, NULL, sched->max_stack + 2) != 0) {
 		if (verbose)
 			error("Failed to resolve callchain. Skipping\n");
 
-- 
2.7.4

[PATCH 09/12] perf tools: Fix kernel version error in ubuntu

[Arnaldo Carvalho de Melo]

From: Wang Nan <wangnan0@huawei.com>

On ubuntu the internal kernel version code is different from what can
be retrived from uname:

 $ uname -r
 4.4.0-47-generic
 $ cat /lib/modules/`uname -r`/build/include/generated/uapi/linux/version.h
 #define LINUX_VERSION_CODE 263192
 #define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))
 $ cat /lib/modules/`uname -r`/build/include/generated/utsrelease.h
 #define UTS_RELEASE "4.4.0-47-generic"
 #define UTS_UBUNTU_RELEASE_ABI 47
 $ cat /proc/version_signature
 Ubuntu 4.4.0-47.68-generic 4.4.24

The macro LINUX_VERSION_CODE is set to 4.4.24 (263192 == 0x40418), but
`uname -r` reports 4.4.0.

This mismatch causes LINUX_VERSION_CODE macro passed to BPF script become
an incorrect value, results in magic failure in BPF loading:

 $ sudo ./buildperf/perf record -e ./tools/perf/tests/bpf-script-example.c ls
 event syntax error: './tools/perf/tests/bpf-script-example.c'
                      \___ Failed to load program for unknown reason

According to Ubuntu document (https://wiki.ubuntu.com/Kernel/FAQ), the
correct kernel version can be retrived through /proc/version_signature, which
is ubuntu specific.

This patch checks the existance of /proc/version_signature, and returns
version number through parsing this file instead of uname. Version string
is untouched (value returns from uname) because `uname -r` is required
to be consistence with path of kbuild directory in /lib/module.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Alexei Starovoitov <ast@fb.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/20161115040617.69788-2-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/util.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 53 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index 5bbd1f609f1f..67ac765da27a 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -637,12 +637,63 @@ bool find_process(const char *name)
 	return ret ? false : true;
 }
 
+static int
+fetch_ubuntu_kernel_version(unsigned int *puint)
+{
+	ssize_t len;
+	size_t line_len = 0;
+	char *ptr, *line = NULL;
+	int version, patchlevel, sublevel, err;
+	FILE *vsig = fopen("/proc/version_signature", "r");
+
+	if (!vsig) {
+		pr_debug("Open /proc/version_signature failed: %s\n",
+			 strerror(errno));
+		return -1;
+	}
+
+	len = getline(&line, &line_len, vsig);
+	fclose(vsig);
+	err = -1;
+	if (len <= 0) {
+		pr_debug("Reading from /proc/version_signature failed: %s\n",
+			 strerror(errno));
+		goto errout;
+	}
+
+	ptr = strrchr(line, ' ');
+	if (!ptr) {
+		pr_debug("Parsing /proc/version_signature failed: %s\n", line);
+		goto errout;
+	}
+
+	err = sscanf(ptr + 1, "%d.%d.%d",
+		     &version, &patchlevel, &sublevel);
+	if (err != 3) {
+		pr_debug("Unable to get kernel version from /proc/version_signature '%s'\n",
+			 line);
+		goto errout;
+	}
+
+	if (puint)
+		*puint = (version << 16) + (patchlevel << 8) + sublevel;
+	err = 0;
+errout:
+	free(line);
+	return err;
+}
+
 int
 fetch_kernel_version(unsigned int *puint, char *str,
 		     size_t str_size)
 {
 	struct utsname utsname;
 	int version, patchlevel, sublevel, err;
+	bool int_ver_ready = false;
+
+	if (access("/proc/version_signature", R_OK) == 0)
+		if (!fetch_ubuntu_kernel_version(puint))
+			int_ver_ready = true;
 
 	if (uname(&utsname))
 		return -1;
@@ -656,12 +707,12 @@ fetch_kernel_version(unsigned int *puint, char *str,
 		     &version, &patchlevel, &sublevel);
 
 	if (err != 3) {
-		pr_debug("Unablt to get kernel version from uname '%s'\n",
+		pr_debug("Unable to get kernel version from uname '%s'\n",
 			 utsname.release);
 		return -1;
 	}
 
-	if (puint)
+	if (puint && !int_ver_ready)
 		*puint = (version << 16) + (patchlevel << 8) + sublevel;
 	return 0;
 }
-- 
2.7.4

[PATCH 10/12] perf record: Fix segfault when running with suid and kptr_restrict is 1

[Arnaldo Carvalho de Melo]

From: Wang Nan <wangnan0@huawei.com>

Before this patch perf panics if kptr_restrict is set to 1 and perf is
owned by root with suid set:

  $ whoami
  wangnan
  $ ls -l ./perf
  -rwsr-xr-x 1 root root 19781908 Sep 21 19:29 /home/wangnan/perf
  $ cat /proc/sys/kernel/kptr_restrict
  1
  $ cat /proc/sys/kernel/perf_event_paranoid
  -1
  $ ./perf record -a
  Segmentation fault (core dumped)
  $

The reason is that perf assumes it is allowed to read kptr from
/proc/kallsyms when euid is root, but in fact the kernel doesn't allow
reading kptr when euid and uid do not match with each other:

  $ cp /bin/cat .
  $ sudo chown root:root ./cat
  $ sudo chmod u+s ./cat
  $ cat /proc/kallsyms | grep do_fork
  0000000000000000 T _do_fork          <--- kptr is hidden even euid is root
  $ sudo cat /proc/kallsyms | grep do_fork
  ffffffff81080230 T _do_fork

See lib/vsprintf.c for kernel side code.

This patch fixes this problem by checking both uid and euid.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexei Starovoitov <ast@fb.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/20161115040617.69788-3-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/symbol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index aecff69a510d..420ada9de22f 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1962,7 +1962,7 @@ static bool symbol__read_kptr_restrict(void)
 		char line[8];
 
 		if (fgets(line, sizeof(line), fp) != NULL)
-			value = (geteuid() != 0) ?
+			value = ((geteuid() != 0) || (getuid() != 0)) ?
 					(atoi(line) != 0) :
 					(atoi(line) == 2);
 
-- 
2.7.4

[PATCH 11/12] perf tools: Add missing struct definition in probe_event.h

[Arnaldo Carvalho de Melo]

From: Wang Nan <wangnan0@huawei.com>

Commit 0b3c2264ae30 ("perf symbols: Fix kallsyms perf test on ppc64le")
refers struct symbol in probe_event.h, but forgets to include its
definition.  Gcc will complain about it when that definition is not
added, by sheer luck, by some other header included before
probe_event.h.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Alexei Starovoitov <ast@fb.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/20161115040617.69788-4-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/probe-event.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/util/probe-event.h b/tools/perf/util/probe-event.h
index 8091d15113f7..5d4e94061402 100644
--- a/tools/perf/util/probe-event.h
+++ b/tools/perf/util/probe-event.h
@@ -18,6 +18,8 @@ struct probe_conf {
 extern struct probe_conf probe_conf;
 extern bool probe_event_dry_run;
 
+struct symbol;
+
 /* kprobe-tracer and uprobe-tracer tracing point */
 struct probe_trace_point {
 	char		*realname;	/* function real name (if needed) */
-- 
2.7.4

[PATCH 12/12] tools lib bpf: Fix maps resolution

[Arnaldo Carvalho de Melo]

From: Eric Leblond <eric@regit.org>

It is not correct to assimilate the elf data of the maps section to an
array of map definition. In fact the sizes differ. The offset provided
in the symbol section has to be used instead.

This patch fixes a bug causing a elf with two maps not to load
correctly.

Wang Nan added:

This patch requires a name for each BPF map, so array of BPF maps is not
allowed. This restriction is reasonable, because kernel verifier forbid
indexing BPF map from such array unless the index is a fixed value, but
if the index is fixed why not merging it into name?

For example:

Program like this:
  ...
  unsigned long cpu = get_smp_processor_id();
  int *pval = map_lookup_elem(&map_array[cpu], &key);
  ...

Generates bytecode like this:

0: (b7) r1 = 0
1: (63) *(u32 *)(r10 -4) = r1
2: (b7) r1 = 680997
3: (63) *(u32 *)(r10 -8) = r1
4: (85) call 8
5: (67) r0 <<= 4
6: (18) r1 = 0x112dd000
8: (0f) r0 += r1
9: (bf) r2 = r10
10: (07) r2 += -4
11: (bf) r1 = r0
12: (85) call 1

Where instruction 8 is the computation, 8 and 11 render r1 to an invalid
value for function map_lookup_elem, causes verifier report error.

Signed-off-by: Eric Leblond <eric@regit.org>
Cc: Alexei Starovoitov <ast@fb.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Wang Nan <wangnan0@huawei.com>
[ Merge bpf_object__init_maps_name into bpf_object__init_maps.
  Fix segfault for buggy BPF script Validate obj->maps ]
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/20161115040617.69788-5-wangnan0@huawei.com
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/lib/bpf/libbpf.c | 142 ++++++++++++++++++++++++++++++++++---------------
 1 file changed, 98 insertions(+), 44 deletions(-)

diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index b699aea9a025..96a2b2ff1212 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -185,6 +185,7 @@ struct bpf_program {
 struct bpf_map {
 	int fd;
 	char *name;
+	size_t offset;
 	struct bpf_map_def def;
 	void *priv;
 	bpf_map_clear_priv_t clear_priv;
@@ -513,57 +514,106 @@ bpf_object__init_kversion(struct bpf_object *obj,
 }
 
 static int
-bpf_object__init_maps(struct bpf_object *obj, void *data,
-		      size_t size)
+bpf_object__validate_maps(struct bpf_object *obj)
 {
-	size_t nr_maps;
 	int i;
 
-	nr_maps = size / sizeof(struct bpf_map_def);
-	if (!data || !nr_maps) {
-		pr_debug("%s doesn't need map definition\n",
-			 obj->path);
+	/*
+	 * If there's only 1 map, the only error case should have been
+	 * catched in bpf_object__init_maps().
+	 */
+	if (!obj->maps || !obj->nr_maps || (obj->nr_maps == 1))
 		return 0;
-	}
 
-	pr_debug("maps in %s: %zd bytes\n", obj->path, size);
+	for (i = 1; i < obj->nr_maps; i++) {
+		const struct bpf_map *a = &obj->maps[i - 1];
+		const struct bpf_map *b = &obj->maps[i];
 
-	obj->maps = calloc(nr_maps, sizeof(obj->maps[0]));
-	if (!obj->maps) {
-		pr_warning("alloc maps for object failed\n");
-		return -ENOMEM;
+		if (b->offset - a->offset < sizeof(struct bpf_map_def)) {
+			pr_warning("corrupted map section in %s: map \"%s\" too small\n",
+				   obj->path, a->name);
+			return -EINVAL;
+		}
 	}
-	obj->nr_maps = nr_maps;
-
-	for (i = 0; i < nr_maps; i++) {
-		struct bpf_map_def *def = &obj->maps[i].def;
+	return 0;
+}
 
-		/*
-		 * fill all fd with -1 so won't close incorrect
-		 * fd (fd=0 is stdin) when failure (zclose won't close
-		 * negative fd)).
-		 */
-		obj->maps[i].fd = -1;
+static int compare_bpf_map(const void *_a, const void *_b)
+{
+	const struct bpf_map *a = _a;
+	const struct bpf_map *b = _b;
 
-		/* Save map definition into obj->maps */
-		*def = ((struct bpf_map_def *)data)[i];
-	}
-	return 0;
+	return a->offset - b->offset;
 }
 
 static int
-bpf_object__init_maps_name(struct bpf_object *obj)
+bpf_object__init_maps(struct bpf_object *obj)
 {
-	int i;
+	int i, map_idx, nr_maps = 0;
+	Elf_Scn *scn;
+	Elf_Data *data;
 	Elf_Data *symbols = obj->efile.symbols;
 
-	if (!symbols || obj->efile.maps_shndx < 0)
+	if (obj->efile.maps_shndx < 0)
+		return -EINVAL;
+	if (!symbols)
+		return -EINVAL;
+
+	scn = elf_getscn(obj->efile.elf, obj->efile.maps_shndx);
+	if (scn)
+		data = elf_getdata(scn, NULL);
+	if (!scn || !data) {
+		pr_warning("failed to get Elf_Data from map section %d\n",
+			   obj->efile.maps_shndx);
 		return -EINVAL;
+	}
 
+	/*
+	 * Count number of maps. Each map has a name.
+	 * Array of maps is not supported: only the first element is
+	 * considered.
+	 *
+	 * TODO: Detect array of map and report error.
+	 */
 	for (i = 0; i < symbols->d_size / sizeof(GElf_Sym); i++) {
 		GElf_Sym sym;
-		size_t map_idx;
+
+		if (!gelf_getsym(symbols, i, &sym))
+			continue;
+		if (sym.st_shndx != obj->efile.maps_shndx)
+			continue;
+		nr_maps++;
+	}
+
+	/* Alloc obj->maps and fill nr_maps. */
+	pr_debug("maps in %s: %d maps in %zd bytes\n", obj->path,
+		 nr_maps, data->d_size);
+
+	if (!nr_maps)
+		return 0;
+
+	obj->maps = calloc(nr_maps, sizeof(obj->maps[0]));
+	if (!obj->maps) {
+		pr_warning("alloc maps for object failed\n");
+		return -ENOMEM;
+	}
+	obj->nr_maps = nr_maps;
+
+	/*
+	 * fill all fd with -1 so won't close incorrect
+	 * fd (fd=0 is stdin) when failure (zclose won't close
+	 * negative fd)).
+	 */
+	for (i = 0; i < nr_maps; i++)
+		obj->maps[i].fd = -1;
+
+	/*
+	 * Fill obj->maps using data in "maps" section.
+	 */
+	for (i = 0, map_idx = 0; i < symbols->d_size / sizeof(GElf_Sym); i++) {
+		GElf_Sym sym;
 		const char *map_name;
+		struct bpf_map_def *def;
 
 		if (!gelf_getsym(symbols, i, &sym))
 			continue;
@@ -573,21 +623,27 @@ bpf_object__init_maps_name(struct bpf_object *obj)
 		map_name = elf_strptr(obj->efile.elf,
 				      obj->efile.strtabidx,
 				      sym.st_name);
-		map_idx = sym.st_value / sizeof(struct bpf_map_def);
-		if (map_idx >= obj->nr_maps) {
-			pr_warning("index of map \"%s\" is buggy: %zu > %zu\n",
-				   map_name, map_idx, obj->nr_maps);
-			continue;
+		obj->maps[map_idx].offset = sym.st_value;
+		if (sym.st_value + sizeof(struct bpf_map_def) > data->d_size) {
+			pr_warning("corrupted maps section in %s: last map \"%s\" too small\n",
+				   obj->path, map_name);
+			return -EINVAL;
 		}
+
 		obj->maps[map_idx].name = strdup(map_name);
 		if (!obj->maps[map_idx].name) {
 			pr_warning("failed to alloc map name\n");
 			return -ENOMEM;
 		}
-		pr_debug("map %zu is \"%s\"\n", map_idx,
+		pr_debug("map %d is \"%s\"\n", map_idx,
 			 obj->maps[map_idx].name);
+		def = (struct bpf_map_def *)(data->d_buf + sym.st_value);
+		obj->maps[map_idx].def = *def;
+		map_idx++;
 	}
-	return 0;
+
+	qsort(obj->maps, obj->nr_maps, sizeof(obj->maps[0]), compare_bpf_map);
+	return bpf_object__validate_maps(obj);
 }
 
 static int bpf_object__elf_collect(struct bpf_object *obj)
@@ -645,11 +701,9 @@ static int bpf_object__elf_collect(struct bpf_object *obj)
 			err = bpf_object__init_kversion(obj,
 							data->d_buf,
 							data->d_size);
-		else if (strcmp(name, "maps") == 0) {
-			err = bpf_object__init_maps(obj, data->d_buf,
-						    data->d_size);
+		else if (strcmp(name, "maps") == 0)
 			obj->efile.maps_shndx = idx;
-		} else if (sh.sh_type == SHT_SYMTAB) {
+		else if (sh.sh_type == SHT_SYMTAB) {
 			if (obj->efile.symbols) {
 				pr_warning("bpf: multiple SYMTAB in %s\n",
 					   obj->path);
@@ -698,7 +752,7 @@ static int bpf_object__elf_collect(struct bpf_object *obj)
 		return LIBBPF_ERRNO__FORMAT;
 	}
 	if (obj->efile.maps_shndx >= 0)
-		err = bpf_object__init_maps_name(obj);
+		err = bpf_object__init_maps(obj);
 out:
 	return err;
 }
@@ -807,7 +861,7 @@ bpf_object__create_maps(struct bpf_object *obj)
 				zclose(obj->maps[j].fd);
 			return err;
 		}
-		pr_debug("create map: fd=%d\n", *pfd);
+		pr_debug("create map %s: fd=%d\n", obj->maps[i].name, *pfd);
 	}
 
 	return 0;
-- 
2.7.4

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> Test results at the end of this message.
> 
> The following changes since commit 47414424c53a70eceb0fc6e0a35a31a2b763d5b2:
> 
>   Merge tag 'perf-core-for-mingo-20161123' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-11-24 05:09:31 +0100)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161125
> 
> for you to fetch changes up to 4708bbda5cb2f6cdc331744597527143f46394d5:
> 
>   tools lib bpf: Fix maps resolution (2016-11-25 11:27:33 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> New features:
> 
> - Improve ARM support in the annotation code, affecting 'perf annotate', 'perf
>   report' and live annotation in 'perf top' (Kim Phillips)
> 
> - Initial support for PowerPC in the annotation code (Ravi Bangoria)
> 
> - Skip repetitive scheduler function on the top of the stack in
>   'perf sched timehist' (Namhyung Kim)
> 
> Fixes:
> 
> - Fix maps resolution in libbpf (Eric Leblond)
> 
> - Get the kernel signature via /proc/version_signature, available on
>   ubuntu systems, to make sure bpf proggies works, as the one provided
>   via 'uname -r' doesn't (Wang Nan)
> 
> - Fix segfault in 'perf record' when running with suid and kptr_restrict
>   is 1 (Wang Nan)
> 
> Infrastructure:
> 
> - Support per-arch instruction tables, kept via a static or dynamic table
>   (Arnaldo Carvalho de Melo)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (4):
>       perf annotate: Remove duplicate 'name' field from disasm_line
>       perf annotate: Introduce alternative method of keeping instructions table
>       perf annotate: Allow arches to have a init routine and a priv area
>       perf annotate: Improve support for ARM
> 
> Eric Leblond (1):
>       tools lib bpf: Fix maps resolution
> 
> Namhyung Kim (3):
>       perf callchain: Add option to skip ignore symbol when printing callchains
>       perf sched timehist: Mark schedule function in callchains
>       perf sched timehist: Enlarge max stack depth by 2
> 
> Ravi Bangoria (1):
>       perf annotate: Initial PowerPC support
> 
> Wang Nan (3):
>       perf tools: Fix kernel version error in ubuntu
>       perf record: Fix segfault when running with suid and kptr_restrict is 1
>       perf tools: Add missing struct definition in probe_event.h
> 
>  tools/lib/bpf/libbpf.c                          | 142 ++++++++++++++-------
>  tools/perf/arch/arm/annotate/instructions.c     | 147 +++++++++-------------
>  tools/perf/arch/powerpc/annotate/instructions.c |  58 +++++++++
>  tools/perf/builtin-sched.c                      |  26 +++-
>  tools/perf/ui/browsers/annotate.c               |  18 +--
>  tools/perf/util/annotate.c                      | 157 +++++++++++++++++-------
>  tools/perf/util/annotate.h                      |  17 ++-
>  tools/perf/util/evsel.h                         |   1 +
>  tools/perf/util/evsel_fprintf.c                 |   7 +-
>  tools/perf/util/probe-event.h                   |   2 +
>  tools/perf/util/symbol.c                        |   2 +-
>  tools/perf/util/symbol.h                        |   1 +
>  tools/perf/util/util.c                          |  55 ++++++++-
>  13 files changed, 431 insertions(+), 202 deletions(-)
>  create mode 100644 tools/perf/arch/powerpc/annotate/instructions.c
> 
>   Rebuilding containers, so limited coverage at this time:
>   # dm
>    1 debian:experimental: Ok
>    2 fedora:24: Ok
>    3 fedora:24-x-ARC-uClibc: Ok
>    4 fedora:rawhide: Ok
>    5 opensuse:tumbleweed: Ok
> 
>   # perf test
>    1: vmlinux symtab matches kallsyms                          : Ok
>    2: detect openat syscall event                              : Ok
>    3: detect openat syscall event on all cpus                  : Ok
>    4: read samples using the mmap interface                    : Ok
>    5: parse events tests                                       : Ok
>    6: Validate PERF_RECORD_* events & perf_sample fields       : Ok
>    7: Test perf pmu format parsing                             : Ok
>    8: Test dso data read                                       : Ok
>    9: Test dso data cache                                      : Ok
>   10: Test dso data reopen                                     : Ok
>   11: roundtrip evsel->name check                              : Ok
>   12: Check parsing of sched tracepoints fields                : Ok
>   13: Generate and check syscalls:sys_enter_openat event fields: Ok
>   14: struct perf_event_attr setup                             : Ok
>   15: Test matching and linking multiple hists                 : Ok
>   16: Try 'import perf' in python, checking link problems      : Ok
>   17: Test breakpoint overflow signal handler                  : Ok
>   18: Test breakpoint overflow sampling                        : Ok
>   19: Test number of exit event of a simple workload           : Ok
>   20: Test software clock events have valid period values      : Ok
>   21: Test object code reading                                 : Ok
>   22: Test sample parsing                                      : Ok
>   23: Test using a dummy software event to keep tracking       : Ok
>   24: Test parsing with no sample_id_all bit set               : Ok
>   25: Test filtering hist entries                              : Ok
>   26: Test mmap thread lookup                                  : Ok
>   27: Test thread mg sharing                                   : Ok
>   28: Test output sorting of hist entries                      : Ok
>   29: Test cumulation of child hist entries                    : Ok
>   30: Test tracking with sched_switch                          : Ok
>   31: Filter fds with revents mask in a fdarray                : Ok
>   32: Add fd to a fdarray, making it autogrow                  : Ok
>   33: Test kmod_path__parse function                           : Ok
>   34: Test thread map                                          : Ok
>   35: Test LLVM searching and compiling                        :
>   35.1: Basic BPF llvm compiling test                          : Ok
>   35.2: Test kbuild searching                                  : Ok
>   35.3: Compile source for BPF prologue generation test        : Ok
>   35.4: Compile source for BPF relocation test                 : Ok
>   36: Test topology in session                                 : Ok
>   37: Test BPF filter                                          :
>   37.1: Test basic BPF filtering                               : Ok
>   37.2: Test BPF prologue generation                           : Ok
>   37.3: Test BPF relocation checker                            : Ok
>   38: Test thread map synthesize                               : Ok
>   39: Test cpu map synthesize                                  : Ok
>   40: Test stat config synthesize                              : Ok
>   41: Test stat synthesize                                     : Ok
>   42: Test stat round synthesize                               : Ok
>   43: Test attr update synthesize                              : Ok
>   44: Test events times                                        : Ok
>   45: Test backward reading from ring buffer                   : Ok
>   46: Test cpu map print                                       : Ok
>   47: Test SDT event probing                                   : Ok
>   48: Test is_printable_array function                         : Ok
>   49: Test bitmap print                                        : Ok
>   50: x86 rdpmc test                                           : Ok
>   51: Test converting perf time to TSC                         : Ok
>   52: Test dwarf unwind                                        : Ok
>   53: Test x86 instruction decoder - new instructions          : Ok
>   54: Test intel cqm nmi context read                          : Skip
>   #
>   $ make -C tools/perf build-test
>   make: Entering directory '/home/acme/git/linux/tools/perf'
>   - tarpkg: ./tests/perf-targz-src-pkg .
>              make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
>                make_no_slang_O: make NO_SLANG=1
>                 make_no_gtk2_O: make NO_GTK2=1
>              make_no_libperl_O: make NO_LIBPERL=1
>             make_no_libaudit_O: make NO_LIBAUDIT=1
>         make_with_babeltrace_O: make LIBBABELTRACE=1
>                 make_no_newt_O: make NO_NEWT=1
>              make_util_map_o_O: make util/map.o
>                    make_pure_O: make
>               make_no_libbpf_O: make NO_LIBBPF=1
>                     make_doc_O: make doc
>              make_no_libnuma_O: make NO_LIBNUMA=1
>        make_util_pmu_bison_o_O: make util/pmu-bison.o
>                    make_tags_O: make tags
>          make_install_prefix_O: make install prefix=/tmp/krava
>             make_no_demangle_O: make NO_DEMANGLE=1
>            make_no_libpython_O: make NO_LIBPYTHON=1
>                  make_static_O: make LDFLAGS=-static
>                   make_debug_O: make DEBUG=1
>                   make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
>    make_install_prefix_slash_O: make install prefix=/tmp/krava/
>   make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
>             make_no_auxtrace_O: make NO_AUXTRACE=1
>                 make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
>                  make_perf_o_O: make perf.o
>            make_no_libbionic_O: make NO_LIBBIONIC=1
>               make_clean_all_O: make clean all
>            make_no_backtrace_O: make NO_BACKTRACE=1
>                 make_install_O: make install
>            make_no_libunwind_O: make NO_LIBUNWIND=1
>             make_install_bin_O: make install-bin
>               make_no_libelf_O: make NO_LIBELF=1
>                    make_help_O: make help
>   OK
>   make: Leaving directory '/home/acme/git/linux/tools/perf'
>   $

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

Test results at the end of this message, as usual.

The following changes since commit 7c5314b88da6d5af98239786772a1c44cc5eb67d:

  perf/x86/intel: Add quirk for Goldmont Plus (2018-10-02 10:14:33 +0200)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.20-20181008

for you to fetch changes up to bb3dd7e7c4d5e024d607c0ec06c2a2fb9408cc99:

  tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file (2018-10-08 15:05:37 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

. Fix building the python bindings with python3, which fixes some
  problems with building with clang on Clear Linux (Eduardo Habkost)

. Fix coverity warnings, fixing up some error paths and plugging
  some temporary small buffer leaks (Sanskriti Sharma)

. Adopt a wrapper for strerror_r() for the same reasons as recently
  for libbpf (Steven Rostedt)

. S390 does not support watchpoints in 'perf test 22', check if
  that test is supported by the arch. (Thomas Richter)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
      tools include: Adopt linux/bits.h
      perf auxtrace: Include missing asm/bitsperlong.h to get BITS_PER_LONG

Eduardo Habkost (2):
      perf python: Make clang_has_option() work on Python 3
      perf python: More portable way to make CFLAGS work with clang

Sanskriti Sharma (5):
      perf strbuf: Match va_{add,copy} with va_end
      perf tools: Cleanup trace-event-info 'tdata' leak
      perf tools: Free 'printk' string in parse_ftrace_printk()
      perf tools: Avoid double free in read_event_file()
      perf tools: Free temporary 'sys' string in read_event_files()

Steven Rostedt (VMware) (1):
      tools lib traceevent: Separate out tep_strerror() for strerror_r() issues

Thomas Richter (1):
      perf test: S390 does not support watchpoints in test 22

Tzvetomir Stoyanov (1):
      tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file

 tools/include/linux/bitops.h             |   7 +-
 tools/include/linux/bits.h               |  26 +++
 tools/lib/traceevent/Build               |   2 +
 tools/lib/traceevent/event-parse-api.c   | 275 +++++++++++++++++++++++++++++++
 tools/lib/traceevent/event-parse-local.h |  92 +++++++++++
 tools/lib/traceevent/event-parse.c       |  32 +---
 tools/lib/traceevent/event-parse.h       | 228 ++++---------------------
 tools/lib/traceevent/event-plugin.c      |   1 +
 tools/lib/traceevent/parse-filter.c      |   1 +
 tools/lib/traceevent/tep_strerror.c      |  53 ++++++
 tools/perf/check-headers.sh              |   1 +
 tools/perf/tests/builtin-test.c          |   1 +
 tools/perf/tests/tests.h                 |   1 +
 tools/perf/tests/wp.c                    |  12 ++
 tools/perf/util/auxtrace.h               |   1 +
 tools/perf/util/setup.py                 |  16 +-
 tools/perf/util/strbuf.c                 |  10 +-
 tools/perf/util/trace-event-info.c       |   2 +
 tools/perf/util/trace-event-parse.c      |  26 +--
 tools/perf/util/trace-event-read.c       |  11 +-
 20 files changed, 539 insertions(+), 259 deletions(-)
 create mode 100644 tools/include/linux/bits.h
 create mode 100644 tools/lib/traceevent/event-parse-api.c
 create mode 100644 tools/lib/traceevent/event-parse-local.h
 create mode 100644 tools/lib/traceevent/tep_strerror.c

Test results:

The first ones are container (docker) based builds of tools/perf with
and without libelf support.  Where clang is available, it is also used
to build perf with/without libelf, and building with LIBCLANGLLVM=1
(built-in clang) with gcc and clang when clang and its devel libraries
are installed.

The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.

Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.

The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.

Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.

The Clear Linux container is building with NO_CLANG=1, some problem
preventing its use when building for python3 have been fixed, some more
have been identified and the next builds will build in ClearLinux with
both gcc and clang. This time around only gcc was used.

  # dm
   1 alpine:3.4                    : Ok   gcc (Alpine 5.3.0) 5.3.0
   2 alpine:3.5                    : Ok   gcc (Alpine 6.2.1) 6.2.1 20160822
   3 alpine:3.6                    : Ok   gcc (Alpine 6.3.0) 6.3.0
   4 alpine:3.7                    : Ok   gcc (Alpine 6.4.0) 6.4.0
   5 alpine:3.8                    : Ok   gcc (Alpine 6.4.0) 6.4.0
   6 alpine:edge                   : Ok   gcc (Alpine 6.4.0) 6.4.0
   7 amazonlinux:1                 : Ok   gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
   8 amazonlinux:2                 : Ok   gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
   9 android-ndk:r12b-arm          : Ok   arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
  10 android-ndk:r15c-arm          : Ok   arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
  11 centos:5                      : Ok   gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
  12 centos:6                      : Ok   gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23)
  13 centos:7                      : Ok   gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
  14 clearlinux:latest             : Ok   gcc (Clear Linux OS for Intel Architecture) 8.2.1 20180502
  15 debian:7                      : Ok   gcc (Debian 4.7.2-5) 4.7.2
  16 debian:8                      : Ok   gcc (Debian 4.9.2-10+deb8u1) 4.9.2
  17 debian:9                      : Ok   gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
  18 debian:experimental           : Ok   gcc (Debian 8.2.0-7) 8.2.0
  19 debian:experimental-x-arm64   : Ok   aarch64-linux-gnu-gcc (Debian 8.2.0-4) 8.2.0
  20 debian:experimental-x-mips    : Ok   mips-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0
  21 debian:experimental-x-mips64  : Ok   mips64-linux-gnuabi64-gcc (Debian 8.1.0-12) 8.1.0
  22 debian:experimental-x-mipsel  : Ok   mipsel-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0
  23 fedora:20                     : Ok   gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
  24 fedora:21                     : Ok   gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
  25 fedora:22                     : Ok   gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
  26 fedora:23                     : Ok   gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
  27 fedora:24                     : Ok   gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
  28 fedora:24-x-ARC-uClibc        : Ok   arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
  29 fedora:25                     : Ok   gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
  30 fedora:26                     : Ok   gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2)
  31 fedora:27                     : Ok   gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-6)
  32 fedora:28                     : Ok   gcc (GCC) 8.1.1 20180712 (Red Hat 8.1.1-5)
  33 fedora:rawhide                : Ok   gcc (GCC) 8.2.1 20180905 (Red Hat 8.2.1-3)
  34 gentoo-stage3-amd64:latest    : Ok   gcc (Gentoo 7.3.0-r3 p1.4) 7.3.0
  35 mageia:5                      : Ok   gcc (GCC) 4.9.2
  36 mageia:6                      : Ok   gcc (Mageia 5.5.0-1.mga6) 5.5.0
  37 opensuse:13.2                 : Ok   gcc (SUSE Linux) 4.8.3 20140627 [gcc-4_8-branch revision 212064]
  38 opensuse:42.1                 : Ok   gcc (SUSE Linux) 4.8.5
  39 opensuse:42.2                 : Ok   gcc (SUSE Linux) 4.8.5
  40 opensuse:42.3                 : Ok   gcc (SUSE Linux) 4.8.5
  41 opensuse:tumbleweed           : Ok   gcc (SUSE Linux) 7.3.1 20180323 [gcc-7-branch revision 258812]
  42 oraclelinux:6                 : Ok   gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23.0.1)
  43 oraclelinux:7                 : Ok   gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28.0.1)
  44 ubuntu:12.04.5                : Ok   gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
  45 ubuntu:14.04.4                : Ok   gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
  46 ubuntu:14.04.4-x-linaro-arm64 : Ok   aarch64-linux-gnu-gcc (Linaro GCC 5.5-2017.10) 5.5.0
  47 ubuntu:16.04                  : Ok   gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
  48 ubuntu:16.04-x-arm            : Ok   arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  49 ubuntu:16.04-x-arm64          : Ok   aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  50 ubuntu:16.04-x-powerpc        : Ok   powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  51 ubuntu:16.04-x-powerpc64      : Ok   powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  52 ubuntu:16.04-x-powerpc64el    : Ok   powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  53 ubuntu:16.04-x-s390           : Ok   s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  54 ubuntu:16.10                  : Ok   gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
  55 ubuntu:17.10                  : Ok   gcc (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0
  56 ubuntu:18.04                  : Ok   gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  57 ubuntu:18.04-x-arm            : Ok   arm-linux-gnueabihf-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0
  58 ubuntu:18.04-x-arm64          : Ok   aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0
  59 ubuntu:18.04-x-m68k           : Ok   m68k-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  60 ubuntu:18.04-x-powerpc        : Ok   powerpc-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  61 ubuntu:18.04-x-powerpc64      : Ok   powerpc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  62 ubuntu:18.04-x-powerpc64el    : Ok   powerpc64le-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  63 ubuntu:18.04-x-riscv64        : Ok   riscv64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  64 ubuntu:18.04-x-s390           : Ok   s390x-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  65 ubuntu:18.04-x-sh4            : Ok   sh4-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  66 ubuntu:18.04-x-sparc64        : Ok   sparc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  67 ubuntu:18.10                  : Ok   gcc (Ubuntu 8.2.0-4ubuntu1) 8.2.0
  #

  # uname -a
  Linux jouet 4.19.0-rc4-00022-gad3273d5f1b9 #1 SMP Mon Sep 17 17:18:22 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
  # git log --oneline -1
  bb3dd7e7c4d5 tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file
  # perf version --build-options
  perf version 4.19.rc5.gbb3dd7
                   dwarf: [ on  ]  # HAVE_DWARF_SUPPORT
      dwarf_getlocations: [ on  ]  # HAVE_DWARF_GETLOCATIONS_SUPPORT
                   glibc: [ on  ]  # HAVE_GLIBC_SUPPORT
                    gtk2: [ on  ]  # HAVE_GTK2_SUPPORT
           syscall_table: [ on  ]  # HAVE_SYSCALL_TABLE_SUPPORT
                  libbfd: [ on  ]  # HAVE_LIBBFD_SUPPORT
                  libelf: [ on  ]  # HAVE_LIBELF_SUPPORT
                 libnuma: [ on  ]  # HAVE_LIBNUMA_SUPPORT
  numa_num_possible_cpus: [ on  ]  # HAVE_LIBNUMA_SUPPORT
                 libperl: [ on  ]  # HAVE_LIBPERL_SUPPORT
               libpython: [ on  ]  # HAVE_LIBPYTHON_SUPPORT
                libslang: [ on  ]  # HAVE_SLANG_SUPPORT
               libcrypto: [ on  ]  # HAVE_LIBCRYPTO_SUPPORT
               libunwind: [ on  ]  # HAVE_LIBUNWIND_SUPPORT
      libdw-dwarf-unwind: [ on  ]  # HAVE_DWARF_SUPPORT
                    zlib: [ on  ]  # HAVE_ZLIB_SUPPORT
                    lzma: [ on  ]  # HAVE_LZMA_SUPPORT
               get_cpuid: [ on  ]  # HAVE_AUXTRACE_SUPPORT
                     bpf: [ on  ]  # HAVE_LIBBPF_SUPPORT
  # perf test
   1: vmlinux symtab matches kallsyms                       : Ok
   2: Detect openat syscall event                           : Ok
   3: Detect openat syscall event on all cpus               : Ok
   4: Read samples using the mmap interface                 : Ok
   5: Test data source output                               : Ok
   6: Parse event definition strings                        : Ok
   7: Simple expression parser                              : Ok
   8: PERF_RECORD_* events & perf_sample fields             : Ok
   9: Parse perf pmu format                                 : Ok
  10: DSO data read                                         : Ok
  11: DSO data cache                                        : Ok
  12: DSO data reopen                                       : Ok
  13: Roundtrip evsel->name                                 : Ok
  14: Parse sched tracepoints fields                        : Ok
  15: syscalls:sys_enter_openat event fields                : Ok
  16: Setup struct perf_event_attr                          : Ok
  17: Match and link multiple hists                         : Ok
  18: 'import perf' in python                               : Ok
  19: Breakpoint overflow signal handler                    : Ok
  20: Breakpoint overflow sampling                          : Ok
  21: Breakpoint accounting                                 : Ok
  22: Watchpoint                                            :
  22.1: Read Only Watchpoint                                : Skip
  22.2: Write Only Watchpoint                               : Ok
  22.3: Read / Write Watchpoint                             : Ok
  22.4: Modify Watchpoint                                   : Ok
  23: Number of exit events of a simple workload            : Ok
  24: Software clock events period values                   : Ok
  25: Object code reading                                   : Ok
  26: Sample parsing                                        : Ok
  27: Use a dummy software event to keep tracking           : Ok
  28: Parse with no sample_id_all bit set                   : Ok
  29: Filter hist entries                                   : Ok
  30: Lookup mmap thread                                    : Ok
  31: Share thread mg                                       : Ok
  32: Sort output of hist entries                           : Ok
  33: Cumulate child hist entries                           : Ok
  34: Track with sched_switch                               : Ok
  35: Filter fds with revents mask in a fdarray             : Ok
  36: Add fd to a fdarray, making it autogrow               : Ok
  37: kmod_path__parse                                      : Ok
  38: Thread map                                            : Ok
  39: LLVM search and compile                               :
  39.1: Basic BPF llvm compile                              : Ok
  39.2: kbuild searching                                    : Ok
  39.3: Compile source for BPF prologue generation          : Ok
  39.4: Compile source for BPF relocation                   : Ok
  40: Session topology                                      : Ok
  41: BPF filter                                            :
  41.1: Basic BPF filtering                                 : Ok
  41.2: BPF pinning                                         : Ok
  41.3: BPF prologue generation                             : Ok
  41.4: BPF relocation checker                              : Ok
  42: Synthesize thread map                                 : Ok
  43: Remove thread map                                     : Ok
  44: Synthesize cpu map                                    : Ok
  45: Synthesize stat config                                : Ok
  46: Synthesize stat                                       : Ok
  47: Synthesize stat round                                 : Ok
  48: Synthesize attr update                                : Ok
  49: Event times                                           : Ok
  50: Read backward ring buffer                             : Ok
  51: Print cpu map                                         : Ok
  52: Probe SDT events                                      : Ok
  53: is_printable_array                                    : Ok
  54: Print bitmap                                          : Ok
  55: perf hooks                                            : Ok
  56: builtin clang support                                 : Skip (not compiled in)
  57: unit_number__scnprintf                                : Ok
  58: mem2node                                              : Ok
  59: x86 rdpmc                                             : Ok
  60: Convert perf time to TSC                              : Ok
  61: DWARF unwind                                          : Ok
  62: x86 instruction decoder - new instructions            : Ok
  63: x86 bp modify                                         : Ok
  64: Use vfs_getname probe to get syscall args filenames   : Ok
  65: Check open filename arg using perf trace + vfs_getname: Ok
  66: probe libc's inet_pton & backtrace it with ping       : Ok
  67: Add vfs_getname probe to get syscall args filenames   : Ok

  $ make -C tools/perf build-test
  make: Entering directory '/home/acme/git/perf/tools/perf'
  - tarpkg: ./tests/perf-targz-src-pkg .
            make_install_bin_O: make install-bin
                make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
                make_no_gtk2_O: make NO_GTK2=1
  make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
                make_install_O: make install
           make_no_backtrace_O: make NO_BACKTRACE=1
                make_no_newt_O: make NO_NEWT=1
             make_no_libperl_O: make NO_LIBPERL=1
             make_util_map_o_O: make util/map.o
              make_clean_all_O: make clean all
                 make_static_O: make LDFLAGS=-static
       make_util_pmu_bison_o_O: make util/pmu-bison.o
                  make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
                    make_doc_O: make doc
              make_no_libelf_O: make NO_LIBELF=1
                   make_pure_O: make
            make_no_auxtrace_O: make NO_AUXTRACE=1
                 make_perf_o_O: make perf.o
                   make_tags_O: make tags
             make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
              make_no_libbpf_O: make NO_LIBBPF=1
           make_no_libpython_O: make NO_LIBPYTHON=1
            make_no_libaudit_O: make NO_LIBAUDIT=1
        make_with_babeltrace_O: make LIBBABELTRACE=1
   make_install_prefix_slash_O: make install prefix=/tmp/krava/
             make_no_libnuma_O: make NO_LIBNUMA=1
         make_with_clangllvm_O: make LIBCLANGLLVM=1
                  make_debug_O: make DEBUG=1
           make_no_libunwind_O: make NO_LIBUNWIND=1
           make_no_libbionic_O: make NO_LIBBIONIC=1
               make_no_slang_O: make NO_SLANG=1
                   make_help_O: make help
            make_no_demangle_O: make NO_DEMANGLE=1
         make_install_prefix_O: make install prefix=/tmp/krava
  OK
  make: Leaving directory '/home/acme/git/perf/tools/perf'
  $

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> Test results at the end of this message, as usual.
> 
> The following changes since commit 7c5314b88da6d5af98239786772a1c44cc5eb67d:
> 
>   perf/x86/intel: Add quirk for Goldmont Plus (2018-10-02 10:14:33 +0200)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.20-20181008
> 
> for you to fetch changes up to bb3dd7e7c4d5e024d607c0ec06c2a2fb9408cc99:
> 
>   tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file (2018-10-08 15:05:37 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> . Fix building the python bindings with python3, which fixes some
>   problems with building with clang on Clear Linux (Eduardo Habkost)
> 
> . Fix coverity warnings, fixing up some error paths and plugging
>   some temporary small buffer leaks (Sanskriti Sharma)
> 
> . Adopt a wrapper for strerror_r() for the same reasons as recently
>   for libbpf (Steven Rostedt)
> 
> . S390 does not support watchpoints in 'perf test 22', check if
>   that test is supported by the arch. (Thomas Richter)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
>       tools include: Adopt linux/bits.h
>       perf auxtrace: Include missing asm/bitsperlong.h to get BITS_PER_LONG
> 
> Eduardo Habkost (2):
>       perf python: Make clang_has_option() work on Python 3
>       perf python: More portable way to make CFLAGS work with clang
> 
> Sanskriti Sharma (5):
>       perf strbuf: Match va_{add,copy} with va_end
>       perf tools: Cleanup trace-event-info 'tdata' leak
>       perf tools: Free 'printk' string in parse_ftrace_printk()
>       perf tools: Avoid double free in read_event_file()
>       perf tools: Free temporary 'sys' string in read_event_files()
> 
> Steven Rostedt (VMware) (1):
>       tools lib traceevent: Separate out tep_strerror() for strerror_r() issues
> 
> Thomas Richter (1):
>       perf test: S390 does not support watchpoints in test 22
> 
> Tzvetomir Stoyanov (1):
>       tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file
> 
>  tools/include/linux/bitops.h             |   7 +-
>  tools/include/linux/bits.h               |  26 +++
>  tools/lib/traceevent/Build               |   2 +
>  tools/lib/traceevent/event-parse-api.c   | 275 +++++++++++++++++++++++++++++++
>  tools/lib/traceevent/event-parse-local.h |  92 +++++++++++
>  tools/lib/traceevent/event-parse.c       |  32 +---
>  tools/lib/traceevent/event-parse.h       | 228 ++++---------------------
>  tools/lib/traceevent/event-plugin.c      |   1 +
>  tools/lib/traceevent/parse-filter.c      |   1 +
>  tools/lib/traceevent/tep_strerror.c      |  53 ++++++
>  tools/perf/check-headers.sh              |   1 +
>  tools/perf/tests/builtin-test.c          |   1 +
>  tools/perf/tests/tests.h                 |   1 +
>  tools/perf/tests/wp.c                    |  12 ++
>  tools/perf/util/auxtrace.h               |   1 +
>  tools/perf/util/setup.py                 |  16 +-
>  tools/perf/util/strbuf.c                 |  10 +-
>  tools/perf/util/trace-event-info.c       |   2 +
>  tools/perf/util/trace-event-parse.c      |  26 +--
>  tools/perf/util/trace-event-read.c       |  11 +-
>  20 files changed, 539 insertions(+), 259 deletions(-)
>  create mode 100644 tools/include/linux/bits.h
>  create mode 100644 tools/lib/traceevent/event-parse-api.c
>  create mode 100644 tools/lib/traceevent/event-parse-local.h
>  create mode 100644 tools/lib/traceevent/tep_strerror.c

Pulled, thanks a lot Arnaldo!

	Ingo