From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753335AbcKYWNi (ORCPT <rfc822;w@1wt.eu>);
        Fri, 25 Nov 2016 17:13:38 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:31574 "EHLO
        aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752736AbcKYWNa (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Nov 2016 17:13:30 -0500
Date: Sat, 26 Nov 2016 01:12:41 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, Andreas Dilger <andreas.dilger@intel.com>,
        Oleg Drokin <oleg.drokin@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jinshan Xiong <jinshan.xiong@intel.com>,
        Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH v2] staging: lustre: osc: Performance tune for LRU
Message-ID: <20161125221241.GN6266@mwanda>
References: <1479942105-30220-1-git-send-email-jsimmons@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1479942105-30220-1-git-send-email-jsimmons@infradead.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 23, 2016 at 06:01:45PM -0500, James Simmons wrote:
> From: Jinshan Xiong <jinshan.xiong@intel.com>
> 
> Early launch page LRU work in osc_io_rw_iter_init();
> Change the page LRU shrinking policy by OSC attributes;
> Delete the contented lock osc_object::oo_seatbelt
> 

The cli_name() stuff should be in a separate patch.  It's hard to review
this stuff (or possibly I just found the first deal breaker and gave
up).

Anyway, please review this again and break it up into separate patches.

regards,
dan carpenter

PS:  I glanced at the patch again and the very first line is changing
"lru" to "LRU" in a comment.  We'll get a million performance increases
from that I bet.  Don't mix random white space changes into it...