Re: [PATCH v3 00/11] pwm: imx: Provide atomic operation for IMX PWM driver

Lukasz Majewski
2016-11-08T22:24:44Z

[-- Attachment #1: Type: text/plain, Size: 2434 bytes --]

Dear All,

> This patch set brings atomic operation to i.MX's PWMv2 driver.

Are there any more comments regarding this patch set?

Best regards,
Łukasz Majewski

>
> This work has been supported and suggested by Boris Brezillon [1] and
> Stefan Agner, by showing how simple the transition could be :-).
>
> It has been divided into several steps:
>
> - Remove ipg clock enable/disable code (as proposed by Sascha Hauer)
> - this is the most notable change for v3
>
> - Provide different pwm ops for PWMv1 and PWMv2
>
> - Separate PWMv1 commits from "generic" and non atomic PWM code
>
> NOTE: Since I do _not_ have board with PWMv1, I would like to ask
> somebody for testing
>
> - Move some imx_config_v2 code to separate functions
>
> - Provide PWM atomic implementation (the ->apply() driver) for PWMv2
> in a single patch for better readability.
>
> - Remove redundant PWM code (disable, enable, config callbacks)
>
> - Update proper documentation entries
>
> - Provide support for polarity inversion on top of atomic PWM rework
>
> Test HW:
> --------
> This patch set has been tested on i.MX6q board with
> v4.9-rc3 kernel SHA1: a909d3e636995ba7c349e2ca5dbb528154d4ac30
>
>
> The PWM operation has been tested with pwm_bl backlight driver by
> changing its brightness.
>
> [1]: http://patchwork.ozlabs.org/patch/685402/
>
>
> Lothar Wassmann (2):
> pwm: print error messages with pr_err() instead of pr_debug()
> pwm: core: make the PWM_POLARITY flag in DTB optional
>
> Lukasz Majewski (8):
> pwm: imx: Add separate set of pwm ops for PWMv1 and PWMv2
> pwm: imx: Rewrite imx_pwm_*_v1 code to facilitate switch to atomic
> pwm operation
> pwm: imx: Move PWMv2 software reset code to a separate function
> pwm: imx: Move PWMv2 wait for fifo slot code to a separate function
> pwm: imx: Provide atomic PWM support for i.MX PWMv2
> pwm: imx: Remove redundant i.MX PWMv2 code
> pwm: imx: doc: Update imx-pwm.txt documentation entry
> pwm: imx: Add polarity inversion support to i.MX's PWMv2
>
> Sascha Hauer (1):
> pwm: imx: remove ipg clock
>
> Documentation/devicetree/bindings/pwm/imx-pwm.txt | 6 +-
> drivers/pwm/core.c | 26 +--
> drivers/pwm/pwm-imx.c | 247
> ++++++++++------------ 3 files changed, 134 insertions(+), 145
> deletions(-)
>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]