Re: [PATCH] powercap/intel_rapl: fix and tidy up error handling

Jacob Pan
2016-11-28T17:29:11Z

On Thu, 24 Nov 2016 22:06:59 +0100
"Rafael J. Wysocki" <rafael@kernel.org> wrote:

> On Wed, Nov 23, 2016 at 8:01 PM, Jacob Pan
> <jacob.jun.pan@linux.intel.com> wrote:
> > Commit e1399ba20eee ("powercap / RAPL: handle missing MSRs") added
> > contraint_to_pl() function to return index into an array. But it
> > can potentially return -EINVAL if powercap layer sends an out of
> > range constraint ID. This patch adds sanity check.
> >
> > Unnecessary RAPL domain pointer check is removed since it must be
> > initialized before calling rapl_unit_xlate().
> >
> > Reported-by: Odzioba, Lukasz <lukasz.odzioba@intel.com>
> > Reported-by: Koss, Marcin <marcin.koss@intel.com>
>
> Does this depend on the Thomas' series only?
>
yes, it is on top of Thomas' series.
> Also, it looks like a Fixes: tag should be present here.
>
OK. will add that.
> >
> > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
>
> Thanks,
> Rafael

[Jacob Pan]