From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: mst@redhat.com, arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning
Date: Mon, 28 Nov 2016 06:39:19 -0800 [thread overview]
Message-ID: <20161128143919.GE3924@linux.vnet.ibm.com> (raw)
In-Reply-To: <20161125.195223.1182462379062736127.davem@davemloft.net>
On Fri, Nov 25, 2016 at 07:52:23PM -0500, David Miller wrote:
> From: "Michael S. Tsirkin" <mst@redhat.com>
> Date: Wed, 23 Nov 2016 22:48:19 +0200
>
> > I would appreciate review to confirm the function doesn't
> > do anything unsafe though.
> >
> > In particular, should this use __hlist_for_each_rcu instead?
> > I note that __hlist_for_each_rcu does rcu_dereference
> > internally, which is missing here.
>
> I personally think it should use __hlist_for_each_rcu, otherwise
> nothing expresses the rcu-ness of the operation.
I like Dave's suggestion. Michael, does that change work for you?
Thanx, Paul
next prev parent reply other threads:[~2016-11-28 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 20:48 [PATCH RFC] hlist_add_tail_rcu disable sparse warning Michael S. Tsirkin
2016-11-26 0:52 ` David Miller
2016-11-28 14:39 ` Paul E. McKenney [this message]
2016-11-28 15:30 ` Michael S. Tsirkin
2016-12-05 3:47 ` Michael S. Tsirkin
2016-12-05 3:29 ` Michael S. Tsirkin
2016-12-05 19:37 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128143919.GE3924@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox