From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933211AbcK1P2c (ORCPT ); Mon, 28 Nov 2016 10:28:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34316 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932718AbcK1P2Z (ORCPT ); Mon, 28 Nov 2016 10:28:25 -0500 Date: Mon, 28 Nov 2016 17:28:24 +0200 From: "Michael S. Tsirkin" To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, David Airlie , "open list:VIRTIO GPU DRIVER" , open list Subject: Re: [PATCH] drm/virtio: fix framebuffer sparse warning Message-ID: <20161128172814-mutt-send-email-mst@kernel.org> References: <1480320322-23362-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480320322-23362-1-git-send-email-kraxel@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 28 Nov 2016 15:28:25 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2016 at 09:05:21AM +0100, Gerd Hoffmann wrote: > virtio uses normal ram as backing storage for the framebuffer, so we > should assign the address to new screen_buffer (added by commit > 17a7b0b4d9749f80d365d7baff5dec2f54b0e992) instead of screen_base. > > Reported-by: Michael S. Tsirkin > Signed-off-by: Gerd Hoffmann Acked-by: Michael S. Tsirkin > --- > drivers/gpu/drm/virtio/virtgpu_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_fb.c b/drivers/gpu/drm/virtio/virtgpu_fb.c > index 2242a80..dc2976c 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_fb.c > +++ b/drivers/gpu/drm/virtio/virtgpu_fb.c > @@ -337,7 +337,7 @@ static int virtio_gpufb_create(struct drm_fb_helper *helper, > info->fbops = &virtio_gpufb_ops; > info->pixmap.flags = FB_PIXMAP_SYSTEM; > > - info->screen_base = obj->vmap; > + info->screen_buffer = obj->vmap; > info->screen_size = obj->gem_base.size; > drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth); > drm_fb_helper_fill_var(info, &vfbdev->helper, > -- > 1.8.3.1