From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933358AbcK1PaZ (ORCPT ); Mon, 28 Nov 2016 10:30:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41328 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932718AbcK1PaR (ORCPT ); Mon, 28 Nov 2016 10:30:17 -0500 Date: Mon, 28 Nov 2016 17:30:15 +0200 From: "Michael S. Tsirkin" To: "Paul E. McKenney" Cc: David Miller , arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning Message-ID: <20161128173001-mutt-send-email-mst@kernel.org> References: <20161123223457-mutt-send-email-mst@kernel.org> <20161125.195223.1182462379062736127.davem@davemloft.net> <20161128143919.GE3924@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161128143919.GE3924@linux.vnet.ibm.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 28 Nov 2016 15:30:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2016 at 06:39:19AM -0800, Paul E. McKenney wrote: > On Fri, Nov 25, 2016 at 07:52:23PM -0500, David Miller wrote: > > From: "Michael S. Tsirkin" > > Date: Wed, 23 Nov 2016 22:48:19 +0200 > > > > > I would appreciate review to confirm the function doesn't > > > do anything unsafe though. > > > > > > In particular, should this use __hlist_for_each_rcu instead? > > > I note that __hlist_for_each_rcu does rcu_dereference > > > internally, which is missing here. > > > > I personally think it should use __hlist_for_each_rcu, otherwise > > nothing expresses the rcu-ness of the operation. > > I like Dave's suggestion. Michael, does that change work for you? > > Thanx, Paul I think it does, I'll try and post the patch. -- MST