From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752800AbcK1SOw (ORCPT ); Mon, 28 Nov 2016 13:14:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57970 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbcK1SOo (ORCPT ); Mon, 28 Nov 2016 13:14:44 -0500 Date: Mon, 28 Nov 2016 19:14:41 +0100 From: Jiri Olsa To: David Ahern Cc: David Ahern , acme@kernel.org, mingo@kernel.org, peterz@infradead.org, namhyung@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] perf tool: Add time-based utility functions Message-ID: <20161128181441.GA11055@krava> References: <1480109999-36971-1-git-send-email-dsa@cumulusnetworks.com> <1480109999-36971-2-git-send-email-dsa@cumulusnetworks.com> <20161128135832.GB1928@krava> <1edb9bd4-5697-47d4-9ca1-5f359fa00ac4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1edb9bd4-5697-47d4-9ca1-5f359fa00ac4@gmail.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 28 Nov 2016 18:14:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2016 at 10:35:15AM -0700, David Ahern wrote: > On 11/28/16 6:58 AM, Jiri Olsa wrote: > > On Fri, Nov 25, 2016 at 02:39:54PM -0700, David Ahern wrote: > >> From: David Ahern > >> > >> Add function to parse a user time string of the form , > >> where start and stop are time in sec.nsec format. Both start and stop > >> times are optional. > >> > >> Add function to determine if a sample time is within a given time > >> time window of interest. > >> > >> Signed-off-by: David Ahern > >> --- > >> tools/perf/util/Build | 1 + > >> tools/perf/util/time-utils.c | 85 ++++++++++++++++++++++++++++++++++++++++++++ > >> tools/perf/util/time-utils.h | 12 +++++++ > >> 3 files changed, 98 insertions(+) > >> create mode 100644 tools/perf/util/time-utils.c > >> create mode 100644 tools/perf/util/time-utils.h > >> > >> diff --git a/tools/perf/util/Build b/tools/perf/util/Build > >> index 1dc67efad634..78f139978e7a 100644 > >> --- a/tools/perf/util/Build > >> +++ b/tools/perf/util/Build > >> @@ -87,6 +87,7 @@ libperf-y += help-unknown-cmd.o > >> libperf-y += mem-events.o > >> libperf-y += vsprintf.o > >> libperf-y += drv_configs.o > >> +libperf-y += time-utils.o > > > > I think we should call it just time.c, it's already in 'util' directory > > can't rename time-utils.h to time.h because the include will get confused with and if the header is named time-utils.h why not keep the c-file as time-utils.c? > ok, haven't realized that.. can't think of another name ;-) there are some time related functions in util.[ch], maybe you coudl move them as well int fetch_current_timestamp(char *buf, size_t sz); int timestamp__scnprintf_usec(u64 timestamp, char *buf, size_t sz); jirka