From: Andi Kleen <andi@firstfloor.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andi Kleen <andi@firstfloor.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Jan Stancek <jstancek@redhat.com>
Subject: Re: [BUG] msr-trace.h:42 suspicious rcu_dereference_check() usage!
Date: Mon, 28 Nov 2016 13:48:25 -0800 [thread overview]
Message-ID: <20161128214825.GJ26852@two.firstfloor.org> (raw)
In-Reply-To: <20161123210618.5103f25d@gandalf.local.home>
> I took a look at this and forced some more functions to be inlined. I
> did a little tweaking here and there. Could you pull my tree and see if
> things are better? I don't currently have the hardware to run this
> myself.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
>
> branch: ftrace/core
Didn't help much unfortunately. I think you need a real fast path here.
http://halobates.de/tracepoint-trace2
$ wc -l tracepoint-trace2
595 tracepoint-trace2
Opcode Histogram:
201 mov
51 push
51 pop
34 test
32 cmp
26 jz
24 jnz
24 and
16 ret
16 lea
15 call
12 add
10 jmp
Functions with # of instructions:
25 trace_event_raw_event_sched_switch
19 trace_event_buffer_reserve
21 trace_event_buffer_lock_reserve
57 ring_buffer_lock_reserve
3 trace_clock_local
3 sched_clock
24 native_sched_clock
3 sched_clock
2 trace_clock_local
11 ring_buffer_lock_reserve
81 __rb_reserve_next
11 ring_buffer_lock_reserve
6 trace_event_buffer_lock_reserve
18 ring_buffer_event_data
5 trace_event_buffer_lock_reserve
38 tracing_generic_entry_update
11 trace_event_buffer_lock_reserve
5 trace_event_buffer_reserve
18 ring_buffer_event_data
4 trace_event_buffer_reserve
28 trace_event_raw_event_sched_switch
30 trace_event_buffer_commit
19 trace_buffer_unlock_commit_regs
11 ring_buffer_unlock_commit
85 rb_commit
18 ring_buffer_unlock_commit
10 trace_buffer_unlock_commit_regs
3 ftrace_trace_userstack
7 trace_buffer_unlock_commit_regs
11 trace_event_buffer_commit
8 trace_event_raw_event_sched_switch
-Andi
next prev parent reply other threads:[~2016-11-28 21:48 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 0:53 [BUG] msr-trace.h:42 suspicious rcu_dereference_check() usage! Jiri Olsa
2016-11-21 9:02 ` Paul E. McKenney
2016-11-21 9:43 ` Peter Zijlstra
2016-11-21 11:00 ` Paul E. McKenney
2016-11-21 9:28 ` Peter Zijlstra
2016-11-21 9:34 ` Jiri Olsa
2016-11-21 9:42 ` Peter Zijlstra
2016-11-21 11:22 ` Jiri Olsa
2016-11-21 11:31 ` Peter Zijlstra
2016-11-21 12:49 ` Jiri Olsa
2016-11-21 12:58 ` Peter Zijlstra
2016-11-21 14:15 ` Steven Rostedt
2016-11-21 14:37 ` Peter Zijlstra
2016-11-21 15:35 ` Borislav Petkov
2016-11-21 15:41 ` Peter Zijlstra
2016-11-21 16:06 ` Borislav Petkov
2016-11-29 13:16 ` Borislav Petkov
2016-11-29 13:59 ` Thomas Gleixner
2016-11-30 8:48 ` Borislav Petkov
2016-11-30 8:54 ` Thomas Gleixner
2016-11-30 9:07 ` Borislav Petkov
2016-11-30 9:14 ` Thomas Gleixner
2016-11-29 14:04 ` Jiri Olsa
2016-11-21 14:20 ` Steven Rostedt
2016-11-21 17:06 ` Andi Kleen
2016-11-21 17:18 ` Peter Zijlstra
2016-11-21 17:45 ` Andi Kleen
2016-11-21 18:01 ` Steven Rostedt
2016-11-21 18:06 ` Andi Kleen
2016-11-21 18:22 ` Steven Rostedt
2016-11-21 18:37 ` Andi Kleen
2016-11-21 19:06 ` Steven Rostedt
2016-11-21 19:15 ` Steven Rostedt
2016-11-21 20:44 ` Andi Kleen
2016-11-22 8:19 ` Paul E. McKenney
2016-11-22 14:39 ` Steven Rostedt
2016-11-22 19:05 ` Andi Kleen
2016-11-24 2:06 ` Steven Rostedt
2016-11-28 21:48 ` Andi Kleen [this message]
2016-11-28 22:46 ` Steven Rostedt
2016-11-28 23:10 ` Andi Kleen
2016-11-21 17:55 ` Steven Rostedt
2016-11-21 18:24 ` Steven Rostedt
2016-11-21 20:12 ` Paul E. McKenney
2017-02-23 12:24 ` Jiri Olsa
2017-02-23 17:11 ` Andi Kleen
2017-02-23 17:28 ` Peter Zijlstra
2017-02-23 17:56 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128214825.GJ26852@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=jolsa@redhat.com \
--cc=josh@joshtriplett.org \
--cc=jstancek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox