From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755384AbcK1WNc (ORCPT ); Mon, 28 Nov 2016 17:13:32 -0500 Received: from mail-pg0-f53.google.com ([74.125.83.53]:35365 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515AbcK1WNY (ORCPT ); Mon, 28 Nov 2016 17:13:24 -0500 Date: Mon, 28 Nov 2016 14:13:21 -0800 From: Brian Norris To: Lee Jones Cc: Olof Johansson , Benson Leung , linux-kernel@vger.kernel.org, Doug Anderson , Brian Norris , Javier Martinez Canillas , Shawn Nematbakhsh , Gwendal Grignou , Enric Balletbo , Tomeu Vizoso Subject: Re: [PATCH] mfd: cros_ec: Use proper protocol transfer function Message-ID: <20161128221320.GA55972@google.com> References: <1470861912-130475-1-git-send-email-briannorris@chromium.org> <20161122221932.GA60416@google.com> <20161123083749.GN10134@dell.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161123083749.GN10134@dell.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, On Wed, Nov 23, 2016 at 08:37:49AM +0000, Lee Jones wrote: > On Tue, 22 Nov 2016, Brian Norris wrote: > > On Wed, Aug 10, 2016 at 01:45:12PM -0700, Brian Norris wrote: > > > From: Shawn Nematbakhsh > > > > > > pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had > > > one instance of these functions correct, but not the second, fall-back > > > case. We use the fall-back only when the first command returns an > > > IN_PROGRESS status, which is only used on some EC firmwares where we > > > don't want to constantly poll the bus, but instead back off and > > > sleep/retry for a little while. > > > > > > Fixes: 2c7589af3c4d ("mfd: cros_ec: add proto v3 skeleton") > > You need to Cc stable with a note saying which kernel version it > fixes. Grep the `git log`s for stable.*#. I understand how the stable process works. This was intentional. Fixes != stable. It's easy to tag what commit it's supposed to fix. It's less easy to backport and verify that it's a useful for all affected kernels. (If somebody else determines it should be backported -- e.g., Benson or Olof -- then I won't stop them, of course.) Side note: isn't 'Fixes' a more accurate way of describing which version it applies to than just putting the kernel version with a '#' comment? That helps anyone who might have backported the buggy commit -- e.g., as part of the stable process. > > > Signed-off-by: Shawn Nematbakhsh > > > Signed-off-by: Brian Norris > > > --- > > > MAINTAINERS tells me this goes through Olof, but many things have gone through > > > Lee. > > > > I believe this was supposed to go through Olof. Olof, are you out there? > > Yes, I concur. > > There maybe some confusion since the $SUBJECT line is > misleading/incorrect. Thanks. I'll resend with a 'platform/chrome:' prefix, and make sure it shows up in Benson's inbox too. I think I didn't look deeply enough into history -- the last few commits touching drivers/platform/chrome/ had an 'mfd' tag, but they also happened to touch mfd-prefixed files too. Brian > > Or Benson? I see this: > > > > http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1273587.html > > [PATCH] platform/chrome : Add myself as Maintainer > > > > but it's not merged anywhere AFAICT. > > > > I can resend if that helps. > > > > Brian [...]