From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756345AbcK2IMW (ORCPT <rfc822;w@1wt.eu>);
        Tue, 29 Nov 2016 03:12:22 -0500
Received: from relay1.mentorg.com ([192.94.38.131]:42501 "EHLO
        relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755083AbcK2IMV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 29 Nov 2016 03:12:21 -0500
Date: Tue, 29 Nov 2016 13:42:05 +0530
From: Sandeep Jain <Sandeep_Jain@mentor.com>
To: Marek Vasut <marek.vasut@gmail.com>
CC: Richard Weinberger <richard.weinberger@gmail.com>,
        Steve Longerbeam <steve_longerbeam@mentor.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Jim Baxter <jim_baxter@mentor.com>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: Allocate bdi objects dynamically
Message-ID: <20161129081204.GA6617@mentor.com>
References: <Sandeep_Jain@mentor.com>
 <1470319275-9465-1-git-send-email-Sandeep_Jain@mentor.com>
 <CAFLxGvx6B02c+HgYwJ8exVLT6owrkQL1Rq+X6VzUDKVUxE=aoQ@mail.gmail.com>
 <20161103113421.GA4873@mentor.com>
 <4055a3ed-c024-4c29-45e1-e600cdc5902e@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <4055a3ed-c024-4c29-45e1-e600cdc5902e@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Originating-IP: [137.202.0.87]
X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To
 SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dear Maintainers,
   This patch is already reviewed twice with no issues.
Requesting your attention for patch merge.

Thanks & Regards,
Sandeep Jain

On Sat, Nov 05, 2016 at 08:22:31AM +0100, Marek Vasut wrote:
> On 11/03/2016 12:34 PM, Sandeep Jain wrote:
> > Dear Maintainers,
> >   This patch is reviewed by Richard.
> > Requesting for Maintainer's attention for patch merge.
> > 
> > Thanks & Regards,
> > Sandeep Jain
> > 
> > On Sat, Sep 17, 2016 at 04:41:47PM +0200, Richard Weinberger wrote:
> >> On Thu, Aug 4, 2016 at 4:01 PM, Sandeep Jain <Sandeep_Jain@mentor.com> wrote:
> >>> From: Steve Longerbeam <steve_longerbeam@mentor.com>
> >>>
> >>> The MTD backing dev info objects mtd_bdi was statically allocated.
> >>> So when MTD is built as a loadable module, this object fall in the
> >>> vmalloc address space.
> >>>
> >>> The problem with that, is that the BDI APIs use wake_up_bit(), which calls
> >>> virt_to_page() to retrieve the memory zone of the page containing the
> >>> wait_queue to wake up, and virt_to_page() is not valid for vmalloc or
> >>> highmem addresses.
> >>>
> >>> Fix this by allocating the BDI objects dynamically with kmalloc. The
> >>> objects now fall in the logical address space so that BDI APIs will
> >>> work in all cases (mtd builtin or module).
> >>>
> >>> Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
> >>> Signed-off-by: Jim Baxter <jim_baxter@mentor.com>
> >>> Signed-off-by: Sandeep Jain <Sandeep_Jain@mentor.com>
> >>
> >> Reviewed-by: Richard Weinberger <richard@nod.at>
> 
> I don't see any obvious problem either:
> Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
> 
> -- 
> Best regards,
> Marek Vasut