From: Michal Marek <mmarek@suse.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Cheah Kok Cheong <thrust73@gmail.com>,
Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Scripts: kconfig: nconf: fix _GNU_SOURCE redefined warning
Date: Tue, 29 Nov 2016 14:05:08 +0100 [thread overview]
Message-ID: <20161129130508.GA16422@sepie.suse.cz> (raw)
In-Reply-To: <1480364961.1959.9.camel@tiscali.nl>
On Mon, Nov 28, 2016 at 09:29:21PM +0100, Paul Bolle wrote:
> [Dropped Yann.]
>
> On Tue, 2016-11-29 at 02:46 +0800, Cheah Kok Cheong wrote:
> > On Mon, Nov 28, 2016 at 11:39:01AM +0100, Michal Marek wrote:
> > > The Makefile does not specify -D_GNU_SOURCE. Are you adding it manually?
>
> On Fedora 24 I'm able to trigger this too:
> $ [...]
> make -f ./scripts/Makefile.build obj=scripts/kconfig nconfig
> gcc -Wp,-MD,scripts/kconfig/.nconf.o.d -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer -std=gnu89 -D_GNU_SOURCE -DCURSES_LOC="<ncurses.h>" -DNCURSES_WIDECHAR=1 -DLOCALE -c -o scripts/kconfig/nconf.o scripts/kconfig/nconf.c
> scripts/kconfig/nconf.c:8:0: warning: "_GNU_SOURCE" redefined
> #define _GNU_SOURCE
>
> <command-line>:0:0: note: this is the location of the previous definition
>
> It's probably added by pkg-config:
> $ pkg-config --cflags ncursesw
> -D_GNU_SOURCE
I see. That's not nice of the pkconfig file to set such macro, but oh
well. I applied the patch to kbuild.git#kconfig now, thanks Cheah.
Michal
prev parent reply other threads:[~2016-11-29 13:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 16:28 [PATCH] Scripts: kconfig: nconf: fix _GNU_SOURCE redefined warning Cheah Kok Cheong
2016-11-28 10:39 ` Michal Marek
2016-11-28 18:46 ` Cheah Kok Cheong
2016-11-28 20:29 ` Paul Bolle
2016-11-29 13:05 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129130508.GA16422@sepie.suse.cz \
--to=mmarek@suse.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=pebolle@tiscali.nl \
--cc=thrust73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).