From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757617AbcK2QCc (ORCPT ); Tue, 29 Nov 2016 11:02:32 -0500 Received: from mail.kernel.org ([198.145.29.136]:60362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755553AbcK2QCX (ORCPT ); Tue, 29 Nov 2016 11:02:23 -0500 Date: Tue, 29 Nov 2016 13:02:12 -0300 From: Arnaldo Carvalho de Melo To: David Ahern Cc: Jiri Olsa , David Ahern , mingo@kernel.org, peterz@infradead.org, namhyung@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] perf tool: Add time-based utility functions Message-ID: <20161129160212.GA23423@kernel.org> References: <1480109999-36971-1-git-send-email-dsa@cumulusnetworks.com> <1480109999-36971-2-git-send-email-dsa@cumulusnetworks.com> <20161128135846.GD1928@krava> <99a68c84-ef38-6707-b8d4-16332bda56d4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <99a68c84-ef38-6707-b8d4-16332bda56d4@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Nov 28, 2016 at 10:27:08AM -0700, David Ahern escreveu: > On 11/28/16 6:58 AM, Jiri Olsa wrote: > > On Fri, Nov 25, 2016 at 02:39:54PM -0700, David Ahern wrote: > > > > SNIP > > > >> diff --git a/tools/perf/util/time-utils.h b/tools/perf/util/time-utils.h > >> new file mode 100644 > >> index 000000000000..4368a481251d > >> --- /dev/null > >> +++ b/tools/perf/util/time-utils.h > >> @@ -0,0 +1,12 @@ > >> +#ifndef _TIME_UTILS_H_ > >> +#define _TIME_UTILS_H_ > >> + > >> +struct perf_time { > >> + u64 start, end; > >> +}; > > > > hum, it's more interval rather than 'time' > > would perf_interval, perf_time_interval suit better? > > I'll flip to perf_interval. Humm, I'd prefer 'time_interval' or 'perf_time_interval', plain 'interval' doesn't convey what kind if interval is this, we could be talking about counter values intervals, etc. I was even expecting libc or POSIX to have something like this, but from a quick look I couldn't find anything :-\ > ack to the other 2 comments on this patch. Ok, waiting for v2 then. - Arnaldo